Revision of https://git.drupal.org/project/ckeditor_nofollow.git from Tue, 05/14/2019 - 19:16

Revisions allow you to track differences between multiple versions of your content, and revert back to older versions.

Review of the 8.x-1.x branch (commit 6714003):
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • ESLint has found some issues with your code (please check the JavaScript coding standards). See attachment.
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: ...eb/vendor/drupal/pareviewsh/pareview_temp/ckeditor_nofollow.info.yml
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     6 | WARNING | All dependencies must be prefixed with the project name,
       |         | for example "drupal:"
    --------------------------------------------------------------------------
    
    Time: 113ms; Memory: 4Mb
    
  • No automated test cases were found, did you consider writing PHPUnit tests? This is not a requirement but encouraged for professional software development.
This automated report was generated with PAReview.sh, your friendly project application review script.

FILE: ...00000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/README.txt
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
 24 | WARNING | Line exceeds 80 characters; contains 92 characters
--------------------------------------------------------------------------


FILE: ...upal/pareviewsh/pareview_temp/src/Plugin/CKEditorPlugin/NoFollow.php
--------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
--------------------------------------------------------------------------
 21 | ERROR   | [x] Expected 1 blank line before function; 0 found
 55 | WARNING | [x] A comma should follow the last multiline array item.
    |         |     Found: ]
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Time: 361ms; Memory: 4Mb
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/plugins/nofollow/plugin.js: line 18, col 5, Error - Expected indentation of 2 spaces but found 4. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/plugins/nofollow/plugin.js: line 20, col 5, Error - Expected indentation of 2 spaces but found 4. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/plugins/nofollow/plugin.js: line 21, col 9, Error - Expected indentation of 6 spaces but found 8. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/plugins/nofollow/plugin.js: line 22, col 9, Error - Expected indentation of 6 spaces but found 8. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/plugins/nofollow/plugin.js: line 23, col 9, Error - Expected indentation of 6 spaces but found 8. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/plugins/nofollow/plugin.js: line 24, col 9, Error - Expected indentation of 6 spaces but found 8. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/plugins/nofollow/plugin.js: line 25, col 13, Error - 'canUndo:' is defined but never used. (no-unused-labels)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/plugins/nofollow/plugin.js: line 25, col 13, Error - Expected indentation of 10 spaces but found 12. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/plugins/nofollow/plugin.js: line 25, col 13, Error - Unexpected labeled statement. (no-labels)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/plugins/nofollow/plugin.js: line 25, col 22, Error - Expected an assignment or function call and instead saw an expression. (no-unused-expressions)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/plugins/nofollow/plugin.js: line 25, col 26, Error - Unexpected use of comma operator. (no-sequences)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/plugins/nofollow/plugin.js: line 27, col 29, Error - There should be no spaces inside this paren. (space-in-parens)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/plugins/nofollow/plugin.js: line 27, col 29, Error - Missing space before function parentheses. (space-before-function-paren)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/plugins/nofollow/plugin.js: line 27, col 38, Error - There should be no spaces inside this paren. (space-in-parens)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/plugins/nofollow/plugin.js: line 30, col 21, Error - Expected indentation of 18 spaces but found 20. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/plugins/nofollow/plugin.js: line 31, col 25, Error - Expected indentation of 22 spaces but found 24. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/plugins/nofollow/plugin.js: line 31, col 61, Error - Missing space before opening brace. (space-before-blocks)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/plugins/nofollow/plugin.js: line 32, col 29, Error - Expected indentation of 26 spaces but found 28. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/plugins/nofollow/plugin.js: line 34, col 25, Error - Expected indentation of 22 spaces but found 24. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/plugins/nofollow/plugin.js: line 35, col 29, Error - Expected indentation of 26 spaces but found 28. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/plugins/nofollow/plugin.js: line 42, col 13, Error - Expected indentation of 10 spaces but found 12. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/plugins/nofollow/plugin.js: line 42, col 43, Error - There should be no spaces inside this paren. (space-in-parens)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/plugins/nofollow/plugin.js: line 42, col 45, Error - There should be no space after '{'. (object-curly-spacing)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/plugins/nofollow/plugin.js: line 42, col 73, Error - There should be no space after '{'. (object-curly-spacing)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/plugins/nofollow/plugin.js: line 42, col 75, Error - Properties shouldn't be quoted as all quotes are redundant. (quote-props)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/plugins/nofollow/plugin.js: line 42, col 93, Error - There should be no space before '}'. (object-curly-spacing)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/plugins/nofollow/plugin.js: line 42, col 95, Error - There should be no space before '}'. (object-curly-spacing)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/plugins/nofollow/plugin.js: line 44, col 13, Error - Expected indentation of 10 spaces but found 12. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/plugins/nofollow/plugin.js: line 44, col 42, Error - There should be no spaces inside this paren. (space-in-parens)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/plugins/nofollow/plugin.js: line 44, col 59, Error - Missing space before function parentheses. (space-before-function-paren)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/plugins/nofollow/plugin.js: line 44, col 59, Error - There should be no spaces inside this paren. (space-in-parens)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/plugins/nofollow/plugin.js: line 44, col 67, Error - There should be no spaces inside this paren. (space-in-parens)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/plugins/nofollow/plugin.js: line 45, col 15, Error - Expected an assignment or function call and instead saw an expression. (no-unused-expressions)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/plugins/nofollow/plugin.js: line 45, col 52, Error - There should be no spaces inside this paren. (space-in-parens)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/plugins/nofollow/plugin.js: line 45, col 65, Error - There should be no spaces inside this paren. (space-in-parens)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/plugins/nofollow/plugin.js: line 45, col 75, Error - There should be no spaces inside this paren. (space-in-parens)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/plugins/nofollow/plugin.js: line 45, col 83, Error - There should be no spaces inside this paren. (space-in-parens)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/plugins/nofollow/plugin.js: line 46, col 15, Error - There should be no spaces inside this paren. (space-in-parens)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/plugins/nofollow/plugin.js: line 48, col 13, Error - Expected indentation of 10 spaces but found 12. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/plugins/nofollow/plugin.js: line 49, col 17, Error - Expected indentation of 14 spaces but found 16. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/plugins/nofollow/plugin.js: line 50, col 17, Error - Expected indentation of 14 spaces but found 16. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/plugins/nofollow/plugin.js: line 51, col 17, Error - Expected indentation of 14 spaces but found 16. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/plugins/nofollow/plugin.js: line 52, col 17, Error - Expected indentation of 14 spaces but found 16. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/plugins/nofollow/plugin.js: line 58, col 5, Error - Expected indentation of 2 spaces but found 4. (indent)

44 problems