https://git.drupal.org/project/classy_paragraphs.git 8.x-1.x

Primary tabs

Git errors: Review of the 8.x-1.x branch (commit f9ac0be):
  • Your README.txt does not follow best practices (headings need to be uppercase). See https://www.drupal.org/node/2181737 .
    • The INTRODUCTION section is missing.
    • The REQUIREMENTS section is missing.
    • The INSTALLATION section is missing.
    • The CONFIGURATION section is missing.
  • The classy_paragraphs.module does not implement hook_help(). See https://www.drupal.org/docs/develop/documenting-your-project/module-docu... .
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: ...upal/pareviewsh/pareview_temp/src/Form/ClassyParagraphsStyleForm.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
    --------------------------------------------------------------------------
     42 | WARNING | t() calls should be avoided in classes, use dependency
        |         | injection and $this->t() instead
     45 | WARNING | t() calls should be avoided in classes, use dependency
        |         | injection and $this->t() instead
    --------------------------------------------------------------------------
    
    
    FILE: ...tests/modules/classy_paragraphs_test/classy_paragraphs_test.info.yml
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 7 WARNINGS AFFECTING 7 LINES
    --------------------------------------------------------------------------
      7 | WARNING | All dependencies must be prefixed with the project name,
        |         | for example "drupal:"
      8 | WARNING | All dependencies must be prefixed with the project name,
        |         | for example "drupal:"
      9 | WARNING | All dependencies must be prefixed with the project name,
        |         | for example "drupal:"
     10 | WARNING | All dependencies must be prefixed with the project name,
        |         | for example "drupal:"
     11 | WARNING | All dependencies must be prefixed with the project name,
        |         | for example "drupal:"
     12 | WARNING | All dependencies must be prefixed with the project name,
        |         | for example "drupal:"
     13 | WARNING | All dependencies must be prefixed with the project name,
        |         | for example "drupal:"
    --------------------------------------------------------------------------
    
    
    FILE: ...eb/vendor/drupal/pareviewsh/pareview_temp/classy_paragraphs.info.yml
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     7 | WARNING | All dependencies must be prefixed with the project name,
       |         | for example "drupal:"
    --------------------------------------------------------------------------
    
    Time: 417ms; Memory: 4Mb
    
This automated report was generated with PAReview.sh, your friendly project application review script.

FILE: ...00000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/README.txt
--------------------------------------------------------------------------
FOUND 1 ERROR AND 4 WARNINGS AFFECTING 5 LINES
--------------------------------------------------------------------------
  4 | WARNING | [ ] Line exceeds 80 characters; contains 321 characters
 10 | WARNING | [ ] Line exceeds 80 characters; contains 84 characters
 14 | WARNING | [ ] Line exceeds 80 characters; contains 111 characters
 16 | WARNING | [ ] Line exceeds 80 characters; contains 308 characters
 20 | ERROR   | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: .../web/vendor/drupal/pareviewsh/pareview_temp/classy_paragraphs.module
--------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
--------------------------------------------------------------------------
 21 | ERROR | [x] Expected 1 space after FOREACH keyword; 0 found
 33 | ERROR | [x] Expected 1 space after FOREACH keyword; 0 found
 40 | ERROR | [x] Expected 1 space after FOREACH keyword; 0 found
 44 | ERROR | [x] Expected 1 space after IF keyword; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...drupal/pareviewsh/pareview_temp/src/Entity/ClassyParagraphsStyle.php
--------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 1 LINE
--------------------------------------------------------------------------
 57 | ERROR | [x] Doc comment short description must end with a full stop
 57 | ERROR | [ ] Doc comment short description must be on a single line,
    |       |     further text should be a separate paragraph
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...al/pareviewsh/pareview_temp/src/ClassyParagraphsStyleListBuilder.php
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 15 | ERROR | [x] Expected 1 blank line before function; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...upal/pareviewsh/pareview_temp/src/ClassyParagraphsStyleInterface.php
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 15 | ERROR | Return type missing for @return tag in function comment
--------------------------------------------------------------------------


FILE: ...r/drupal/pareviewsh/pareview_temp/src/Tests/ClassyParagraphsTest.php
--------------------------------------------------------------------------
FOUND 7 ERRORS AFFECTING 6 LINES
--------------------------------------------------------------------------
  21 | ERROR | [ ] If the line declaring an array spans longer than 80
     |       |     characters, each element should be broken into its own
     |       |     line
  31 | ERROR | [x] Closing parenthesis of array declaration must be on a
     |       |     new line
  38 | ERROR | [ ] Missing parameter comment
  38 | ERROR | [ ] Missing parameter type
  39 | ERROR | [ ] Missing parameter comment
 101 | ERROR | [x] Expected 1 blank line after function; 0 found
 102 | ERROR | [x] The closing brace for the class must have an empty
     |       |     line before it
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...areviewsh/pareview_temp/src/Form/ClassyParagraphsStyleDeleteForm.php
--------------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES
--------------------------------------------------------------------------
 16 | ERROR   | [x] Expected 1 blank line before function; 0 found
 17 | ERROR   | [x] Short array syntax must be used to define arrays
 44 | WARNING | [x] A comma should follow the last multiline array item.
    |         |     Found: )
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...upal/pareviewsh/pareview_temp/src/Form/ClassyParagraphsStyleForm.php
--------------------------------------------------------------------------
FOUND 6 ERRORS AND 1 WARNING AFFECTING 7 LINES
--------------------------------------------------------------------------
  5 | WARNING | [x] Unused use statement
 18 | ERROR   | [x] Expected 1 blank line before function; 0 found
 23 | ERROR   | [x] Short array syntax must be used to define arrays
 32 | ERROR   | [x] Short array syntax must be used to define arrays
 35 | ERROR   | [x] Short array syntax must be used to define arrays
 40 | ERROR   | [x] Whitespace found at end of line
 41 | ERROR   | [x] Short array syntax must be used to define arrays
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 7 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...dor/drupal/pareviewsh/pareview_temp/classy_paragraphs.links.menu.yml
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 7 | ERROR | [x] Expected 1 newline at end of file; 2 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...vendor/drupal/pareviewsh/pareview_temp/classy_paragraphs.routing.yml
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 41 | ERROR | [x] Expected 1 newline at end of file; 2 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...r/drupal/pareviewsh/pareview_temp/classy_paragraphs.links.action.yml
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 5 | ERROR | [x] Expected 1 newline at end of file; 2 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Time: 1.05 secs; Memory: 4Mb