https://git.drupal.org/project/cloud.git

Primary tabs

Git errors: Review of the 8.x-1.x branch (commit b88d578):
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards).
    
    FILE: ...s_cloud/config/install/system.action.aws_cloud_vpc_delete_action.yml
    --------------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    --------------------------------------------------------------------------
     10 | ERROR | [x] Expected 1 newline at end of file; 0 found
    --------------------------------------------------------------------------
    PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    --------------------------------------------------------------------------
    
    
    FILE: ...ervice_providers/aws_cloud/tests/src/Functional/AwsCloudTestCase.php
    --------------------------------------------------------------------------
    FOUND 2 ERRORS AFFECTING 2 LINES
    --------------------------------------------------------------------------
     120 | ERROR | Parameter tags must be grouped together in a doc comment
     123 | ERROR | Exception type missing for @throws tag in function comment
    --------------------------------------------------------------------------
    
    Time: 1 mins, 16.68 secs; Memory: 34Mb
    
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: ...service_providers/aws_cloud/src/Controller/Vpc/SubnetListBuilder.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     27 | WARNING | Variable $row is undefined.
    --------------------------------------------------------------------------
    
    
    FILE: ...ud_service_providers/aws_cloud/src/Controller/Vpc/VpcListBuilder.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     27 | WARNING | Variable $row is undefined.
    --------------------------------------------------------------------------
    
    
    FILE: ...es/cloud_service_providers/aws_cloud/src/Form/Vpc/SubnetEditForm.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     93 | WARNING | Unused variable $old_vpc.
    --------------------------------------------------------------------------
    
    
    FILE: ...es/cloud_service_providers/aws_cloud/src/Form/Ec2/VolumeEditForm.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     165 | WARNING | Unused variable $result.
    --------------------------------------------------------------------------
    
    
    FILE: ...iew_temp/modules/cloud_service_providers/aws_cloud/aws_cloud.install
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 6 WARNINGS AFFECTING 6 LINES
    --------------------------------------------------------------------------
      928 | WARNING | Variable $entities is undefined.
      930 | WARNING | Variable $aws_ec2_service is undefined.
      931 | WARNING | Variable $aws_ec2_service is undefined.
     1183 | WARNING | Variable $entities is undefined.
     1185 | WARNING | Variable $aws_ec2_service is undefined.
     1186 | WARNING | Variable $aws_ec2_service is undefined.
    --------------------------------------------------------------------------
    
    
    FILE: ...oviders/aws_cloud/tests/src/Functional/Config/AwsCloudConfigTest.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     296 | WARNING | Unused variable $path_prefix.
    --------------------------------------------------------------------------
    
    
    FILE: ...rvice_providers/aws_cloud/tests/src/Functional/Ec2/ElasticIpTest.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
    --------------------------------------------------------------------------
     235 | WARNING | Unused variable $network_interface_id.
     240 | WARNING | Unused variable $domain.
     332 | WARNING | Unused variable $network_interface_id.
     339 | WARNING | Unused variable $domain.
    --------------------------------------------------------------------------
    
    
    FILE: ...ervice_providers/aws_cloud/tests/src/Functional/Ec2/InstanceTest.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 1 LINE
    --------------------------------------------------------------------------
     799 | WARNING | Unused variable $network_interface_id.
     799 | WARNING | Unused variable $name.
    --------------------------------------------------------------------------
    
    
    FILE: ...roviders/aws_cloud/tests/src/Functional/Ec2/NetworkInterfaceTest.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
    --------------------------------------------------------------------------
      54 | WARNING | Unused variable $entities.
     342 | WARNING | Unused variable $random.
    --------------------------------------------------------------------------
    
    
    FILE: ...view_temp/modules/cloud_service_providers/aws_cloud/aws_cloud.module
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     1931 | WARNING | Unused variable $aws_ec2_service.
    --------------------------------------------------------------------------
    
    Time: 54.69 secs; Memory: 30Mb
    
This automated report was generated with PAReview.sh, your friendly project application review script.