Revision of https://git.drupal.org/project/commerce_vado.git from Thu, 01/10/2019 - 19:31

Revisions allow you to track differences between multiple versions of your content, and revert back to older versions.

Review of the 8.x-1.x branch (commit 14c17fe):
  • Your README.txt does not follow best practices (headings need to be uppercase). See https://www.drupal.org/node/2181737 .
    • The INTRODUCTION section is missing.
    • The REQUIREMENTS section is missing.
    • The INSTALLATION section is missing.
    • The CONFIGURATION section is missing.
  • The commerce_vado.module does not implement hook_help(). See https://www.drupal.org/docs/develop/documenting-your-project/module-docu... .
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: ...ndor/drupal/pareviewsh/pareview_temp/src/Form/VadoManagementForm.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 7 WARNINGS AFFECTING 7 LINES
    --------------------------------------------------------------------------
      41 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
      50 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
      51 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
      59 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
      74 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
      75 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     114 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
    --------------------------------------------------------------------------
    
    Time: 658ms; Memory: 4Mb
    
This automated report was generated with PAReview.sh, your friendly project application review script.