https://git.drupal.org/project/content_access.git 8.x-1.x

Primary tabs

Git errors: Review of the 8.x-1.x branch (commit 0ee9336):
  • Your README.txt does not follow best practices (headings need to be uppercase). See https://www.drupal.org/node/2181737 .
    • The INTRODUCTION section is missing.
    • The REQUIREMENTS section is missing.
    • The INSTALLATION section is missing.
    • The CONFIGURATION section is missing.
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: ...1/web/vendor/drupal/pareviewsh/pareview_temp/content_access.info.yml
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     8 | WARNING | All dependencies must be prefixed with the project name,
       |         | for example "drupal:"
    --------------------------------------------------------------------------
    
    
    FILE: ...h/pareview_temp/src/Access/ContentAccessAdminSettingsAccessCheck.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     22 | WARNING | NodeType::load calls should be avoided in classes, use
        |         | dependency injection instead
    --------------------------------------------------------------------------
    
    
    FILE: .../pareviewsh/pareview_temp/src/Controller/ContentAccessController.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
    --------------------------------------------------------------------------
     17 | WARNING | \Drupal calls should be avoided in classes, use
        |         | dependency injection instead
     18 | WARNING | t() calls should be avoided in classes, use dependency
        |         | injection and $this->t() instead
    --------------------------------------------------------------------------
    
    
    FILE: ...r/drupal/pareviewsh/pareview_temp/src/Form/ContentAccessPageForm.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 17 WARNINGS AFFECTING 17 LINES
    --------------------------------------------------------------------------
      59 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
      63 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
      64 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
      76 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
      78 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
      88 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
      95 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     102 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     126 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
     130 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
     135 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
     136 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
     138 | WARNING | Unused variable $service_id.
     142 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     184 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
     186 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     205 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
    --------------------------------------------------------------------------
    
    
    FILE: ...pareviewsh/pareview_temp/src/Form/ContentAccessAdminSettingsForm.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 12 WARNINGS AFFECTING 11 LINES
    --------------------------------------------------------------------------
      73 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
      75 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
      76 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
      76 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
      81 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
      87 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
      93 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
      95 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
      99 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     162 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
     168 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     172 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
    --------------------------------------------------------------------------
    
    
    FILE: ...101/web/vendor/drupal/pareviewsh/pareview_temp/content_access.module
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
    --------------------------------------------------------------------------
      11 | WARNING | Global constants should not be used, move it to a class
         |         | or interface
     741 | WARNING | Unused variable $service_id.
    --------------------------------------------------------------------------
    
    Time: 2.84 secs; Memory: 8Mb
    
This automated report was generated with PAReview.sh, your friendly project application review script.

FILE: ...01/web/vendor/drupal/pareviewsh/pareview_temp/css/content_access.css
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 16 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...00000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/README.txt
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 24 WARNINGS AFFECTING 24 LINES
--------------------------------------------------------------------------
  6 | WARNING | Line exceeds 80 characters; contains 96 characters
  7 | WARNING | Line exceeds 80 characters; contains 95 characters
  8 | WARNING | Line exceeds 80 characters; contains 95 characters
 12 | WARNING | Line exceeds 80 characters; contains 100 characters
 13 | WARNING | Line exceeds 80 characters; contains 104 characters
 14 | WARNING | Line exceeds 80 characters; contains 84 characters
 15 | WARNING | Line exceeds 80 characters; contains 101 characters
 17 | WARNING | Line exceeds 80 characters; contains 97 characters
 19 | WARNING | Line exceeds 80 characters; contains 103 characters
 21 | WARNING | Line exceeds 80 characters; contains 103 characters
 23 | WARNING | Line exceeds 80 characters; contains 98 characters
 24 | WARNING | Line exceeds 80 characters; contains 103 characters
 28 | WARNING | Line exceeds 80 characters; contains 97 characters
 33 | WARNING | Line exceeds 80 characters; contains 96 characters
 35 | WARNING | Line exceeds 80 characters; contains 88 characters
 40 | WARNING | Line exceeds 80 characters; contains 97 characters
 41 | WARNING | Line exceeds 80 characters; contains 96 characters
 42 | WARNING | Line exceeds 80 characters; contains 101 characters
 48 | WARNING | Line exceeds 80 characters; contains 94 characters
 49 | WARNING | Line exceeds 80 characters; contains 94 characters
 51 | WARNING | Line exceeds 80 characters; contains 96 characters
 52 | WARNING | Line exceeds 80 characters; contains 96 characters
 62 | WARNING | Line exceeds 80 characters; contains 102 characters
 63 | WARNING | Line exceeds 80 characters; contains 100 characters
--------------------------------------------------------------------------


FILE: ...l/pareviewsh/pareview_temp/src/Tests/ContentAccessModuleTestCase.php
--------------------------------------------------------------------------
FOUND 7 ERRORS AFFECTING 7 LINES
--------------------------------------------------------------------------
  39 | ERROR | [x] Visibility must be declared on method "testViewAccess"
  98 | ERROR | [x] Inline comments must end in full-stops, exclamation
     |       |     marks, colons, question marks, or closing parentheses
 101 | ERROR | [x] Inline comments must end in full-stops, exclamation
     |       |     marks, colons, question marks, or closing parentheses
 124 | ERROR | [x] Visibility must be declared on method "testEditAccess"
 157 | ERROR | [x] Inline comments must end in full-stops, exclamation
     |       |     marks, colons, question marks, or closing parentheses
 205 | ERROR | [x] Visibility must be declared on method
     |       |     "testDeleteAccess"
 299 | ERROR | [x] Visibility must be declared on method
     |       |     "testOwnViewAccess"
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 7 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...upal/pareviewsh/pareview_temp/src/Tests/ContentAccessAclTestCase.php
--------------------------------------------------------------------------
FOUND 16 ERRORS AFFECTING 15 LINES
--------------------------------------------------------------------------
  26 | ERROR | [x] Visibility must be declared on method "setUp"
  41 | ERROR | [x] Visibility must be declared on method "testViewAccess"
  61 | ERROR | [x] Concat operator must be surrounded by a single space
  61 | ERROR | [x] Concat operator must be surrounded by a single space
  92 | ERROR | [x] Visibility must be declared on method "testEditAccess"
 106 | ERROR | [x] Concat operator must be surrounded by a single space
 111 | ERROR | [x] Concat operator must be surrounded by a single space
 116 | ERROR | [x] Concat operator must be surrounded by a single space
 125 | ERROR | [x] Concat operator must be surrounded by a single space
 130 | ERROR | [x] Concat operator must be surrounded by a single space
 137 | ERROR | [x] Visibility must be declared on method
     |       |     "testDeleteAccess"
 151 | ERROR | [x] Concat operator must be surrounded by a single space
 156 | ERROR | [x] Concat operator must be surrounded by a single space
 161 | ERROR | [x] Concat operator must be surrounded by a single space
 170 | ERROR | [x] Concat operator must be surrounded by a single space
 175 | ERROR | [x] Concat operator must be surrounded by a single space
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 16 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: .../drupal/pareviewsh/pareview_temp/src/Tests/ContentAccessTestHelp.php
--------------------------------------------------------------------------
FOUND 12 ERRORS AND 1 WARNING AFFECTING 13 LINES
--------------------------------------------------------------------------
  15 | ERROR   | [ ] Class property $test_user should use lowerCamel
     |         |     naming without underscores
  17 | ERROR   | [ ] Class property $admin_user should use lowerCamel
     |         |     naming without underscores
  18 | ERROR   | [ ] Class property $content_type should use lowerCamel
     |         |     naming without underscores
  19 | ERROR   | [ ] Class property $url_content_type_name should use
     |         |     lowerCamel naming without underscores
  32 | ERROR   | [ ] Doc comment short description must be on a single
     |         |     line, further text should be a separate paragraph
  57 | WARNING | [x] A comma should follow the last multiline array item.
     |         |     Found: 'access administration pages'
  71 | ERROR   | [x] Visibility must be declared on method
     |         |     "changeAccessContentType"
  85 | ERROR   | [ ] Doc comment short description must be on a single
     |         |     line, further text should be a separate paragraph
  87 | ERROR   | [x] Visibility must be declared on method
     |         |     "changeAccessContentTypeKeyword"
 112 | ERROR   | [x] Visibility must be declared on method
     |         |     "changeAccessPerNode"
 121 | ERROR   | [ ] Doc comment short description must be on a single
     |         |     line, further text should be a separate paragraph
 123 | ERROR   | [x] Visibility must be declared on method
     |         |     "changeAccessNodeKeyword"
 141 | ERROR   | [x] Visibility must be declared on method
     |         |     "changeAccessNode"
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...pareview_temp/src/Plugin/RulesAction/ActionRevokeNodePermissions.php
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 34 | ERROR | Missing short description in doc comment
--------------------------------------------------------------------------


FILE: ...pareviewsh/pareview_temp/src/Plugin/RulesAction/ActionUserRevoke.php
--------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------
 35 | ERROR | [x] Doc comment star missing
 36 | ERROR | [x] Additional blank lines found at end of doc comment
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: .../pareview_temp/src/Plugin/RulesAction/ActionGrantNodePermissions.php
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 34 | ERROR | Missing short description in doc comment
--------------------------------------------------------------------------


FILE: ...iew_temp/src/Plugin/RulesAction/ContentAccessUserRulesActionBase.php
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 23 | ERROR | Missing short description in doc comment
--------------------------------------------------------------------------


FILE: .../pareviewsh/pareview_temp/src/Plugin/RulesAction/ActionUserGrant.php
--------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------
 35 | ERROR | [x] Doc comment star missing
 36 | ERROR | [x] Additional blank lines found at end of doc comment
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...h/pareview_temp/src/Access/ContentAccessAdminSettingsAccessCheck.php
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 13 | ERROR | Doc comment short description must be on a single line,
    |       | further text should be a separate paragraph
--------------------------------------------------------------------------


FILE: ...viewsh/pareview_temp/src/Access/ContentAccessNodePageAccessCheck.php
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 12 | ERROR | Doc comment short description must be on a single line,
    |       | further text should be a separate paragraph
--------------------------------------------------------------------------


FILE: .../pareviewsh/pareview_temp/src/Controller/ContentAccessController.php
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
 6 | WARNING | [x] Unused use statement
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...r/drupal/pareviewsh/pareview_temp/src/Form/ContentAccessPageForm.php
--------------------------------------------------------------------------
FOUND 5 ERRORS AND 8 WARNINGS AFFECTING 11 LINES
--------------------------------------------------------------------------
  47 | WARNING | [ ] Line exceeds 80 characters; contains 94 characters
  52 | WARNING | [x] A comma should follow the last multiline array item.
     |         |     Found: 'content_access.admin'
 146 | WARNING | [ ] Line exceeds 80 characters; contains 92 characters
 146 | ERROR   | [x] Doc comment short description must end with a full
     |         |     stop
 160 | WARNING | [x] A comma should follow the last multiline array item.
     |         |     Found: )
 165 | WARNING | [ ] Line exceeds 80 characters; contains 83 characters
 165 | ERROR   | [x] Inline comments must end in full-stops, exclamation
     |         |     marks, colons, question marks, or closing
     |         |     parentheses
 169 | WARNING | [x] A comma should follow the last multiline array item.
     |         |     Found: )
 181 | ERROR   | [x] Visibility must be declared on method
     |         |     "pageResetSubmit"
 187 | ERROR   | [x] Expected 1 blank line after function; 2 found
 191 | WARNING | [ ] Line exceeds 80 characters; contains 97 characters
 193 | ERROR   | [x] Visibility must be declared on method
     |         |     "forcePermissions"
 205 | WARNING | [ ] Avoid backslash escaping in translatable strings
     |         |     when possible, use "" quotes instead
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 8 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...pareviewsh/pareview_temp/src/Form/ContentAccessAdminSettingsForm.php
--------------------------------------------------------------------------
FOUND 2 ERRORS AND 2 WARNINGS AFFECTING 4 LINES
--------------------------------------------------------------------------
  62 | ERROR   | [x] Inline comments must end in full-stops, exclamation
     |         |     marks, colons, question marks, or closing
     |         |     parentheses
 137 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters
 144 | ERROR   | [x] Inline comments must end in full-stops, exclamation
     |         |     marks, colons, question marks, or closing
     |         |     parentheses
 161 | WARNING | [ ] Line exceeds 80 characters; contains 107 characters
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...areviewsh/pareview_temp/src/Form/ContentAccessRoleBasedFormTrait.php
--------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------
 12 | ERROR | Parameter $form is not described in comment
 12 | ERROR | Parameter $type is not described in comment
 15 | ERROR | Missing parameter type
--------------------------------------------------------------------------


FILE: ...01/web/vendor/drupal/pareviewsh/pareview_temp/content_access.install
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
--------------------------------------------------------------------------
 46 | WARNING | [x] A comma should follow the last multiline array item.
    |         |     Found: 0
 51 | WARNING | [x] A comma should follow the last multiline array item.
    |         |     Found: 'medium'
 54 | WARNING | [x] A comma should follow the last multiline array item.
    |         |     Found: ]
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...101/web/vendor/drupal/pareviewsh/pareview_temp/content_access.module
--------------------------------------------------------------------------
FOUND 37 ERRORS AND 6 WARNINGS AFFECTING 36 LINES
--------------------------------------------------------------------------
  32 | ERROR   | [x] Equals sign not aligned with surrounding
     |         |     assignments; expected 1 space but found 2 spaces
 197 | ERROR   | [ ] Missing parameter type
 200 | ERROR   | [ ] Missing parameter type
 203 | ERROR   | [ ] Return type missing for @return tag in function
     |         |     comment
 291 | WARNING | [ ] Line exceeds 80 characters; contains 84 characters
 317 | ERROR   | [x] Inline comments must end in full-stops, exclamation
     |         |     marks, colons, question marks, or closing
     |         |     parentheses
 325 | WARNING | [ ] Line exceeds 80 characters; contains 84 characters
 325 | ERROR   | [x] Inline comments must end in full-stops, exclamation
     |         |     marks, colons, question marks, or closing
     |         |     parentheses
 343 | ERROR   | [ ] If the line declaring an array spans longer than 80
     |         |     characters, each element should be broken into its
     |         |     own line
 366 | WARNING | [ ] Line exceeds 80 characters; contains 87 characters
 368 | ERROR   | [ ] Missing parameter type
 370 | ERROR   | [ ] Missing parameter type
 372 | ERROR   | [x] Separate the @param and @return sections by a blank
     |         |     line.
 372 | ERROR   | [ ] Description for the @return value is missing
 388 | WARNING | [ ] Line exceeds 80 characters; contains 90 characters
 397 | ERROR   | [ ] Doc comment short description must be on a single
     |         |     line, further text should be a separate paragraph
 402 | ERROR   | [ ] Missing parameter type
 404 | ERROR   | [ ] Missing parameter type
 428 | ERROR   | [x] Expected 1 blank line after function; 2 found
 433 | ERROR   | [ ] Doc comment short description must be on a single
     |         |     line, further text should be a separate paragraph
 435 | ERROR   | [ ] Missing parameter type
 437 | ERROR   | [ ] Missing parameter type
 439 | ERROR   | [ ] Missing parameter type
 440 | ERROR   | [x] Parameter comment indentation must be 3 spaces,
     |         |     found 4 spaces
 441 | ERROR   | [x] Separate the @param and @return sections by a blank
     |         |     line.
 441 | ERROR   | [ ] Return type missing for @return tag in function
     |         |     comment
 457 | ERROR   | [x] Inline comments must end in full-stops, exclamation
     |         |     marks, colons, question marks, or closing
     |         |     parentheses
 506 | ERROR   | [x] Inline comments must end in full-stops, exclamation
     |         |     marks, colons, question marks, or closing
     |         |     parentheses
 511 | WARNING | [ ] Line exceeds 80 characters; contains 86 characters
 521 | ERROR   | [x] Inline comments must end in full-stops, exclamation
     |         |     marks, colons, question marks, or closing
     |         |     parentheses
 548 | ERROR   | [x] Inline comments must end in full-stops, exclamation
     |         |     marks, colons, question marks, or closing
     |         |     parentheses
 553 | ERROR   | [x] No space found before comment text; expected "//
     |         |     grant view access to all instead of single roles"
     |         |     but found "//grant view access to all instead of
     |         |     single roles"
 553 | ERROR   | [x] Inline comments must start with a capital letter
 553 | ERROR   | [x] Inline comments must end in full-stops, exclamation
     |         |     marks, colons, question marks, or closing
     |         |     parentheses
 580 | ERROR   | [x] No space found before comment text; expected "//
     |         |     it's still here, so we can't remove this grant." but
     |         |     found "//it's still here, so we can't remove this
     |         |     grant."
 651 | WARNING | [x] A comma should follow the last multiline array item.
     |         |     Found: 'content_access.admin'
 682 | ERROR   | [x] Doc comment short description must end with a full
     |         |     stop
 718 | ERROR   | [x] There must be exactly one blank line before the tags
     |         |     in a doc comment
 718 | ERROR   | [ ] Missing parameter type
 720 | ERROR   | [x] Separate the @param and @return sections by a blank
     |         |     line.
 720 | ERROR   | [ ] Return type missing for @return tag in function
     |         |     comment
 755 | ERROR   | [ ] Doc comment short description must be on a single
     |         |     line, further text should be a separate paragraph
 766 | ERROR   | [x] Inline comments must start with a capital letter
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 20 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Time: 3.45 secs; Memory: 10Mb