Revision of https://git.drupal.org/project/content_feedback.git 8.x-1.x from Sun, 04/14/2019 - 18:52

Revisions allow you to track differences between multiple versions of your content, and revert back to older versions.

Review of the 8.x-1.x branch (commit 473f46c):
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: .../pareviewsh/pareview_temp/src/Controller/AdminFeedbackController.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     47 | WARNING | Unused variable $id.
    --------------------------------------------------------------------------
    
    Time: 962ms; Memory: 4Mb
    
  • No automated test cases were found, did you consider writing PHPUnit tests? This is not a requirement but encouraged for professional software development.
This automated report was generated with PAReview.sh, your friendly project application review script.

FILE: .../pareviewsh/pareview_temp/src/Controller/AdminFeedbackController.php
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
--------------------------------------------------------------------------
 80 | WARNING | [x] A comma should follow the last multiline array item.
    |         |     Found: ''
 95 | WARNING | [x] A comma should follow the last multiline array item.
    |         |     Found: 'pager'
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...ndor/drupal/pareviewsh/pareview_temp/src/Form/AddContentFeedback.php
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 105 | ERROR | [x] Expected 1 space after "=>"; 2 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...or/drupal/pareviewsh/pareview_temp/src/Form/ContentFeedbackClass.php
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 56 | ERROR | Type hint "array" missing for $header
--------------------------------------------------------------------------

Time: 1.82 secs; Memory: 6Mb