Revision of https://git.drupal.org/project/copyscape.git 8.x-1.x from Tue, 05/14/2019 - 18:14

Revisions allow you to track differences between multiple versions of your content, and revert back to older versions.

Git errors: Review of the 8.x-1.x branch (commit a5bfa2c):
  • Remove LICENSE.txt, it will be added by drupal.org packaging automatically.
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: ...web/vendor/drupal/pareviewsh/pareview_temp/src/Copyscape/Utility.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     273 | WARNING | Unused variable $storage.
    --------------------------------------------------------------------------
    
    
    FILE: ...drupal/pareviewsh/pareview_temp/src/Controller/ResultsController.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     104 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
    --------------------------------------------------------------------------
    
    Time: 1.29 secs; Memory: 4Mb
    
  • No automated test cases were found, did you consider writing PHPUnit tests? This is not a requirement but encouraged for professional software development.
This automated report was generated with PAReview.sh, your friendly project application review script.

FILE: ...pal/pareviewsh/pareview_temp/src/Entity/CopyscapeResultInterface.php
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 23 | ERROR | [x] Expected 1 blank line before function; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...101/web/vendor/drupal/pareviewsh/pareview_temp/src/Copyscape/Api.php
--------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------
 112 | ERROR | Type hint "array" missing for $params
 112 | ERROR | Type hint "array" missing for $xmlSpec
 112 | ERROR | Type hint "array" missing for $postData
 161 | ERROR | Type hint "array" missing for $spec
--------------------------------------------------------------------------


FILE: ...web/vendor/drupal/pareviewsh/pareview_temp/src/Copyscape/Utility.php
--------------------------------------------------------------------------
FOUND 4 ERRORS AND 1 WARNING AFFECTING 5 LINES
--------------------------------------------------------------------------
  39 | ERROR   | [ ] Missing parameter comment
 207 | ERROR   | [ ] Description for the @return value is missing
 254 | WARNING | [x] A comma should follow the last multiline array item.
     |         |     Found: $count
 264 | ERROR   | [x] Expected 1 blank line after function; 2 found
 311 | ERROR   | [ ] Type hint "array" missing for $results
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...drupal/pareviewsh/pareview_temp/src/Controller/ResultsController.php
--------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------
  32 | ERROR | [ ] Parameter $entity_type_manager is not described in
     |       |     comment
  35 | ERROR | [ ] Doc comment for parameter $entityTypeManager does not
     |       |     match actual variable name $dateFormatter
 161 | ERROR | [x] Array closing indentation error, expected 10 spaces
     |       |     but found 12
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...or/drupal/pareviewsh/pareview_temp/src/Form/CopyscapeContentForm.php
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 16 | ERROR | Missing short description in doc comment
--------------------------------------------------------------------------

Time: 2.21 secs; Memory: 6Mb