https://git.drupal.org/project/customfilter.git 8.x-1.x

Primary tabs

Git errors: Review of the 8.x-1.x branch (commit 29df5be):
  • Your README.txt does not follow best practices (headings need to be uppercase). See https://www.drupal.org/node/2181737 .
    • The INTRODUCTION section is missing.
    • The REQUIREMENTS section is missing.
    • The CONFIGURATION section is missing.
  • The customfilter.module does not implement hook_help(). See https://www.drupal.org/docs/develop/documenting-your-project/module-docu... .
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: ...areviewsh/pareview_temp/src/Plugin/Filter/CustomFilterBaseFilter.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 2 LINES
    --------------------------------------------------------------------------
     171 | WARNING | Unused variable $vars.
     175 | WARNING | Variable $result is undefined.
     175 | WARNING | Variable $result is undefined.
    --------------------------------------------------------------------------
    
    
    FILE: ...vendor/drupal/pareviewsh/pareview_temp/src/Form/CustomFilterForm.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     107 | WARNING | drupal_get_destination() calls should be avoided in
         |         | classes, use dependency injection and the
         |         | "redirect.destination" service instead
    --------------------------------------------------------------------------
    
    Time: 1.18 secs; Memory: 4Mb
    
This automated report was generated with PAReview.sh, your friendly project application review script.

FILE: ...00000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/README.txt
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
--------------------------------------------------------------------------
 18 | WARNING | Line exceeds 80 characters; contains 84 characters
 32 | WARNING | Line exceeds 80 characters; contains 82 characters
--------------------------------------------------------------------------


FILE: .../web/vendor/drupal/pareviewsh/pareview_temp/customfilter.routing.yml
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 85 | ERROR | [x] Expected 1 newline at end of file; 2 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...b/vendor/drupal/pareviewsh/pareview_temp/src/Entity/CustomFilter.php
--------------------------------------------------------------------------
FOUND 12 ERRORS AND 1 WARNING AFFECTING 13 LINES
--------------------------------------------------------------------------
  10 | WARNING | [x] Unused use statement
 106 | ERROR   | [x] Short array syntax must be used to define arrays
 144 | ERROR   | [x] Expected "bool" but found "Bool" for function return
     |         |     type
 171 | ERROR   | [x] Short array syntax must be used to define arrays
 202 | ERROR   | [x] Short array syntax must be used to define arrays
 206 | ERROR   | [ ] Parameter $sort is not described in comment
 218 | ERROR   | [x] Short array syntax must be used to define arrays
 221 | ERROR   | [x] Short array syntax must be used to define arrays
 269 | ERROR   | [x] Short array syntax must be used to define arrays
 288 | ERROR   | [x] Short array syntax must be used to define arrays
 289 | ERROR   | [x] Closing parenthesis of array declaration must be on
     |         |     a new line
 296 | ERROR   | [x] Expected 1 blank line after function; 0 found
 297 | ERROR   | [x] The closing brace for the class must have an empty
     |         |     line before it
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 12 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...ndor/drupal/pareviewsh/pareview_temp/src/CustomFilterListBuilder.php
--------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------
 31 | ERROR | [x] Short array syntax must be used to define arrays
 35 | ERROR | [x] Expected 1 blank line after function; 0 found
 36 | ERROR | [x] The closing brace for the class must have an empty line
    |       |     before it
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...endor/drupal/pareviewsh/pareview_temp/src/Tests/CustomFilterTest.php
--------------------------------------------------------------------------
FOUND 22 ERRORS AFFECTING 20 LINES
--------------------------------------------------------------------------
   3 | ERROR | [x] Namespaced classes, interfaces and traits should not
     |       |     begin with a file doc comment
  16 | ERROR | [x] You must use "/**" style comments for a member
     |       |     variable comment
  19 | ERROR | [x] You must use "/**" style comments for a member
     |       |     variable comment
  19 | ERROR | [x] Short array syntax must be used to define arrays
  19 | ERROR | [x] Expected one space after the comma, 0 found
  28 | ERROR | [x] Short array syntax must be used to define arrays
  37 | ERROR | [x] Short array syntax must be used to define arrays
  50 | ERROR | [x] Short array syntax must be used to define arrays
  66 | ERROR | [x] Short array syntax must be used to define arrays
  82 | ERROR | [x] Short array syntax must be used to define arrays
 104 | ERROR | [x] Short array syntax must be used to define arrays
 112 | ERROR | [x] Short array syntax must be used to define arrays
 120 | ERROR | [x] Short array syntax must be used to define arrays
 128 | ERROR | [x] Short array syntax must be used to define arrays
 136 | ERROR | [x] Short array syntax must be used to define arrays
 157 | ERROR | [x] Short array syntax must be used to define arrays
 196 | ERROR | [x] Short array syntax must be used to define arrays
 199 | ERROR | [x] Short array syntax must be used to define arrays
 201 | ERROR | [x] Short array syntax must be used to define arrays
 202 | ERROR | [x] Short array syntax must be used to define arrays
 242 | ERROR | [x] Expected 1 blank line after function; 0 found
 243 | ERROR | [x] The closing brace for the class must have an empty
     |       |     line before it
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 22 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...areviewsh/pareview_temp/src/Plugin/Filter/CustomFilterBaseFilter.php
--------------------------------------------------------------------------
FOUND 6 ERRORS AND 1 WARNING AFFECTING 7 LINES
--------------------------------------------------------------------------
  41 | ERROR   | [x] Short array syntax must be used to define arrays
  57 | ERROR   | [x] Short array syntax must be used to define arrays
 119 | ERROR   | [x] Short array syntax must be used to define arrays
 120 | ERROR   | [x] Short array syntax must be used to define arrays
 135 | ERROR   | [x] Short array syntax must be used to define arrays
 173 | WARNING | [ ] The use of function eval() is discouraged
 201 | ERROR   | [x] Short array syntax must be used to define arrays
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...vendor/drupal/pareviewsh/pareview_temp/src/Form/RulesAddEditForm.php
--------------------------------------------------------------------------
FOUND 25 ERRORS AFFECTING 25 LINES
--------------------------------------------------------------------------
   3 | ERROR | [x] Namespaced classes, interfaces and traits should not
     |       |     begin with a file doc comment
  22 | ERROR | [x] Whitespace found at end of line
  24 | ERROR | [x] Whitespace found at end of line
  28 | ERROR | [x] Do not append variable name "$entity" to the type
     |       |     declaration in a member variable comment
  35 | ERROR | [ ] Public method name "RulesAddEditForm::getFormID" is
     |       |     not in lowerCamel format
  44 | ERROR | [x] Short array syntax must be used to define arrays
  45 | ERROR | [x] Short array syntax must be used to define arrays
  50 | ERROR | [x] Short array syntax must be used to define arrays
  66 | ERROR | [x] Short array syntax must be used to define arrays
  74 | ERROR | [x] Short array syntax must be used to define arrays
  80 | ERROR | [x] Short array syntax must be used to define arrays
  88 | ERROR | [x] Short array syntax must be used to define arrays
  93 | ERROR | [x] Short array syntax must be used to define arrays
  98 | ERROR | [x] Short array syntax must be used to define arrays
 104 | ERROR | [x] Short array syntax must be used to define arrays
 113 | ERROR | [x] Short array syntax must be used to define arrays
 119 | ERROR | [x] Short array syntax must be used to define arrays
 124 | ERROR | [x] Short array syntax must be used to define arrays
 131 | ERROR | [x] Short array syntax must be used to define arrays
 138 | ERROR | [x] Short array syntax must be used to define arrays
 146 | ERROR | [x] Short array syntax must be used to define arrays
 153 | ERROR | [x] Short array syntax must be used to define arrays
 161 | ERROR | [x] Short array syntax must be used to define arrays
 179 | ERROR | [x] Short array syntax must be used to define arrays
 203 | ERROR | [x] Short array syntax must be used to define arrays
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 24 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...01/web/vendor/drupal/pareviewsh/pareview_temp/src/Form/RulesForm.php
--------------------------------------------------------------------------
FOUND 10 ERRORS AFFECTING 8 LINES
--------------------------------------------------------------------------
   3 | ERROR | [x] Namespaced classes, interfaces and traits should not
     |       |     begin with a file doc comment
  24 | ERROR | [x] Missing class doc comment
  25 | ERROR | [x] Whitespace found at end of line
  28 | ERROR | [x] The open comment tag must be the only content on the
     |       |     line
  28 | ERROR | [ ] Missing short description in doc comment
  28 | ERROR | [x] Expected "\Drupal\customfilter\Entity\CustomFilter"
     |       |     but found "\Drupal\customfilter\Entity\CustomFilter "
     |       |     for @var tag in member variable comment
  34 | ERROR | [ ] Public method name "RulesForm::getFormID" is not in
     |       |     lowerCamel format
  61 | ERROR | [x] Array indentation error, expected 6 spaces but found 8
  62 | ERROR | [x] Array indentation error, expected 10 spaces but found
     |       |     8
 106 | ERROR | [x] Short array syntax must be used to define arrays
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 8 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...al/pareviewsh/pareview_temp/src/Form/CustomFilterRulesDeleteForm.php
--------------------------------------------------------------------------
FOUND 9 ERRORS AFFECTING 9 LINES
--------------------------------------------------------------------------
 30 | ERROR | [ ] Missing @var tag in member variable comment
 46 | ERROR | [x] Short array syntax must be used to define arrays
 53 | ERROR | [x] Short array syntax must be used to define arrays
 68 | ERROR | [x] Short array syntax must be used to define arrays
 69 | ERROR | [x] Expected 1 blank line after function; 0 found
 92 | ERROR | [x] Short array syntax must be used to define arrays
 93 | ERROR | [x] Short array syntax must be used to define arrays
 94 | ERROR | [x] Expected 1 blank line after function; 0 found
 95 | ERROR | [x] The closing brace for the class must have an empty line
    |       |     before it
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 8 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: .../drupal/pareviewsh/pareview_temp/src/Form/CustomFilterDeleteForm.php
--------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------
 23 | ERROR | [x] Short array syntax must be used to define arrays
 45 | ERROR | [x] Short array syntax must be used to define arrays
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...vendor/drupal/pareviewsh/pareview_temp/src/Form/CustomFilterForm.php
--------------------------------------------------------------------------
FOUND 16 ERRORS AFFECTING 15 LINES
--------------------------------------------------------------------------
  12 | ERROR | [x] Missing class doc comment
  22 | ERROR | [x] Short array syntax must be used to define arrays
  30 | ERROR | [x] Short array syntax must be used to define arrays
  36 | ERROR | [x] Short array syntax must be used to define arrays
  44 | ERROR | [x] Short array syntax must be used to define arrays
  51 | ERROR | [x] Short array syntax must be used to define arrays
  58 | ERROR | [x] Short array syntax must be used to define arrays
  66 | ERROR | [x] Short array syntax must be used to define arrays
  73 | ERROR | [x] Short array syntax must be used to define arrays
  88 | ERROR | [x] Short array syntax must be used to define arrays
  89 | ERROR | [x] Array indentation error, expected 8 spaces but found
     |       |     10
  93 | ERROR | [x] Short array syntax must be used to define arrays
  94 | ERROR | [x] Array indentation error, expected 8 spaces but found
     |       |     10
 104 | ERROR | [x] Short array syntax must be used to define arrays
 110 | ERROR | [x] Short array syntax must be used to define arrays
 110 | ERROR | [x] Short array syntax must be used to define arrays
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 16 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...b/vendor/drupal/pareviewsh/pareview_temp/customfilter.links.menu.yml
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 5 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: .../vendor/drupal/pareviewsh/pareview_temp/customfilter.permissions.yml
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 4 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...vendor/drupal/pareviewsh/pareview_temp/customfilter.links.action.yml
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 11 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...e1101/web/vendor/drupal/pareviewsh/pareview_temp/customfilter.module
--------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------
  1 | ERROR | [x] The PHP open tag must be followed by exactly one blank
    |       |     line
 23 | ERROR | [x] Short array syntax must be used to define arrays
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Time: 2.13 secs; Memory: 6Mb