https://git.drupal.org/project/data_fixtures.git

Primary tabs

Git errors: Review of the 8.x-1.x branch (commit 6316ff6):
  • Your README.md does not follow best practices (headings need to be uppercase). See https://www.drupal.org/node/2181737 .
    • The INTRODUCTION section is missing.
    • The REQUIREMENTS section is missing.
    • The INSTALLATION section is missing.
    • The CONFIGURATION section is missing.
  • Remove the LICENSE, drupal.org packaging will add a LICENSE.txt file automatically.
  • The data_fixtures.module does not implement hook_help(). See https://www.drupal.org/docs/develop/documenting-your-project/module-docu... .
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: ...ndor/drupal/pareviewsh/pareview_temp/src/Services/DummyGenerator.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     147 | WARNING | Unused private method getRandom()
    --------------------------------------------------------------------------
    
    Time: 913ms; Memory: 4Mb
    
  • No automated test cases were found, did you consider writing PHPUnit tests? This is not a requirement but encouraged for professional software development.
This automated report was generated with PAReview.sh, your friendly project application review script.

FILE: ...000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/README.md
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 14 WARNINGS AFFECTING 14 LINES
--------------------------------------------------------------------------
 19 | WARNING | Line exceeds 80 characters; contains 158 characters
 21 | WARNING | Line exceeds 80 characters; contains 204 characters
 25 | WARNING | Line exceeds 80 characters; contains 174 characters
 26 | WARNING | Line exceeds 80 characters; contains 107 characters
 28 | WARNING | Line exceeds 80 characters; contains 132 characters
 29 | WARNING | Line exceeds 80 characters; contains 133 characters
 31 | WARNING | Line exceeds 80 characters; contains 123 characters
 32 | WARNING | Line exceeds 80 characters; contains 135 characters
 33 | WARNING | Line exceeds 80 characters; contains 110 characters
 36 | WARNING | Line exceeds 80 characters; contains 112 characters
 37 | WARNING | Line exceeds 80 characters; contains 99 characters
 41 | WARNING | Line exceeds 80 characters; contains 97 characters
 44 | WARNING | Line exceeds 80 characters; contains 89 characters
 53 | WARNING | Line exceeds 80 characters; contains 81 characters
--------------------------------------------------------------------------


FILE: ...1/web/vendor/drupal/pareviewsh/pareview_temp/data_fixtures.drush.inc
--------------------------------------------------------------------------
FOUND 18 ERRORS AFFECTING 16 LINES
--------------------------------------------------------------------------
   4 | ERROR | [x] Doc comment short description must be on the first
     |       |     line
   4 | ERROR | [x] Doc comment short description must end with a full
     |       |     stop
  21 | ERROR | [x] Short array syntax must be used to define arrays
  60 | ERROR | [x] Doc comment short description must end with a full
     |       |     stop
  70 | ERROR | [x] Doc comment short description must end with a full
     |       |     stop
  72 | ERROR | [ ] Missing parameter comment
  82 | ERROR | [x] Doc comment short description must end with a full
     |       |     stop
  84 | ERROR | [ ] Missing parameter comment
  87 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected
     |       |     "TRUE" but found "true"
  94 | ERROR | [x] Doc comment short description must end with a full
     |       |     stop
  96 | ERROR | [ ] Missing parameter comment
 103 | ERROR | [ ] Missing short description in doc comment
 104 | ERROR | [ ] Missing parameter comment
 104 | ERROR | [ ] Missing parameter type
 105 | ERROR | [ ] Missing parameter comment
 107 | ERROR | [ ] Description for the @return value is missing
 109 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected
     |       |     "FALSE" but found "false"
 119 | ERROR | [x] Namespaced classes/interfaces/traits should be
     |       |     referenced with use statements
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 10 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...rupal/pareviewsh/pareview_temp/src/Commands/DataFixturesCommands.php
--------------------------------------------------------------------------
FOUND 29 ERRORS AND 2 WARNINGS AFFECTING 28 LINES
--------------------------------------------------------------------------
   3 | ERROR   | [x] Namespaced classes, interfaces and traits should not
     |         |     begin with a file doc comment
   4 | ERROR   | [x] Doc comment short description must be on the first
     |         |     line
   4 | ERROR   | [x] Doc comment short description must end with a full
     |         |     stop
   6 | ERROR   | [x] Additional blank lines found at end of doc comment
  14 | ERROR   | [x] Function comment short description must start with
     |         |     exactly one space
  18 | ERROR   | [ ] Missing short description in doc comment
  26 | ERROR   | [ ] Missing parameter comment
  29 | ERROR   | [x] Opening brace should be on the same line as the
     |         |     declaration
  34 | ERROR   | [x] Doc comment short description must end with a full
     |         |     stop
  41 | ERROR   | [x] Additional blank lines found at end of doc comment
  50 | ERROR   | [x] Doc comment short description must end with a full
     |         |     stop
  52 | ERROR   | [ ] Missing parameter type
  60 | ERROR   | [x] Additional blank lines found at end of doc comment
  71 | ERROR   | [ ] Missing parameter type
  72 | WARNING | [ ] Line exceeds 80 characters; contains 83 characters
  79 | ERROR   | [x] Additional blank lines found at end of doc comment
  81 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected
     |         |     "TRUE" but found "true"
  88 | ERROR   | [x] Doc comment short description must end with a full
     |         |     stop
  90 | ERROR   | [ ] Missing parameter type
  91 | WARNING | [ ] Line exceeds 80 characters; contains 83 characters
  98 | ERROR   | [x] Additional blank lines found at end of doc comment
 104 | ERROR   | [ ] Missing short description in doc comment
 105 | ERROR   | [ ] Missing parameter comment
 105 | ERROR   | [ ] Missing parameter type
 106 | ERROR   | [ ] Missing parameter comment
 108 | ERROR   | [ ] Description for the @return value is missing
 110 | ERROR   | [ ] Private method name
     |         |     "DataFixturesCommands::data_fixtures_get_fixtures"
     |         |     is not in lowerCamel format
 110 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected
     |         |     "FALSE" but found "false"
 117 | ERROR   | [x] Namespaced classes/interfaces/traits should be
     |         |     referenced with use statements
 121 | ERROR   | [x] Expected 1 blank line after function; 0 found
 122 | ERROR   | [x] The closing brace for the class must have an empty
     |         |     line before it
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 18 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...ndor/drupal/pareviewsh/pareview_temp/src/Services/DummyGenerator.php
--------------------------------------------------------------------------
FOUND 58 ERRORS AFFECTING 41 LINES
--------------------------------------------------------------------------
   6 | ERROR | [x] Doc comment short description must end with a full
     |       |     stop
  14 | ERROR | [ ] Missing short description in doc comment
  27 | ERROR | [ ] Missing short description in doc comment
  47 | ERROR | [ ] Missing short description in doc comment
  51 | ERROR | [x] Comments may not appear after statements
  52 | ERROR | [x] Comments may not appear after statements
  53 | ERROR | [x] Comments may not appear after statements
  54 | ERROR | [x] Comments may not appear after statements
  55 | ERROR | [x] Comments may not appear after statements
  56 | ERROR | [x] Comments may not appear after statements
  57 | ERROR | [x] Comments may not appear after statements
  58 | ERROR | [x] Comments may not appear after statements
  59 | ERROR | [x] Comments may not appear after statements
  60 | ERROR | [x] Comments may not appear after statements
  61 | ERROR | [x] Comments may not appear after statements
  62 | ERROR | [x] Comments may not appear after statements
  62 | ERROR | [x] Inline comments must end in full-stops, exclamation
     |       |     marks, colons, question marks, or closing parentheses
  65 | ERROR | [ ] Missing short description in doc comment
  72 | ERROR | [ ] Doc comment short description must be on a single
     |       |     line, further text should be a separate paragraph
  74 | ERROR | [ ] Missing parameter comment
  76 | ERROR | [ ] Description for the @return value is missing
  87 | ERROR | [x] Expected 1 space before "-"; 0 found
  87 | ERROR | [x] Expected 1 space after "-"; 0 found
  92 | ERROR | [x] There must be exactly one blank line before the tags
     |       |     in a doc comment
  92 | ERROR | [x] Parameter comment must be on the next line
  92 | ERROR | [x] Parameter comment must end with a full stop
  93 | ERROR | [x] Separate the @param and @return sections by a blank
     |       |     line.
  93 | ERROR | [ ] Description for the @return value is missing
  95 | ERROR | [x] Incorrect spacing between argument "$maxLength" and
     |       |     equals sign; expected 1 but found 0
  95 | ERROR | [x] Incorrect spacing between default value and equals
     |       |     sign for argument "$maxLength"; expected 1 but found 0
  99 | ERROR | [ ] Missing short description in doc comment
 101 | ERROR | [x] Parameter comment indentation must be 3 spaces, found
     |       |     1 spaces
 102 | ERROR | [ ] Description for the @return value is missing
 104 | ERROR | [x] Incorrect spacing between argument "$type" and equals
     |       |     sign; expected 1 but found 0
 104 | ERROR | [x] Incorrect spacing between default value and equals
     |       |     sign for argument "$type"; expected 1 but found 0
 110 | ERROR | [x] There must be exactly one blank line before the tags
     |       |     in a doc comment
 110 | ERROR | [ ] Description for the @return value is missing
 113 | ERROR | [x] Space before opening parenthesis of function call
     |       |     prohibited
 121 | ERROR | [x] There must be exactly one blank line before the tags
     |       |     in a doc comment
 121 | ERROR | [ ] Description for the @return value is missing
 129 | ERROR | [x] There must be exactly one blank line before the tags
     |       |     in a doc comment
 129 | ERROR | [ ] Description for the @return value is missing
 136 | ERROR | [ ] Missing short description in doc comment
 137 | ERROR | [ ] Description for the @return value is missing
 145 | ERROR | [x] There must be exactly one blank line before the tags
     |       |     in a doc comment
 145 | ERROR | [x] Expected "int" but found "integer" for function return
     |       |     type
 145 | ERROR | [ ] Description for the @return value is missing
 152 | ERROR | [x] Doc comment short description must end with a full
     |       |     stop
 153 | ERROR | [x] There must be exactly one blank line before the tags
     |       |     in a doc comment
 153 | ERROR | [ ] Missing parameter comment
 154 | ERROR | [x] Separate the @param and @return sections by a blank
     |       |     line.
 154 | ERROR | [x] Expected "int" but found "integer" for function return
     |       |     type
 154 | ERROR | [ ] Description for the @return value is missing
 156 | ERROR | [ ] Expected type hint "array"; found "Array" for $arr
 156 | ERROR | [x] PHP keywords must be lowercase; expected "array" but
     |       |     found "Array"
 158 | ERROR | [x] Expected 1 blank line after function; 0 found
 159 | ERROR | [x] Expected 1 newline at end of file; 2 found
 159 | ERROR | [x] The closing brace for the class must have an empty
     |       |     line before it
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 39 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: .../vendor/drupal/pareviewsh/pareview_temp/src/Interfaces/Generator.php
--------------------------------------------------------------------------
FOUND 7 ERRORS AND 1 WARNING AFFECTING 8 LINES
--------------------------------------------------------------------------
  6 | ERROR   | [x] Doc comment short description must end with a full
    |         |     stop
  7 | ERROR   | [x] There must be exactly one blank line before the tags
    |         |     in a doc comment
  9 | WARNING | [ ] Interface names should always have the suffix
    |         |     "Interface"
 11 | ERROR   | [x] Doc comment short description must end with a full
    |         |     stop
 13 | ERROR   | [x] Expected 1 blank line before function; 0 found
 16 | ERROR   | [x] Doc comment short description must end with a full
    |         |     stop
 18 | ERROR   | [x] Expected 1 blank line after function; 0 found
 19 | ERROR   | [x] The closing brace for the interface must have an
    |         |     empty line before it
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 7 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...web/vendor/drupal/pareviewsh/pareview_temp/src/AbstractGenerator.php
--------------------------------------------------------------------------
FOUND 24 ERRORS AND 1 WARNING AFFECTING 22 LINES
--------------------------------------------------------------------------
   8 | ERROR   | [x] Doc comment short description must end with a full
     |         |     stop
  14 | ERROR   | [ ] Missing short description in doc comment
  23 | ERROR   | [x] Namespaced classes/interfaces/traits should be
     |         |     referenced with use statements
  27 | ERROR   | [x] Doc comment short description must end with a full
     |         |     stop
  29 | ERROR   | [ ] Missing parameter comment
  29 | ERROR   | [ ] Missing parameter name
  30 | ERROR   | [ ] Missing parameter comment
  30 | ERROR   | [ ] Missing parameter name
  32 | ERROR   | [ ] Description for the @return value must be on the
     |         |     next line
  42 | ERROR   | [x] Doc comment short description must end with a full
     |         |     stop
  44 | ERROR   | [ ] Missing parameter comment
  45 | ERROR   | [ ] Missing parameter comment
  47 | ERROR   | [ ] Description for the @return value is missing
  57 | ERROR   | [x] Doc comment short description must end with a full
     |         |     stop
  66 | ERROR   | [ ] Description for the @return value is missing
  67 | ERROR   | [x] Separate the @return and @throws sections by a blank
     |         |     line.
  74 | WARNING | [ ] Line exceeds 80 characters; contains 93 characters
  74 | ERROR   | [x] Inline comments must end in full-stops, exclamation
     |         |     marks, colons, question marks, or closing
     |         |     parentheses
 100 | ERROR   | [x] Doc comment short description must end with a full
     |         |     stop
 103 | ERROR   | [x] Parameter comment must end with a full stop
 105 | ERROR   | [ ] Description for the @return value is missing
 123 | ERROR   | [x] Inline comments must end in full-stops, exclamation
     |         |     marks, colons, question marks, or closing
     |         |     parentheses
 143 | ERROR   | [ ] Missing short description in doc comment
 166 | ERROR   | [x] Expected 1 blank line after function; 0 found
 167 | ERROR   | [x] The closing brace for the class must have an empty
     |         |     line before it
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 12 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...web/vendor/drupal/pareviewsh/pareview_temp/src/FixturesGenerator.php
--------------------------------------------------------------------------
FOUND 19 ERRORS AFFECTING 16 LINES
--------------------------------------------------------------------------
 26 | ERROR | [x] Missing function doc comment
 26 | ERROR | [x] Incorrect spacing between argument "$alias" and equals
    |       |     sign; expected 1 but found 0
 26 | ERROR | [x] Incorrect spacing between default value and equals sign
    |       |     for argument "$alias"; expected 1 but found 0
 26 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL"
    |       |     but found "null"
 31 | ERROR | [ ] Missing short description in doc comment
 32 | ERROR | [ ] Description for the @return value is missing
 38 | ERROR | [ ] Missing short description in doc comment
 39 | ERROR | [ ] Description for the @return value is missing
 45 | ERROR | [ ] Missing short description in doc comment
 46 | ERROR | [ ] Description for the @return value is missing
 52 | ERROR | [ ] Missing short description in doc comment
 53 | ERROR | [ ] Missing parameter comment
 63 | ERROR | [ ] Missing short description in doc comment
 64 | ERROR | [ ] Description for the @return value is missing
 70 | ERROR | [ ] Missing short description in doc comment
 71 | ERROR | [ ] Missing parameter comment
 73 | ERROR | [ ] Type hint "\Drupal\data_fixtures\Interfaces\Generator"
    |       |     missing for $generator
 75 | ERROR | [x] Expected 1 blank line after function; 0 found
 76 | ERROR | [x] The closing brace for the class must have an empty line
    |       |     before it
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...1/web/vendor/drupal/pareviewsh/pareview_temp/src/FixturesManager.php
--------------------------------------------------------------------------
FOUND 28 ERRORS AFFECTING 19 LINES
--------------------------------------------------------------------------
   8 | ERROR | [x] Doc comment short description must end with a full
     |       |     stop
  36 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected
     |       |     "NULL" but found "null"
  38 | ERROR | [ ] Missing short description in doc comment
  39 | ERROR | [ ] Missing parameter comment
  40 | ERROR | [ ] Missing parameter comment
  41 | ERROR | [ ] Missing parameter comment
  45 | ERROR | [x] Incorrect spacing between argument "$priority" and
     |       |     equals sign; expected 1 but found 0
  45 | ERROR | [x] Incorrect spacing between default value and equals
     |       |     sign for argument "$priority"; expected 1 but found 0
  45 | ERROR | [x] Incorrect spacing between argument "$alias" and equals
     |       |     sign; expected 1 but found 0
  45 | ERROR | [x] Incorrect spacing between default value and equals
     |       |     sign for argument "$alias"; expected 1 but found 0
  45 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected
     |       |     "NULL" but found "null"
  47 | ERROR | [x] Inline comments must start with a capital letter
  47 | ERROR | [x] Inline comments must end in full-stops, exclamation
     |       |     marks, colons, question marks, or closing parentheses
  48 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected
     |       |     "NULL" but found "null"
  52 | ERROR | [ ] Missing short description in doc comment
  54 | ERROR | [x] Parameter comment indentation must be 3 spaces, found
     |       |     2 spaces
  54 | ERROR | [ ] Parameter comment must start with a capital letter
  54 | ERROR | [x] Parameter comment must end with a full stop
  55 | ERROR | [ ] Description for the @return value is missing
  57 | ERROR | [x] Incorrect spacing between argument "$reverse" and
     |       |     equals sign; expected 1 but found 0
  57 | ERROR | [x] Incorrect spacing between default value and equals
     |       |     sign for argument "$reverse"; expected 1 but found 0
  57 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected
     |       |     "FALSE" but found "false"
  58 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected
     |       |     "NULL" but found "null"
  70 | ERROR | [x] Doc comment short description must end with a full
     |       |     stop
  79 | ERROR | [x] Doc comment short description must end with a full
     |       |     stop
  94 | ERROR | [x] Short array syntax must be used to define arrays
 101 | ERROR | [x] Expected 1 blank line after function; 0 found
 102 | ERROR | [x] The closing brace for the class must have an empty
     |       |     line before it
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 21 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...1101/web/vendor/drupal/pareviewsh/pareview_temp/data_fixtures.module
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 1 | ERROR | [x] Missing file doc comment
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Time: 1.65 secs; Memory: 4Mb