https://git.drupal.org/project/dialogs

Primary tabs

Review of the 8.x-1.x branch (commit 481da5f):
  • Your README.md does not follow best practices (headings need to be uppercase). See https://www.drupal.org/node/2181737 .
    • The INTRODUCTION section is missing.
    • The REQUIREMENTS section is missing.
    • The INSTALLATION section is missing.
    • The CONFIGURATION section is missing.
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • No automated test cases were found, did you consider writing PHPUnit tests? This is not a requirement but encouraged for professional software development.
This automated report was generated with PAReview.sh, your friendly project application review script.

FILE: ...000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/README.md
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 11 WARNINGS AFFECTING 11 LINES
--------------------------------------------------------------------------
  3 | WARNING | Line exceeds 80 characters; contains 90 characters
 18 | WARNING | Line exceeds 80 characters; contains 87 characters
 41 | WARNING | Line exceeds 80 characters; contains 82 characters
 45 | WARNING | Line exceeds 80 characters; contains 90 characters
 49 | WARNING | Line exceeds 80 characters; contains 120 characters
 51 | WARNING | Line exceeds 80 characters; contains 85 characters
 55 | WARNING | Line exceeds 80 characters; contains 83 characters
 59 | WARNING | Line exceeds 80 characters; contains 136 characters
 63 | WARNING | Line exceeds 80 characters; contains 104 characters
 69 | WARNING | Line exceeds 80 characters; contains 222 characters
 75 | WARNING | Line exceeds 80 characters; contains 202 characters
--------------------------------------------------------------------------


FILE: ...0/site1101/web/vendor/drupal/pareviewsh/pareview_temp/dialogs.module
--------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------
  1 | ERROR | [x] The PHP open tag must be followed by exactly one blank
    |       |     line
  4 | ERROR | [x] Function comment short description must start with
    |       |     exactly one space
 16 | ERROR | [x] Case breaking statements must be followed by a single
    |       |     blank line
 16 | ERROR | [x] Comments may not appear after statements
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...e1101/web/vendor/drupal/pareviewsh/pareview_temp/src/Dialogifyer.php
--------------------------------------------------------------------------
FOUND 6 ERRORS AFFECTING 5 LINES
--------------------------------------------------------------------------
  8 | ERROR | [x] Missing class doc comment
 31 | ERROR | [ ] Missing short description in doc comment
 36 | ERROR | [ ] Missing short description in doc comment
 64 | ERROR | [ ] Type hint "array" missing for $libraries
 64 | ERROR | [ ] Type hint "array" missing for $queryParametersToUnset
 78 | ERROR | [x] Expected "\Drupal\Core\Render\BubbleableMetadata|null"
    |       |     but found "\Drupal\Core\Render\BubbleableMetadata|NULL"
    |       |     for parameter type
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...1101/web/vendor/drupal/pareviewsh/pareview_temp/src/DialogsHooks.php
--------------------------------------------------------------------------
FOUND 3 ERRORS AND 1 WARNING AFFECTING 4 LINES
--------------------------------------------------------------------------
  5 | ERROR   | [x] Missing class doc comment
 17 | ERROR   | [ ] Missing parameter comment
 27 | WARNING | [ ] Line exceeds 80 characters; contains 82 characters
 31 | ERROR   | [x] Doc comment star missing
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...eb/vendor/drupal/pareviewsh/pareview_temp/src/DialogifyerFactory.php
--------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 5 LINES
--------------------------------------------------------------------------
  8 | ERROR | [x] Missing class doc comment
 34 | ERROR | [ ] Missing parameter comment
 35 | ERROR | [ ] Missing parameter comment
 45 | ERROR | [x] Expected "array|null" but found "array|NULL" for
    |       |     parameter type
 49 | ERROR | [x] Return comment indentation must be 3 spaces, found 2
    |       |     spaces
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Time: 704ms; Memory: 4Mb