https://git.drupal.org/project/email_formatter

Primary tabs

Review of the 8.x-1.x branch (commit fc14582):
  • ./email_formatter.module: All functions should be prefixed with your module/theme name (email_formatter) to avoid name clashes. See https://www.drupal.org/node/318#naming
    function link_icons_theme() {
    
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards).
    
    FILE: .../web/vendor/drupal/pareviewsh/pareview_temp/email_formatter.info.yml
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     1 | WARNING | Remove "version" from the info file, it will be added by
       |         | drupal.org packaging automatically
    --------------------------------------------------------------------------
    
    Time: 919ms; Memory: 4Mb
    
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: ...wsh/pareview_temp/src/Plugin/Field/FieldFormatter/EmailFormatter.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
    --------------------------------------------------------------------------
      43 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     111 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
    --------------------------------------------------------------------------
    
    Time: 330ms; Memory: 4Mb
    
  • No automated test cases were found, did you consider writing PHPUnit tests? This is not a requirement but encouraged for professional software development.
This automated report was generated with PAReview.sh, your friendly project application review script.