Revision of https://git.drupal.org/project/entity_share.git 8.x-2.x from Fri, 05/24/2019 - 17:28

Revisions allow you to track differences between multiple versions of your content, and revert back to older versions.

Review of the 8.x-2.x branch (commit 05518f4):
  • The entity_share_server.module does not implement hook_help(). See https://www.drupal.org/docs/develop/documenting-your-project/module-docu... .
  • The entity_share_client_test.module does not implement hook_help(). See https://www.drupal.org/docs/develop/documenting-your-project/module-docu... .
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: ...review_temp/modules/entity_share_client/entity_share_client.info.yml
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     10 | WARNING | All dependencies must be prefixed with the project name,
        |         | for example "drupal:"
    --------------------------------------------------------------------------
    
    
    FILE: ...review_temp/modules/entity_share_server/entity_share_server.info.yml
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     11 | WARNING | All dependencies must be prefixed with the project name,
        |         | for example "drupal:"
    --------------------------------------------------------------------------
    
    Time: 7.44 secs; Memory: 10Mb
    
This automated report was generated with PAReview.sh, your friendly project application review script.

FILE: ...00000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/README.txt
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
 104 | WARNING | Line exceeds 80 characters; contains 91 characters
--------------------------------------------------------------------------


FILE: ...dules/entity_share_client/src/Commands/EntityShareClientCommands.php
--------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
--------------------------------------------------------------------------
 47 | WARNING | Line exceeds 80 characters; contains 104 characters
 49 | ERROR   | Type hint "array" missing for $options
--------------------------------------------------------------------------


FILE: ...ules/entity_share_client/src/Service/EntityShareClientCliService.php
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
--------------------------------------------------------------------------
 197 | WARNING | Line exceeds 80 characters; contains 88 characters
 221 | WARNING | Line exceeds 80 characters; contains 85 characters
--------------------------------------------------------------------------

Time: 11.35 secs; Memory: 10Mb