Revision of https://git.drupal.org/project/exam_spider.git 8.x-3.x from Thu, 03/28/2019 - 18:53

Revisions allow you to track differences between multiple versions of your content, and revert back to older versions.

Review of the 8.x-3.x branch (commit 20ab0d6):
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: ...te1101/web/vendor/drupal/pareviewsh/pareview_temp/exam_spider.module
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
    --------------------------------------------------------------------------
     14 | WARNING | Global constants should not be used, move it to a class
        |         | or interface
     15 | WARNING | Global constants should not be used, move it to a class
        |         | or interface
    --------------------------------------------------------------------------
    
    
    FILE: ...01/web/vendor/drupal/pareviewsh/pareview_temp/src/ExamSpiderData.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     76 | WARNING | \Drupal calls should be avoided in classes, use
        |         | dependency injection instead
    --------------------------------------------------------------------------
    
    
    FILE: ...vendor/drupal/pareviewsh/pareview_temp/src/Controller/ExamSpider.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
    --------------------------------------------------------------------------
     221 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
     232 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
     241 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
    --------------------------------------------------------------------------
    
    
    FILE: .../drupal/pareviewsh/pareview_temp/src/Form/ExamSpiderSettingsForm.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     66 | WARNING | \Drupal calls should be avoided in classes, use
        |         | dependency injection instead
    --------------------------------------------------------------------------
    
    
    FILE: ...ndor/drupal/pareviewsh/pareview_temp/src/Form/ExamSpiderExamForm.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
    --------------------------------------------------------------------------
      55 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
     153 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
    --------------------------------------------------------------------------
    
    
    FILE: .../drupal/pareviewsh/pareview_temp/src/Form/ExamSpiderExamContinue.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
    --------------------------------------------------------------------------
      63 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
     205 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
    --------------------------------------------------------------------------
    
    
    FILE: ...r/drupal/pareviewsh/pareview_temp/src/Form/ExamSpiderResultsForm.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
    --------------------------------------------------------------------------
     108 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
     181 | WARNING | User::load calls should be avoided in classes, use
         |         | dependency injection instead
    --------------------------------------------------------------------------
    
    
    FILE: .../drupal/pareviewsh/pareview_temp/src/Form/ExamSpiderQuestionForm.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
    --------------------------------------------------------------------------
      58 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
     127 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
    --------------------------------------------------------------------------
    
    Time: 1.9 secs; Memory: 6Mb
    
  • No automated test cases were found, did you consider writing PHPUnit tests? This is not a requirement but encouraged for professional software development.
This automated report was generated with PAReview.sh, your friendly project application review script.