Revision of https://git.drupal.org/project/exam_spider.git 8.x-3.x from Fri, 03/29/2019 - 20:02

Revisions allow you to track differences between multiple versions of your content, and revert back to older versions.

Review of the 8.x-3.x branch (commit 9700050):
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards).
    
    FILE: ...01/web/vendor/drupal/pareviewsh/pareview_temp/src/ExamSpiderData.php
    --------------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    --------------------------------------------------------------------------
     74 | ERROR | Arguments with default values must be at the end of the
        |       | argument list
    --------------------------------------------------------------------------
    
    
    FILE: ...ndor/drupal/pareviewsh/pareview_temp/src/ExamSpiderDataInterface.php
    --------------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    --------------------------------------------------------------------------
     34 | ERROR | Arguments with default values must be at the end of the
        |       | argument list
    --------------------------------------------------------------------------
    
    Time: 3.07 secs; Memory: 8Mb
    
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: ...te1101/web/vendor/drupal/pareviewsh/pareview_temp/exam_spider.module
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
    --------------------------------------------------------------------------
     14 | WARNING | Global constants should not be used, move it to a class
        |         | or interface
     15 | WARNING | Global constants should not be used, move it to a class
        |         | or interface
    --------------------------------------------------------------------------
    
    
    FILE: .../drupal/pareviewsh/pareview_temp/src/Form/ExamSpiderExamContinue.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     75 | WARNING | \Drupal calls should be avoided in classes, use
        |         | dependency injection instead
    --------------------------------------------------------------------------
    
    Time: 1.95 secs; Memory: 6Mb
    
  • No automated test cases were found, did you consider writing PHPUnit tests? This is not a requirement but encouraged for professional software development.
This automated report was generated with PAReview.sh, your friendly project application review script.