https://git.drupal.org/project/field_multiple_limit.git 8.x-1.x

Primary tabs

Git errors: Review of the 8.x-1.x branch (commit 436c446):
  • README.md or README.txt is missing, see the guidelines for in-project documentation.
  • The field_multiple_limit.module does not implement hook_help(). See https://www.drupal.org/docs/develop/documenting-your-project/module-docu... .
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: ...vendor/drupal/pareviewsh/pareview_temp/field_multiple_limit.info.yml
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     7 | WARNING | All dependencies must be prefixed with the project name,
       |         | for example "drupal:"
    --------------------------------------------------------------------------
    
    
    FILE: ...b/vendor/drupal/pareviewsh/pareview_temp/field_multiple_limit.module
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     13 | WARNING | Global constants should not be used, move it to a class
        |         | or interface
    --------------------------------------------------------------------------
    
    Time: 200ms; Memory: 4Mb
    
  • No automated test cases were found, did you consider writing PHPUnit tests? This is not a requirement but encouraged for professional software development.
This automated report was generated with PAReview.sh, your friendly project application review script.

FILE: ...b/vendor/drupal/pareviewsh/pareview_temp/field_multiple_limit.module
--------------------------------------------------------------------------
FOUND 13 ERRORS AFFECTING 11 LINES
--------------------------------------------------------------------------
  6 | ERROR | [ ] Doc comment short description must be on a single line,
    |       |     further text should be a separate paragraph
  9 | ERROR | [ ] Missing short description in doc comment
 19 | ERROR | [x] Expected 1 blank line before function; 2 found
 23 | ERROR | [x] Inline comments must end in full-stops, exclamation
    |       |     marks, colons, question marks, or closing parentheses
 24 | ERROR | [x] Whitespace found at end of line
 41 | ERROR | [x] Whitespace found at end of line
 46 | ERROR | [x] Additional blank lines found at end of doc comment
 47 | ERROR | [x] Namespaced classes/interfaces/traits should be
    |       |     referenced with use statements
 47 | ERROR | [x] Namespaced classes/interfaces/traits should be
    |       |     referenced with use statements
 47 | ERROR | [x] Namespaced classes/interfaces/traits should be
    |       |     referenced with use statements
 50 | ERROR | [x] Short array syntax must be used to define arrays
 56 | ERROR | [x] Short array syntax must be used to define arrays
 62 | ERROR | [x] Short array syntax must be used to define arrays
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 11 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Time: 627ms; Memory: 4Mb