https://git.drupal.org/project//field_slideshow.git 8.x-3.x

Primary tabs

Git errors: Review of the 8.x-3.x branch (commit 032d0a9):
  • Your README.txt does not follow best practices (headings need to be uppercase). See https://www.drupal.org/node/2181737 .
    • The INTRODUCTION section is missing.
    • The REQUIREMENTS section is missing.
    • The CONFIGURATION section is missing.
  • ESLint has found some issues with your code (please check the JavaScript coding standards).
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/field_slideshow.js: line 6, col 2, Error - Use the function form of 'use strict'. (strict)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/field_slideshow.js: line 6, col 10, Error - Missing space before function parentheses. (space-before-function-paren)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/field_slideshow.js: line 14, col 38, Error - Strings must use singlequote. (quotes)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/field_slideshow.js: line 21, col 19, Error - Strings must use singlequote. (quotes)
    
    4 problems
    
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: ...wsh/pareview_temp/src/Plugin/Field/FieldFormatter/FieldSlideshow.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     475 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
    --------------------------------------------------------------------------
    
    Time: 440ms; Memory: 6Mb
    
  • No automated test cases were found, did you consider writing PHPUnit tests? This is not a requirement but encouraged for professional software development.
This automated report was generated with PAReview.sh, your friendly project application review script.