https://git.drupal.org/project/file_history.git 8.x-1.x

Primary tabs

Git errors: Review of the 8.x-1.x branch (commit e6ac5d2):
  • Your README.md does not follow best practices (headings need to be uppercase). See https://www.drupal.org/node/2181737 .
    • The INTRODUCTION section is missing.
    • The REQUIREMENTS section is missing.
    • The INSTALLATION section is missing.
    • The CONFIGURATION section is missing.
  • The file_history.module does not implement hook_help(). See https://www.drupal.org/docs/develop/documenting-your-project/module-docu... .
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards).
    
    FILE: .../web/vendor/drupal/pareviewsh/pareview_temp/src/Form/ExempleForm.php
    --------------------------------------------------------------------------
    FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
    --------------------------------------------------------------------------
     35 | ERROR   | [x] Functions must not contain multiple empty lines in a
        |         |     row; found 2 empty lines
     59 | WARNING | [x] A comma should follow the last multiline array item.
        |         |     Found: )
    --------------------------------------------------------------------------
    PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    --------------------------------------------------------------------------
    
    Time: 1.34 secs; Memory: 6Mb
    
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: ...101/web/vendor/drupal/pareviewsh/pareview_temp/file_history.info.yml
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     7 | WARNING | All dependencies must be prefixed with the project name,
       |         | for example "drupal:"
    --------------------------------------------------------------------------
    
    
    FILE: ...al/pareviewsh/pareview_temp/src/Controller/FileHistoryController.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     26 | WARNING | \Drupal calls should be avoided in classes, use
        |         | dependency injection instead
    --------------------------------------------------------------------------
    
    
    FILE: ...b/vendor/drupal/pareviewsh/pareview_temp/src/Element/FileHistory.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 5 WARNINGS AFFECTING 5 LINES
    --------------------------------------------------------------------------
      54 | WARNING | Messages are user facing text and must run through t()
         |         | for translation
     408 | WARNING | Messages are user facing text and must run through t()
         |         | for translation
     469 | WARNING | Unused variable $row_id.
     499 | WARNING | Unused variable $element_name.
     528 | WARNING | Unused variable $element_name.
    --------------------------------------------------------------------------
    
    
    FILE: .../web/vendor/drupal/pareviewsh/pareview_temp/file_history.routing.yml
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     8 | WARNING | The administration page callback should probably use
       |         | "administer site configuration" - which implies the user
       |         | can change something - rather than "access administration
       |         | pages" which is about viewing but not changing
       |         | configurations.
    --------------------------------------------------------------------------
    
    Time: 716ms; Memory: 6Mb
    
  • No automated test cases were found, did you consider writing PHPUnit tests? This is not a requirement but encouraged for professional software development.
This automated report was generated with PAReview.sh, your friendly project application review script.