Revision of https://git.drupal.org/project/file_management.git from Thu, 03/14/2019 - 18:14

Revisions allow you to track differences between multiple versions of your content, and revert back to older versions.

Review of the 8.x-1.x branch (commit d6c1133):
  • Your README.md does not follow best practices (headings need to be uppercase). See https://www.drupal.org/node/2181737 .
    • The INTRODUCTION section is missing.
    • The REQUIREMENTS section is missing.
    • The INSTALLATION section is missing.
    • The CONFIGURATION section is missing.
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: ...file_management_view/src/Controller/FileManagementViewController.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     65 | WARNING | \Drupal calls should be avoided in classes, use
        |         | dependency injection instead
    --------------------------------------------------------------------------
    
    
    FILE: ...01/web/vendor/drupal/pareviewsh/pareview_temp/src/FileManagement.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     172 | WARNING | Unused variable $module.
    --------------------------------------------------------------------------
    
    
    FILE: ...pal/pareviewsh/pareview_temp/src/Form/FileManagementEditFileForm.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     203 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
    --------------------------------------------------------------------------
    
    Time: 761ms; Memory: 4Mb
    
  • No automated test cases were found, did you consider writing PHPUnit tests? This is not a requirement but encouraged for professional software development.
This automated report was generated with PAReview.sh, your friendly project application review script.

FILE: ...000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/README.md
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
 59 | WARNING | Line exceeds 80 characters; contains 90 characters
--------------------------------------------------------------------------


FILE: ...file_management_view/src/Controller/FileManagementViewController.php
--------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------
 86 | ERROR | [ ] Type hint "array" missing for $arguments
 86 | ERROR | [x] Incorrect spacing between argument "$arguments" and
    |       |     equals sign; expected 1 but found 0
 86 | ERROR | [x] Incorrect spacing between default value and equals sign
    |       |     for argument "$arguments"; expected 1 but found 0
 94 | ERROR | [x] Expected 1 blank line after function; 0 found
 95 | ERROR | [x] The closing brace for the class must have an empty line
    |       |     before it
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...pal/pareviewsh/pareview_temp/src/Form/FileManagementEditFileForm.php
--------------------------------------------------------------------------
FOUND 8 ERRORS AND 3 WARNINGS AFFECTING 9 LINES
--------------------------------------------------------------------------
  15 | ERROR   | [x] Missing function doc comment
  22 | ERROR   | [x] Visibility must be declared on method "buildForm"
  52 | ERROR   | [ ] Concatenating translatable strings is not allowed,
     |         |     use placeholders instead and only one string literal
  62 | ERROR   | [ ] Concatenating translatable strings is not allowed,
     |         |     use placeholders instead and only one string literal
  62 | ERROR   | [ ] String concat is not required here; use a single
     |         |     string instead
  73 | ERROR   | [ ] Concatenating translatable strings is not allowed,
     |         |     use placeholders instead and only one string literal
  73 | ERROR   | [ ] String concat is not required here; use a single
     |         |     string instead
 155 | WARNING | [ ] Line exceeds 80 characters; contains 82 characters
 167 | WARNING | [ ] Line exceeds 80 characters; contains 87 characters
 172 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters
 193 | ERROR   | [x] Whitespace found at end of line
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Time: 1.3 secs; Memory: 4Mb