https://git.drupal.org/project/flexi_cart

Primary tabs

Review of the 8.x-1.x branch (commit 820b42a):
  • Your README.txt does not follow best practices (headings need to be uppercase). See https://www.drupal.org/node/2181737 .
    • The INTRODUCTION section is missing.
    • The REQUIREMENTS section is missing.
    • The INSTALLATION section is missing.
    • The CONFIGURATION section is missing.
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • ESLint has found some issues with your code (please check the JavaScript coding standards). See attachment.
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: ...site1101/web/vendor/drupal/pareviewsh/pareview_temp/flexi_cart.theme
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 6 WARNINGS AFFECTING 6 LINES
    --------------------------------------------------------------------------
     21 | WARNING | Unused variable $face_book.
     22 | WARNING | Unused variable $twitter.
     23 | WARNING | Unused variable $linkedin.
     24 | WARNING | Unused variable $instagram.
     25 | WARNING | Unused variable $email.
     26 | WARNING | Unused variable $copyrights.
    --------------------------------------------------------------------------
    
    Time: 321ms; Memory: 4Mb
    
This automated report was generated with PAReview.sh, your friendly project application review script.

FILE: ...00/site1101/web/vendor/drupal/pareviewsh/pareview_temp/css/style.css
--------------------------------------------------------------------------
FOUND 58 ERRORS AFFECTING 38 LINES
--------------------------------------------------------------------------
  407 | ERROR | [ ] Class definition is empty
  409 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0
  410 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0
  412 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0
  413 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0
  472 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0
  473 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0
  476 | ERROR | [x] Multiple selectors should each be on a single line
  577 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0
  578 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0
  581 | ERROR | [x] Multiple selectors should each be on a single line
  581 | ERROR | [x] Multiple selectors should each be on a single line
  648 | ERROR | [x] Multiple selectors should each be on a single line
  648 | ERROR | [x] Multiple selectors should each be on a single line
  653 | ERROR | [x] Multiple selectors should each be on a single line
  660 | ERROR | [x] Multiple selectors should each be on a single line
  660 | ERROR | [x] Multiple selectors should each be on a single line
  660 | ERROR | [x] Multiple selectors should each be on a single line
  660 | ERROR | [x] Multiple selectors should each be on a single line
  660 | ERROR | [x] Multiple selectors should each be on a single line
  677 | ERROR | [x] Multiple selectors should each be on a single line
  681 | ERROR | [x] Multiple selectors should each be on a single line
  687 | ERROR | [x] Multiple selectors should each be on a single line
  710 | ERROR | [x] Multiple selectors should each be on a single line
  715 | ERROR | [x] Multiple selectors should each be on a single line
  715 | ERROR | [x] Multiple selectors should each be on a single line
  715 | ERROR | [x] Multiple selectors should each be on a single line
  808 | ERROR | [x] Multiple selectors should each be on a single line
  808 | ERROR | [x] Multiple selectors should each be on a single line
  808 | ERROR | [x] Multiple selectors should each be on a single line
 1120 | ERROR | [x] Multiple selectors should each be on a single line
 1451 | ERROR | [x] Multiple selectors should each be on a single line
 1451 | ERROR | [x] Multiple selectors should each be on a single line
 1451 | ERROR | [x] Multiple selectors should each be on a single line
 1452 | ERROR | [x] Multiple selectors should each be on a single line
 1467 | ERROR | [x] Multiple selectors should each be on a single line
 1467 | ERROR | [x] Multiple selectors should each be on a single line
 1467 | ERROR | [x] Multiple selectors should each be on a single line
 1468 | ERROR | [x] Multiple selectors should each be on a single line
 1478 | ERROR | [x] Multiple selectors should each be on a single line
 1484 | ERROR | [x] Multiple selectors should each be on a single line
 1484 | ERROR | [x] Multiple selectors should each be on a single line
 1484 | ERROR | [x] Multiple selectors should each be on a single line
 1515 | ERROR | [x] Multiple selectors should each be on a single line
 1515 | ERROR | [x] Multiple selectors should each be on a single line
 1515 | ERROR | [x] Multiple selectors should each be on a single line
 1544 | ERROR | [x] Multiple selectors should each be on a single line
 1578 | ERROR | [x] Multiple selectors should each be on a single line
 1578 | ERROR | [x] Multiple selectors should each be on a single line
 1578 | ERROR | [x] Multiple selectors should each be on a single line
 1579 | ERROR | [x] Multiple selectors should each be on a single line
 1610 | ERROR | [x] Multiple selectors should each be on a single line
 1634 | ERROR | [x] Multiple selectors should each be on a single line
 1643 | ERROR | [x] Multiple selectors should each be on a single line
 1721 | ERROR | [x] Multiple selectors should each be on a single line
 1855 | ERROR | [x] Multiple selectors should each be on a single line
 1943 | ERROR | [x] Multiple selectors should each be on a single line
 2074 | ERROR | [x] Whitespace found at end of line
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 57 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...0/site1101/web/vendor/drupal/pareviewsh/pareview_temp/css/screen.css
--------------------------------------------------------------------------
FOUND 87 ERRORS AFFECTING 18 LINES
--------------------------------------------------------------------------
  6 | ERROR | [x] Multiple selectors should each be on a single line
  6 | ERROR | [x] Multiple selectors should each be on a single line
  6 | ERROR | [x] Multiple selectors should each be on a single line
  6 | ERROR | [x] Multiple selectors should each be on a single line
  6 | ERROR | [x] Multiple selectors should each be on a single line
  6 | ERROR | [x] Multiple selectors should each be on a single line
  7 | ERROR | [x] Multiple selectors should each be on a single line
  7 | ERROR | [x] Multiple selectors should each be on a single line
  7 | ERROR | [x] Multiple selectors should each be on a single line
  7 | ERROR | [x] Multiple selectors should each be on a single line
  7 | ERROR | [x] Multiple selectors should each be on a single line
  7 | ERROR | [x] Multiple selectors should each be on a single line
  7 | ERROR | [x] Multiple selectors should each be on a single line
  7 | ERROR | [x] Multiple selectors should each be on a single line
  8 | ERROR | [x] Multiple selectors should each be on a single line
  8 | ERROR | [x] Multiple selectors should each be on a single line
  8 | ERROR | [x] Multiple selectors should each be on a single line
  8 | ERROR | [x] Multiple selectors should each be on a single line
  8 | ERROR | [x] Multiple selectors should each be on a single line
  8 | ERROR | [x] Multiple selectors should each be on a single line
  9 | ERROR | [x] Multiple selectors should each be on a single line
  9 | ERROR | [x] Multiple selectors should each be on a single line
  9 | ERROR | [x] Multiple selectors should each be on a single line
  9 | ERROR | [x] Multiple selectors should each be on a single line
  9 | ERROR | [x] Multiple selectors should each be on a single line
  9 | ERROR | [x] Multiple selectors should each be on a single line
  9 | ERROR | [x] Multiple selectors should each be on a single line
  9 | ERROR | [x] Multiple selectors should each be on a single line
 10 | ERROR | [x] Multiple selectors should each be on a single line
 10 | ERROR | [x] Multiple selectors should each be on a single line
 10 | ERROR | [x] Multiple selectors should each be on a single line
 10 | ERROR | [x] Multiple selectors should each be on a single line
 10 | ERROR | [x] Multiple selectors should each be on a single line
 10 | ERROR | [x] Multiple selectors should each be on a single line
 11 | ERROR | [x] Multiple selectors should each be on a single line
 11 | ERROR | [x] Multiple selectors should each be on a single line
 11 | ERROR | [x] Multiple selectors should each be on a single line
 12 | ERROR | [x] Multiple selectors should each be on a single line
 12 | ERROR | [x] Multiple selectors should each be on a single line
 12 | ERROR | [x] Multiple selectors should each be on a single line
 12 | ERROR | [x] Multiple selectors should each be on a single line
 12 | ERROR | [x] Multiple selectors should each be on a single line
 13 | ERROR | [x] Multiple selectors should each be on a single line
 13 | ERROR | [x] Multiple selectors should each be on a single line
 13 | ERROR | [x] Multiple selectors should each be on a single line
 14 | ERROR | [x] Multiple selectors should each be on a single line
 14 | ERROR | [x] Multiple selectors should each be on a single line
 14 | ERROR | [x] Multiple selectors should each be on a single line
 14 | ERROR | [x] Multiple selectors should each be on a single line
 14 | ERROR | [x] Multiple selectors should each be on a single line
 14 | ERROR | [x] Multiple selectors should each be on a single line
 14 | ERROR | [x] Multiple selectors should each be on a single line
 15 | ERROR | [x] Multiple selectors should each be on a single line
 15 | ERROR | [x] Multiple selectors should each be on a single line
 15 | ERROR | [x] Multiple selectors should each be on a single line
 15 | ERROR | [x] Multiple selectors should each be on a single line
 16 | ERROR | [x] Multiple selectors should each be on a single line
 16 | ERROR | [x] Multiple selectors should each be on a single line
 16 | ERROR | [x] Multiple selectors should each be on a single line
 16 | ERROR | [x] Multiple selectors should each be on a single line
 17 | ERROR | [x] Multiple selectors should each be on a single line
 17 | ERROR | [x] Multiple selectors should each be on a single line
 17 | ERROR | [x] Multiple selectors should each be on a single line
 17 | ERROR | [x] Multiple selectors should each be on a single line
 17 | ERROR | [x] Multiple selectors should each be on a single line
 18 | ERROR | [x] Multiple selectors should each be on a single line
 18 | ERROR | [x] Multiple selectors should each be on a single line
 18 | ERROR | [x] Multiple selectors should each be on a single line
 33 | ERROR | [x] Multiple selectors should each be on a single line
 44 | ERROR | [x] Multiple selectors should each be on a single line
 44 | ERROR | [x] Multiple selectors should each be on a single line
 51 | ERROR | [x] Multiple selectors should each be on a single line
 55 | ERROR | [x] Multiple selectors should each be on a single line
 55 | ERROR | [x] Multiple selectors should each be on a single line
 55 | ERROR | [x] Multiple selectors should each be on a single line
 66 | ERROR | [x] Multiple selectors should each be on a single line
 66 | ERROR | [x] Multiple selectors should each be on a single line
 66 | ERROR | [x] Multiple selectors should each be on a single line
 66 | ERROR | [x] Multiple selectors should each be on a single line
 66 | ERROR | [x] Multiple selectors should each be on a single line
 66 | ERROR | [x] Multiple selectors should each be on a single line
 66 | ERROR | [x] Multiple selectors should each be on a single line
 66 | ERROR | [x] Multiple selectors should each be on a single line
 66 | ERROR | [x] Multiple selectors should each be on a single line
 66 | ERROR | [x] Multiple selectors should each be on a single line
 66 | ERROR | [x] Multiple selectors should each be on a single line
 66 | ERROR | [x] Multiple selectors should each be on a single line
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 87 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...00000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/README.txt
--------------------------------------------------------------------------
FOUND 1 ERROR AND 4 WARNINGS AFFECTING 5 LINES
--------------------------------------------------------------------------
  3 | WARNING | [ ] Line exceeds 80 characters; contains 289 characters
  5 | WARNING | [ ] Line exceeds 80 characters; contains 171 characters
 20 | WARNING | [ ] Line exceeds 80 characters; contains 87 characters
 21 | WARNING | [ ] Line exceeds 80 characters; contains 89 characters
 38 | ERROR   | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...upal/pareviewsh/pareview_temp/config/install/flexi_cart.settings.yml
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 16 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...e1101/web/vendor/drupal/pareviewsh/pareview_temp/flexi_cart.info.yml
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 33 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...site1101/web/vendor/drupal/pareviewsh/pareview_temp/flexi_cart.theme
--------------------------------------------------------------------------
FOUND 38 ERRORS AND 13 WARNINGS AFFECTING 32 LINES
--------------------------------------------------------------------------
   2 | ERROR   | [x] Additional whitespace found at start of file
  12 | WARNING | [x] Unused use statement
  13 | WARNING | [x] Unused use statement
  14 | WARNING | [x] Unused use statement
  15 | WARNING | [x] Unused use statement
  16 | WARNING | [x] Unused use statement
  17 | WARNING | [x] Unused use statement
  17 | ERROR   | [x] There must be one blank line after the last USE
     |         |     statement; 2 found;
  20 | ERROR   | [x] Missing function doc comment
  20 | ERROR   | [x] Expected 1 blank line before function; 2 found
  28 | ERROR   | [x] No space found before comment text; expected "//
     |         |     Social Icons" but found "//Social Icons"
  28 | ERROR   | [x] Inline comments must end in full-stops, exclamation
     |         |     marks, colons, question marks, or closing
     |         |     parentheses
  29 | ERROR   | [x] Expected one space after the comma, 0 found
  30 | ERROR   | [x] Expected one space after the comma, 0 found
  31 | ERROR   | [x] Expected one space after the comma, 0 found
  32 | ERROR   | [x] Expected one space after the comma, 0 found
  33 | ERROR   | [x] Expected one space after the comma, 0 found
  34 | ERROR   | [x] Expected one space after the comma, 0 found
  38 | ERROR   | [x] Short array syntax must be used to define arrays
  41 | ERROR   | [x] Namespaced classes/interfaces/traits should be
     |         |     referenced with use statements
  49 | ERROR   | [x] Short array syntax must be used to define arrays
  62 | WARNING | [ ] Hook implementations should not duplicate @param
     |         |     documentation
  62 | ERROR   | [ ] Missing parameter type
  64 | WARNING | [ ] Hook implementations should not duplicate @param
     |         |     documentation
  64 | ERROR   | [ ] Missing parameter type
  66 | ERROR   | [x] There must be no blank lines after the function
     |         |     comment
  68 | ERROR   | [x] Namespaced classes/interfaces/traits should be
     |         |     referenced with use statements
 120 | ERROR   | [x] Expected 1 space after "="; 0 found
 132 | WARNING | [ ] Translatable strings must not begin or end with
     |         |     white spaces, use placeholders with t() for
     |         |     variables
 132 | ERROR   | [ ] Concatenating translatable strings is not allowed,
     |         |     use placeholders instead and only one string literal
 132 | ERROR   | [x] Concat operator must be surrounded by a single space
 138 | WARNING | [ ] Translatable strings must not begin or end with
     |         |     white spaces, use placeholders with t() for
     |         |     variables
 138 | ERROR   | [ ] Concatenating translatable strings is not allowed,
     |         |     use placeholders instead and only one string literal
 138 | ERROR   | [x] Concat operator must be surrounded by a single space
 138 | ERROR   | [x] Concat operator must be surrounded by a single space
 143 | WARNING | [ ] Translatable strings must not begin or end with
     |         |     white spaces, use placeholders with t() for
     |         |     variables
 143 | ERROR   | [ ] Concatenating translatable strings is not allowed,
     |         |     use placeholders instead and only one string literal
 143 | ERROR   | [x] Concat operator must be surrounded by a single space
 143 | ERROR   | [x] Concat operator must be surrounded by a single space
 148 | WARNING | [ ] Translatable strings must not begin or end with
     |         |     white spaces, use placeholders with t() for
     |         |     variables
 148 | ERROR   | [ ] Concatenating translatable strings is not allowed,
     |         |     use placeholders instead and only one string literal
 148 | ERROR   | [x] Concat operator must be surrounded by a single space
 148 | ERROR   | [x] Concat operator must be surrounded by a single space
 155 | WARNING | [ ] Translatable strings must not begin or end with
     |         |     white spaces, use placeholders with t() for
     |         |     variables
 155 | ERROR   | [ ] Concatenating translatable strings is not allowed,
     |         |     use placeholders instead and only one string literal
 155 | ERROR   | [x] Concat operator must be surrounded by a single space
 155 | ERROR   | [x] Concat operator must be surrounded by a single space
 160 | ERROR   | [x] Short array syntax must be used to define arrays
 166 | ERROR   | [x] Expected 1 space(s) before asterisk; 0 found
 167 | ERROR   | [x] Namespaced classes/interfaces/traits should be
     |         |     referenced with use statements
 172 | ERROR   | [x] Namespaced classes/interfaces/traits should be
     |         |     referenced with use statements
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 37 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Time: 2.61 secs; Memory: 12Mb
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/script.js: line 8, col 10, Error - Missing space before function parentheses. (space-before-function-paren)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/script.js: line 13, col 21, Error - Missing space before function parentheses. (space-before-function-paren)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/script.js: line 14, col 53, Error - Missing space before function parentheses. (space-before-function-paren)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/script.js: line 14, col 55, Error - Missing space before opening brace. (space-before-blocks)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/script.js: line 15, col 21, Error - Multiple spaces found before '$'. (no-multi-spaces)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/script.js: line 17, col 9, Error - Missing semicolon. (semi)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/script.js: line 21, col 29, Error - Missing space before function parentheses. (space-before-function-paren)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/script.js: line 27, col 7, Error - Strings must use singlequote. (quotes)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/script.js: line 27, col 41, Error - Strings must use singlequote. (quotes)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/script.js: line 27, col 56, Error - Strings must use singlequote. (quotes)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/script.js: line 32, col 40, Error - Missing space before function parentheses. (space-before-function-paren)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/script.js: line 34, col 31, Error - Strings must use singlequote. (quotes)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/script.js: line 36, col 29, Error - Strings must use singlequote. (quotes)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/script.js: line 42, col 43, Error - Missing space before function parentheses. (space-before-function-paren)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/script.js: line 44, col 31, Error - Strings must use singlequote. (quotes)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/script.js: line 46, col 29, Error - Strings must use singlequote. (quotes)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/script.js: line 65, col 41, Error - Missing space before function parentheses. (space-before-function-paren)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/script.js: line 67, col 11, Error - 't' is assigned a value but never used. (no-unused-vars)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/script.js: line 68, col 7, Error - Missing semicolon. (semi)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/script.js: line 75, col 69, Error - Missing space before function parentheses. (space-before-function-paren)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/script.js: line 83, col 30, Error - Missing space before function parentheses. (space-before-function-paren)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/script.js: line 92, col 1, Error - Trailing spaces not allowed. (no-trailing-spaces)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/script.js: line 94, col 1, Error - Trailing spaces not allowed. (no-trailing-spaces)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/script.js: line 94, col 3, Error - Newline required at end of file but not found. (eol-last)

24 problems