Revision of https://git.drupal.org/project/ga_node_reports.git 8.x-1.x from Thu, 02/07/2019 - 19:47

Revisions allow you to track differences between multiple versions of your content, and revert back to older versions.

Git errors: Review of the 8.x-1.x branch (commit 33b87ae):
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards).
    
    FILE: ...00000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/README.txt
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     29 | WARNING | Line exceeds 80 characters; contains 84 characters
    --------------------------------------------------------------------------
    
    Time: 1.56 secs; Memory: 6Mb
    
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: ...upal/pareviewsh/pareview_temp/src/Controller/GaNodeReportsCharts.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 7 WARNINGS AFFECTING 7 LINES
    --------------------------------------------------------------------------
      93 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
     194 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
     287 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
     308 | WARNING | Unused variable $chart_source.
     380 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
     401 | WARNING | Unused variable $chart_source.
     438 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
    --------------------------------------------------------------------------
    
    
    FILE: ...r/drupal/pareviewsh/pareview_temp/src/Form/GaNodeReportConfigure.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     77 | WARNING | \Drupal calls should be avoided in classes, use
        |         | dependency injection instead
    --------------------------------------------------------------------------
    
    
    FILE: .../drupal/pareviewsh/pareview_temp/src/Form/GaNodeReportStatistics.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     62 | WARNING | \Drupal calls should be avoided in classes, use
        |         | dependency injection instead
    --------------------------------------------------------------------------
    
    Time: 727ms; Memory: 6Mb
    
  • No automated test cases were found, did you consider writing PHPUnit tests? This is not a requirement but encouraged for professional software development.
This automated report was generated with PAReview.sh, your friendly project application review script.