Revision of https://git.drupal.org/project/google_calendar_service.git 8.x-1.x from Tue, 05/14/2019 - 17:38

Revisions allow you to track differences between multiple versions of your content, and revert back to older versions.

Review of the 8.x-1.x branch (commit 68112a1):
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: ...endor/drupal/pareviewsh/pareview_temp/google_calendar_service.module
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
    --------------------------------------------------------------------------
     67 | WARNING | Unused variable $calendar_event.
     87 | WARNING | Unused variable $calendar.
    --------------------------------------------------------------------------
    
    
    FILE: ...ndor/drupal/pareviewsh/pareview_temp/src/GoogleHttpClientFactory.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
    --------------------------------------------------------------------------
     21 | WARNING | \Drupal calls should be avoided in classes, use
        |         | dependency injection instead
     23 | WARNING | \Drupal calls should be avoided in classes, use
        |         | dependency injection instead
     27 | WARNING | \Drupal calls should be avoided in classes, use
        |         | dependency injection instead
    --------------------------------------------------------------------------
    
    
    FILE: ...or/drupal/pareviewsh/pareview_temp/src/Form/CalendarSettingsForm.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
    --------------------------------------------------------------------------
     102 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     115 | WARNING | Unused variable $file.
     116 | WARNING | Unused variable $file_real_path.
     194 | WARNING | Unused variable $file_uri.
    --------------------------------------------------------------------------
    
    
    FILE: ...vendor/drupal/pareviewsh/pareview_temp/src/Form/ImportEventsForm.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
    --------------------------------------------------------------------------
      79 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     156 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
    --------------------------------------------------------------------------
    
    
    FILE: ...endor/drupal/pareviewsh/pareview_temp/src/Form/CalendarEventForm.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     113 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
    --------------------------------------------------------------------------
    
    Time: 3.14 secs; Memory: 6Mb
    
  • No automated test cases were found, did you consider writing PHPUnit tests? This is not a requirement but encouraged for professional software development.
This automated report was generated with PAReview.sh, your friendly project application review script.

FILE: ...00000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/README.txt
--------------------------------------------------------------------------
FOUND 1 ERROR AND 5 WARNINGS AFFECTING 6 LINES
--------------------------------------------------------------------------
 14 | WARNING | [ ] Line exceeds 80 characters; contains 82 characters
 21 | WARNING | [ ] Line exceeds 80 characters; contains 82 characters
 26 | WARNING | [ ] Line exceeds 80 characters; contains 86 characters
 28 | WARNING | [ ] Line exceeds 80 characters; contains 88 characters
 38 | WARNING | [ ] Line exceeds 80 characters; contains 83 characters
 39 | ERROR   | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...dor/drupal/pareviewsh/pareview_temp/src/CalendarEventListBuilder.php
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 49 | ERROR | [x] Short array syntax must be used to define arrays
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: .../vendor/drupal/pareviewsh/pareview_temp/src/Entity/CalendarEvent.php
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 240 | ERROR | [x] Short array syntax must be used to define arrays
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...eb/vendor/drupal/pareviewsh/pareview_temp/src/CalendarEditEvents.php
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 66 | ERROR | Parameter $timezone is not described in comment
--------------------------------------------------------------------------


FILE: ...wsh/pareview_temp/src/Plugin/QueueWorker/CalendarImportProcessor.php
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 31 | ERROR | [x] Data types in @param tags need to be fully namespaced
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...01/web/vendor/drupal/pareviewsh/pareview_temp/src/CalendarImport.php
--------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 5 LINES
--------------------------------------------------------------------------
 53 | ERROR | [x] Data types in @param tags need to be fully namespaced
 55 | ERROR | [x] Data types in @param tags need to be fully namespaced
 57 | ERROR | [x] Data types in @param tags need to be fully namespaced
 59 | ERROR | [x] Data types in @param tags need to be fully namespaced
 72 | ERROR | [x] Data types in @param tags need to be fully namespaced
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...b/vendor/drupal/pareviewsh/pareview_temp/src/CalendarListBuilder.php
--------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 5 LINES
--------------------------------------------------------------------------
 40 | ERROR | [x] Short array syntax must be used to define arrays
 44 | ERROR | [x] Short array syntax must be used to define arrays
 55 | ERROR | [x] Short array syntax must be used to define arrays
 64 | ERROR | [x] Short array syntax must be used to define arrays
 73 | ERROR | [x] Short array syntax must be used to define arrays
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...pareviewsh/pareview_temp/src/Controller/CalendarImportController.php
--------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
--------------------------------------------------------------------------
 42 | ERROR | [x] Data types in @param tags need to be fully namespaced
 44 | ERROR | [x] Data types in @param tags need to be fully namespaced
 46 | ERROR | [x] Data types in @param tags need to be fully namespaced
 48 | ERROR | [x] Data types in @param tags need to be fully namespaced
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...drupal/pareviewsh/pareview_temp/src/Form/CalendarEventDeleteForm.php
--------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 4 LINES
--------------------------------------------------------------------------
 30 | ERROR | [x] Data types in @param tags need to be fully namespaced
 32 | ERROR | [x] Data types in @param tags need to be fully namespaced
 34 | ERROR | [x] Data types in @param tags need to be fully namespaced
 36 | ERROR | [x] Data types in @param tags need to be fully namespaced
 36 | ERROR | [x] Data types in @param tags need to be fully namespaced
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...or/drupal/pareviewsh/pareview_temp/src/Form/CalendarSettingsForm.php
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 36 | ERROR | Parameter $file_system is not described in comment
--------------------------------------------------------------------------


FILE: ...vendor/drupal/pareviewsh/pareview_temp/src/Form/ImportEventsForm.php
--------------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES
--------------------------------------------------------------------------
 42 | ERROR   | [x] Data types in @param tags need to be fully namespaced
 44 | ERROR   | [x] Data types in @param tags need to be fully namespaced
 88 | WARNING | [ ] Possible useless method overriding detected
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...endor/drupal/pareviewsh/pareview_temp/src/Form/CalendarEventForm.php
--------------------------------------------------------------------------
FOUND 6 ERRORS AFFECTING 5 LINES
--------------------------------------------------------------------------
 41 | ERROR | [x] Data types in @param tags need to be fully namespaced
 43 | ERROR | [x] Data types in @param tags need to be fully namespaced
 45 | ERROR | [x] Data types in @param tags need to be fully namespaced
 47 | ERROR | [x] Data types in @param tags need to be fully namespaced
 47 | ERROR | [x] Data types in @param tags need to be fully namespaced
 49 | ERROR | [x] Data types in @param tags need to be fully namespaced
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...web/vendor/drupal/pareviewsh/pareview_temp/src/Form/CalendarForm.php
--------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 5 LINES
--------------------------------------------------------------------------
 38 | ERROR | [x] Data types in @param tags need to be fully namespaced
 40 | ERROR | [x] Data types in @param tags need to be fully namespaced
 42 | ERROR | [x] Data types in @param tags need to be fully namespaced
 44 | ERROR | [x] Data types in @param tags need to be fully namespaced
 46 | ERROR | [x] Data types in @param tags need to be fully namespaced
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Time: 3.99 secs; Memory: 8Mb