Revision of https://git.drupal.org/project/google_calendar_service.git 8.x-1.x from Wed, 05/15/2019 - 21:02

Revisions allow you to track differences between multiple versions of your content, and revert back to older versions.

Review of the 8.x-1.x branch (commit 839c493):
  • PHP Parse error: syntax error, unexpected ']', expecting ',' or ')' in ./src/CalendarListBuilder.php on line 68 Errors parsing ./src/CalendarListBuilder.php
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: ...endor/drupal/pareviewsh/pareview_temp/google_calendar_service.module
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
    --------------------------------------------------------------------------
     73 | WARNING | Unused variable $calendar_event.
     93 | WARNING | Unused variable $calendar.
    --------------------------------------------------------------------------
    
    
    FILE: ...ndor/drupal/pareviewsh/pareview_temp/src/GoogleHttpClientFactory.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
    --------------------------------------------------------------------------
     21 | WARNING | \Drupal calls should be avoided in classes, use
        |         | dependency injection instead
     23 | WARNING | \Drupal calls should be avoided in classes, use
        |         | dependency injection instead
     27 | WARNING | \Drupal calls should be avoided in classes, use
        |         | dependency injection instead
    --------------------------------------------------------------------------
    
    
    FILE: ...or/drupal/pareviewsh/pareview_temp/src/Form/CalendarSettingsForm.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
    --------------------------------------------------------------------------
     108 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     128 | WARNING | Unused variable $file.
     129 | WARNING | Unused variable $file_real_path.
     209 | WARNING | Unused variable $file_uri.
    --------------------------------------------------------------------------
    
    
    FILE: ...vendor/drupal/pareviewsh/pareview_temp/src/Form/ImportEventsForm.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     162 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
    --------------------------------------------------------------------------
    
    
    FILE: ...endor/drupal/pareviewsh/pareview_temp/src/Form/CalendarEventForm.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     125 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
    --------------------------------------------------------------------------
    
    Time: 2.25 secs; Memory: 6Mb
    
  • No automated test cases were found, did you consider writing PHPUnit tests? This is not a requirement but encouraged for professional software development.
This automated report was generated with PAReview.sh, your friendly project application review script.

FILE: ...00000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/README.txt
--------------------------------------------------------------------------
FOUND 1 ERROR AND 5 WARNINGS AFFECTING 6 LINES
--------------------------------------------------------------------------
 14 | WARNING | [ ] Line exceeds 80 characters; contains 82 characters
 21 | WARNING | [ ] Line exceeds 80 characters; contains 82 characters
 26 | WARNING | [ ] Line exceeds 80 characters; contains 86 characters
 28 | WARNING | [ ] Line exceeds 80 characters; contains 88 characters
 38 | WARNING | [ ] Line exceeds 80 characters; contains 83 characters
 39 | ERROR   | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: .../vendor/drupal/pareviewsh/pareview_temp/src/Entity/CalendarEvent.php
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 252 | ERROR | [x] Short array syntax must be used to define arrays
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...eb/vendor/drupal/pareviewsh/pareview_temp/src/CalendarEditEvents.php
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 74 | ERROR | Parameter $timezone is not described in comment
--------------------------------------------------------------------------


FILE: ...wsh/pareview_temp/src/Plugin/QueueWorker/CalendarImportProcessor.php
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 32 | ERROR | [x] Data types in @param tags need to be fully namespaced
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...01/web/vendor/drupal/pareviewsh/pareview_temp/src/CalendarImport.php
--------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 5 LINES
--------------------------------------------------------------------------
 53 | ERROR | [x] Data types in @param tags need to be fully namespaced
 55 | ERROR | [x] Data types in @param tags need to be fully namespaced
 57 | ERROR | [x] Data types in @param tags need to be fully namespaced
 59 | ERROR | [x] Data types in @param tags need to be fully namespaced
 79 | ERROR | [x] Data types in @param tags need to be fully namespaced
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...drupal/pareviewsh/pareview_temp/src/CalendarAccessControlHandler.php
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 25 | ERROR | Inline doc block comments are not allowed; use "/* Comment
    |       | */" or "// Comment" instead
--------------------------------------------------------------------------


FILE: ...b/vendor/drupal/pareviewsh/pareview_temp/src/CalendarListBuilder.php
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
 67 | WARNING | [x] A comma should follow the last multiline array item.
    |         |     Found: ]
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...pareviewsh/pareview_temp/src/Controller/CalendarImportController.php
--------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
--------------------------------------------------------------------------
 42 | ERROR | [x] Data types in @param tags need to be fully namespaced
 44 | ERROR | [x] Data types in @param tags need to be fully namespaced
 46 | ERROR | [x] Data types in @param tags need to be fully namespaced
 48 | ERROR | [x] Data types in @param tags need to be fully namespaced
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...or/drupal/pareviewsh/pareview_temp/src/CalendarHtmlRouteProvider.php
--------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------
 45 | ERROR | [x] Array indentation error, expected 6 spaces but found 8
 46 | ERROR | [x] Array indentation error, expected 6 spaces but found 8
 47 | ERROR | [x] Array closing indentation error, expected 4 spaces but
    |       |     found 6
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...drupal/pareviewsh/pareview_temp/src/Form/CalendarEventDeleteForm.php
--------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 4 LINES
--------------------------------------------------------------------------
 30 | ERROR | [x] Data types in @param tags need to be fully namespaced
 32 | ERROR | [x] Data types in @param tags need to be fully namespaced
 34 | ERROR | [x] Data types in @param tags need to be fully namespaced
 36 | ERROR | [x] Data types in @param tags need to be fully namespaced
 36 | ERROR | [x] Data types in @param tags need to be fully namespaced
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...or/drupal/pareviewsh/pareview_temp/src/Form/CalendarSettingsForm.php
--------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------
  36 | ERROR | Parameter $file_system is not described in comment
 229 | ERROR | Expected type hint "array"; found "rray" for $form
--------------------------------------------------------------------------


FILE: ...vendor/drupal/pareviewsh/pareview_temp/src/Form/ImportEventsForm.php
--------------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES
--------------------------------------------------------------------------
 42 | ERROR   | [x] Data types in @param tags need to be fully namespaced
 44 | ERROR   | [x] Data types in @param tags need to be fully namespaced
 92 | WARNING | [ ] Possible useless method overriding detected
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...endor/drupal/pareviewsh/pareview_temp/src/Form/CalendarEventForm.php
--------------------------------------------------------------------------
FOUND 6 ERRORS AFFECTING 5 LINES
--------------------------------------------------------------------------
 41 | ERROR | [x] Data types in @param tags need to be fully namespaced
 43 | ERROR | [x] Data types in @param tags need to be fully namespaced
 45 | ERROR | [x] Data types in @param tags need to be fully namespaced
 47 | ERROR | [x] Data types in @param tags need to be fully namespaced
 47 | ERROR | [x] Data types in @param tags need to be fully namespaced
 49 | ERROR | [x] Data types in @param tags need to be fully namespaced
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...web/vendor/drupal/pareviewsh/pareview_temp/src/Form/CalendarForm.php
--------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 5 LINES
--------------------------------------------------------------------------
 38 | ERROR | [x] Data types in @param tags need to be fully namespaced
 40 | ERROR | [x] Data types in @param tags need to be fully namespaced
 42 | ERROR | [x] Data types in @param tags need to be fully namespaced
 44 | ERROR | [x] Data types in @param tags need to be fully namespaced
 46 | ERROR | [x] Data types in @param tags need to be fully namespaced
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Time: 3.65 secs; Memory: 8Mb