Revision of https://git.drupal.org/project/google_calendar_service.git 8.x-1.x from Wed, 05/15/2019 - 21:52

Revisions allow you to track differences between multiple versions of your content, and revert back to older versions.

Review of the 8.x-1.x branch (commit 207c3d5):
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: ...endor/drupal/pareviewsh/pareview_temp/google_calendar_service.module
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
    --------------------------------------------------------------------------
     73 | WARNING | Unused variable $calendar_event.
     93 | WARNING | Unused variable $calendar.
    --------------------------------------------------------------------------
    
    
    FILE: ...ndor/drupal/pareviewsh/pareview_temp/src/GoogleHttpClientFactory.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
    --------------------------------------------------------------------------
     21 | WARNING | \Drupal calls should be avoided in classes, use
        |         | dependency injection instead
     23 | WARNING | \Drupal calls should be avoided in classes, use
        |         | dependency injection instead
     27 | WARNING | \Drupal calls should be avoided in classes, use
        |         | dependency injection instead
    --------------------------------------------------------------------------
    
    
    FILE: ...or/drupal/pareviewsh/pareview_temp/src/Form/CalendarSettingsForm.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
    --------------------------------------------------------------------------
     108 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     128 | WARNING | Unused variable $file.
     129 | WARNING | Unused variable $file_real_path.
     209 | WARNING | Unused variable $file_uri.
    --------------------------------------------------------------------------
    
    
    FILE: ...vendor/drupal/pareviewsh/pareview_temp/src/Form/ImportEventsForm.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     162 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
    --------------------------------------------------------------------------
    
    
    FILE: ...endor/drupal/pareviewsh/pareview_temp/src/Form/CalendarEventForm.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     125 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
    --------------------------------------------------------------------------
    
    Time: 2.26 secs; Memory: 6Mb
    
  • No automated test cases were found, did you consider writing PHPUnit tests? This is not a requirement but encouraged for professional software development.
This automated report was generated with PAReview.sh, your friendly project application review script.

FILE: ...000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/README.md
--------------------------------------------------------------------------
FOUND 1 ERROR AND 3 WARNINGS AFFECTING 4 LINES
--------------------------------------------------------------------------
 27 | WARNING | [ ] Line exceeds 80 characters; contains 86 characters
 29 | WARNING | [ ] Line exceeds 80 characters; contains 88 characters
 39 | WARNING | [ ] Line exceeds 80 characters; contains 83 characters
 40 | ERROR   | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...eb/vendor/drupal/pareviewsh/pareview_temp/src/CalendarEditEvents.php
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
 183 | WARNING | The use of function dpm() is discouraged
--------------------------------------------------------------------------


FILE: ...01/web/vendor/drupal/pareviewsh/pareview_temp/src/CalendarImport.php
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 79 | ERROR | [x] Data types in @param tags need to be fully namespaced
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...b/vendor/drupal/pareviewsh/pareview_temp/src/CalendarListBuilder.php
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
 69 | WARNING | [x] A comma should follow the last multiline array item.
    |         |     Found: )
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...or/drupal/pareviewsh/pareview_temp/src/Form/CalendarSettingsForm.php
--------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------
  36 | ERROR | Parameter $file_system is not described in comment
 229 | ERROR | Expected type hint "array"; found "rray" for $form
--------------------------------------------------------------------------


FILE: ...vendor/drupal/pareviewsh/pareview_temp/src/Form/ImportEventsForm.php
--------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
--------------------------------------------------------------------------
 49 | ERROR   | Expected type hint "GoogleCalendarImport"; found
    |         | "CalendarImport" for $google_calendar_service
 92 | WARNING | Possible useless method overriding detected
--------------------------------------------------------------------------

Time: 3.94 secs; Memory: 8Mb