Revision of https://git.drupal.org/project/google_calendar_service.git 8.x-1.x from Wed, 05/15/2019 - 22:01

Revisions allow you to track differences between multiple versions of your content, and revert back to older versions.

Review of the 8.x-1.x branch (commit ccb6879):
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards).
    
    FILE: ...000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/README.md
    --------------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    --------------------------------------------------------------------------
     41 | ERROR | [x] Expected 1 newline at end of file; 0 found
    --------------------------------------------------------------------------
    PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    --------------------------------------------------------------------------
    
    Time: 3.99 secs; Memory: 8Mb
    
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: ...endor/drupal/pareviewsh/pareview_temp/google_calendar_service.module
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
    --------------------------------------------------------------------------
     73 | WARNING | Unused variable $calendar_event.
     93 | WARNING | Unused variable $calendar.
    --------------------------------------------------------------------------
    
    
    FILE: ...ndor/drupal/pareviewsh/pareview_temp/src/GoogleHttpClientFactory.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
    --------------------------------------------------------------------------
     21 | WARNING | \Drupal calls should be avoided in classes, use
        |         | dependency injection instead
     23 | WARNING | \Drupal calls should be avoided in classes, use
        |         | dependency injection instead
     27 | WARNING | \Drupal calls should be avoided in classes, use
        |         | dependency injection instead
    --------------------------------------------------------------------------
    
    
    FILE: ...or/drupal/pareviewsh/pareview_temp/src/Form/CalendarSettingsForm.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
    --------------------------------------------------------------------------
     117 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     137 | WARNING | Unused variable $file.
     138 | WARNING | Unused variable $file_real_path.
     218 | WARNING | Unused variable $file_uri.
    --------------------------------------------------------------------------
    
    
    FILE: ...endor/drupal/pareviewsh/pareview_temp/src/Form/CalendarEventForm.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     125 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
    --------------------------------------------------------------------------
    
    Time: 2.25 secs; Memory: 6Mb
    
  • No automated test cases were found, did you consider writing PHPUnit tests? This is not a requirement but encouraged for professional software development.
This automated report was generated with PAReview.sh, your friendly project application review script.