https://git.drupal.org/project/groupmediaplus.git 8.x-1.x

Primary tabs

Git errors: Review of the 8.x-1.x branch (commit 8b7b888):
  • README.md or README.txt is missing, see the guidelines for in-project documentation.
  • The groupmediaplus_upload.module does not implement hook_help(). See https://www.drupal.org/docs/develop/documenting-your-project/module-docu... .
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: ...ew_temp/modules/groupmediaplus_upload/groupmediaplus_upload.info.yml
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
    --------------------------------------------------------------------------
     7 | WARNING | All dependencies must be prefixed with the project name,
       |         | for example "drupal:"
     8 | WARNING | All dependencies must be prefixed with the project name,
       |         | for example "drupal:"
     9 | WARNING | All dependencies must be prefixed with the project name,
       |         | for example "drupal:"
    --------------------------------------------------------------------------
    
    
    FILE: ...1/web/vendor/drupal/pareviewsh/pareview_temp/groupmediaplus.info.yml
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     7 | WARNING | All dependencies must be prefixed with the project name,
       |         | for example "drupal:"
    --------------------------------------------------------------------------
    
    Time: 353ms; Memory: 4Mb
    
  • No automated test cases were found, did you consider writing PHPUnit tests? This is not a requirement but encouraged for professional software development.
This automated report was generated with PAReview.sh, your friendly project application review script.

FILE: ...view_temp/modules/groupmediaplus_upload/groupmediaplus_upload.module
--------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
--------------------------------------------------------------------------
  9 | WARNING | [x] Unused use statement
 15 | ERROR   | [x] Namespaced classes/interfaces/traits should be
    |         |     referenced with use statements
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...wsh/pareview_temp/modules/groupmediaplus_upload/src/SubmitStatus.php
--------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
--------------------------------------------------------------------------
  7 | ERROR | [x] Missing class doc comment
 11 | ERROR | [x] Missing function doc comment
 15 | ERROR | [x] Missing function doc comment
 19 | ERROR | [x] Missing function doc comment
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...pareviewsh/pareview_temp/modules/groupmediaplus_upload/src/Hooks.php
--------------------------------------------------------------------------
FOUND 6 ERRORS AND 1 WARNING AFFECTING 7 LINES
--------------------------------------------------------------------------
 11 | WARNING | [x] Unused use statement
 15 | ERROR   | [x] Missing class doc comment
 17 | ERROR   | [x] Missing function doc comment
 34 | ERROR   | [x] Missing function doc comment
 40 | ERROR   | [x] Missing function doc comment
 41 | ERROR   | [x] A cast statement must be followed by a single space
 61 | ERROR   | [x] Separate the @param and @return sections by a blank
    |         |     line.
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 7 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...01/web/vendor/drupal/pareviewsh/pareview_temp/src/GroupMediaPlus.php
--------------------------------------------------------------------------
FOUND 8 ERRORS AFFECTING 8 LINES
--------------------------------------------------------------------------
 10 | ERROR | [x] Missing class doc comment
 12 | ERROR | [ ] Missing short description in doc comment
 13 | ERROR | [ ] Missing parameter comment
 14 | ERROR | [ ] Missing parameter comment
 15 | ERROR | [ ] Missing parameter comment
 16 | ERROR | [ ] Description for the @return value is missing
 18 | ERROR | [ ] Type hint "array" missing for $entityTypeIds
 44 | ERROR | [x] Missing function doc comment
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...view_temp/src/Plugin/views/argument_default/GroupIdsFromNodePath.php
--------------------------------------------------------------------------
FOUND 13 ERRORS AND 1 WARNING AFFECTING 9 LINES
--------------------------------------------------------------------------
 21 | ERROR   | [x] The open comment tag must be the only content on the
    |         |     line
 21 | ERROR   | [ ] Missing short description in doc comment
 21 | ERROR   | [x] Expected "\Drupal\token\TokenInterface" but found
    |         |     "\Drupal\token\TokenInterface " for @var tag in
    |         |     member variable comment
 26 | ERROR   | [x] There must be exactly one blank line before the tags
    |         |     in a doc comment
 26 | ERROR   | [ ] Missing parameter comment
 27 | ERROR   | [ ] Missing parameter comment
 27 | ERROR   | [ ] Missing parameter type
 28 | ERROR   | [ ] Missing parameter comment
 28 | ERROR   | [ ] Missing parameter type
 29 | ERROR   | [ ] Missing parameter comment
 46 | ERROR   | [x] Expected 1 blank line after function; 2 found
 49 | ERROR   | [ ] Missing short description in doc comment
 60 | ERROR   | [ ] Missing short description in doc comment
 80 | WARNING | [ ] Avoid backslash escaping in translatable strings when
    |         |     possible, use "" quotes instead
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Time: 835ms; Memory: 4Mb