https://git.drupal.org/project/honeypot.git

Primary tabs

Review of the 8.x-1.x branch (commit 6dc04df):
  • Your README.md does not follow best practices (headings need to be uppercase). See https://www.drupal.org/node/2181737 .
    • The INTRODUCTION section is missing.
    • The REQUIREMENTS section is missing.
    • The INSTALLATION section is missing.
    • The CONFIGURATION section is missing.
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: ...reviewsh/pareview_temp/src/Controller/HoneypotSettingsController.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     225 | WARNING | NodeType::loadMultiple calls should be avoided in
         |         | classes, use dependency injection instead
    --------------------------------------------------------------------------
    
    Time: 1.48 secs; Memory: 6Mb
    
This automated report was generated with PAReview.sh, your friendly project application review script.

FILE: ...000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/README.md
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 7 WARNINGS AFFECTING 7 LINES
--------------------------------------------------------------------------
  4 | WARNING | Line exceeds 80 characters; contains 138 characters
 43 | WARNING | Line exceeds 80 characters; contains 153 characters
 45 | WARNING | Line exceeds 80 characters; contains 83 characters
 46 | WARNING | Line exceeds 80 characters; contains 93 characters
 57 | WARNING | Line exceeds 80 characters; contains 83 characters
 63 | WARNING | Line exceeds 80 characters; contains 182 characters
 66 | WARNING | Line exceeds 80 characters; contains 112 characters
--------------------------------------------------------------------------


FILE: ...site1101/web/vendor/drupal/pareviewsh/pareview_temp/honeypot.install
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
 9 | WARNING | [x] Unused use statement
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: .../site1101/web/vendor/drupal/pareviewsh/pareview_temp/honeypot.module
--------------------------------------------------------------------------
FOUND 5 ERRORS AND 1 WARNING AFFECTING 4 LINES
--------------------------------------------------------------------------
  26 | WARNING | [ ] Avoid backslash escaping in translatable strings
     |         |     when possible, use "" quotes instead
 144 | ERROR   | [ ] Key specified for array entry; first entry has no
     |         |     key
 172 | ERROR   | [x] Expected 1 space before "*"; 0 found
 172 | ERROR   | [x] Expected 1 space after "*"; 0 found
 243 | ERROR   | [x] Expected 1 space before "*"; 0 found
 243 | ERROR   | [x] Expected 1 space after "*"; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Time: 2.97 secs; Memory: 6Mb