Revision of https://git.drupal.org/project/html_importer from Tue, 12/03/2019 - 02:41

Revisions allow you to track differences between multiple versions of your content, and revert back to older versions.

Git errors: Review of the dev branch (commit e3495ef):
  • Your README.txt does not follow best practices (headings need to be uppercase). See https://www.drupal.org/node/2181737 .
    • The INTRODUCTION section is missing.
    • The REQUIREMENTS section is missing.
    • The INSTALLATION section is missing.
    • The CONFIGURATION section is missing.
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards).
    
    FILE: ...00000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/README.txt
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
    --------------------------------------------------------------------------
      5 | WARNING | Line exceeds 80 characters; contains 91 characters
     10 | WARNING | Line exceeds 80 characters; contains 87 characters
     11 | WARNING | Line exceeds 80 characters; contains 84 characters
    --------------------------------------------------------------------------
    
    Time: 1.04 secs; Memory: 4Mb
    
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: ...areviewsh/pareview_temp/src/Controller/ListImportNodesController.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     92 | WARNING | \Drupal calls should be avoided in classes, use
        |         | dependency injection instead
    --------------------------------------------------------------------------
    
    
    FILE: ...areview_temp/src/Controller/NodeCreationBatchOperationController.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 6 WARNINGS AFFECTING 6 LINES
    --------------------------------------------------------------------------
     45 | WARNING | \Drupal calls should be avoided in classes, use
        |         | dependency injection instead
     54 | WARNING | \Drupal calls should be avoided in classes, use
        |         | dependency injection instead
     55 | WARNING | t() calls should be avoided in classes, use dependency
        |         | injection and $this->t() instead
     64 | WARNING | Unused variable $message_type.
     65 | WARNING | \Drupal calls should be avoided in classes, use
        |         | dependency injection instead
     66 | WARNING | t() calls should be avoided in classes, use dependency
        |         | injection and $this->t() instead
    --------------------------------------------------------------------------
    
    
    FILE: ...b/vendor/drupal/pareviewsh/pareview_temp/src/Form/ImportHtmlForm.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
    --------------------------------------------------------------------------
     137 | WARNING | Unused variable $result.
     145 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
    --------------------------------------------------------------------------
    
    
    FILE: ...rupal/pareviewsh/pareview_temp/src/Form/DeleteHtmlImportFileForm.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     73 | WARNING | Unused variable $key.
    --------------------------------------------------------------------------
    
    Time: 532ms; Memory: 4Mb
    
  • No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.
This automated report was generated with PAReview.sh, your friendly project application review script.