Revision of https://git.drupal.org/project/hypothesis.git from Wed, 01/09/2019 - 17:22

Revisions allow you to track differences between multiple versions of your content, and revert back to older versions.

Review of the 7.x-1.x branch (commit 45bc92f):
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • ESLint has found some issues with your code (please check the JavaScript coding standards).
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/showdefaults.js: line 10, col 63, Error - There should be no space before ','. (comma-spacing)
    
    1 problem
    
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: ...ite1101/web/vendor/drupal/pareviewsh/pareview_temp/hypothesis.module
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
    --------------------------------------------------------------------------
     30 | WARNING | Do not use drupal_add_js() in hook_init(), use #attached
        |         | for CSS and JS in your page/form callback or in
        |         | hook_page_build() instead
     31 | WARNING | Do not use drupal_add_js() in hook_init(), use #attached
        |         | for CSS and JS in your page/form callback or in
        |         | hook_page_build() instead
     35 | WARNING | Do not use drupal_add_js() in hook_init(), use #attached
        |         | for CSS and JS in your page/form callback or in
        |         | hook_page_build() instead
    --------------------------------------------------------------------------
    
    Time: 279ms; Memory: 4Mb
    
  • No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.
This automated report was generated with PAReview.sh, your friendly project application review script.

FILE: ...ite1101/web/vendor/drupal/pareviewsh/pareview_temp/hypothesis.module
--------------------------------------------------------------------------
FOUND 27 ERRORS AND 3 WARNINGS AFFECTING 28 LINES
--------------------------------------------------------------------------
   1 | ERROR   | [x] The PHP open tag must be followed by exactly one
     |         |     blank line
  30 | ERROR   | [x] Whitespace found at end of line
  37 | ERROR   | [x] Expected 1 blank line after function; 0 found
  39 | ERROR   | [x] Whitespace found at end of line
  40 | ERROR   | [x] Doc comment short description must be on the first
     |         |     line
  51 | ERROR   | [ ] Missing short description in doc comment
  52 | ERROR   | [x] Whitespace found at end of line
  53 | ERROR   | [ ] Missing parameter comment
  53 | ERROR   | [x] Expected "mixed" but found "type" for parameter type
  54 | ERROR   | [ ] Missing parameter comment
  54 | ERROR   | [x] Expected "mixed" but found "type" for parameter type
  62 | ERROR   | [x] Whitespace found at end of line
  64 | ERROR   | [x] Spaces must be used to indent lines; tabs are not
     |         |     allowed
  65 | ERROR   | [x] Spaces must be used to indent lines; tabs are not
     |         |     allowed
  66 | ERROR   | [x] Spaces must be used to indent lines; tabs are not
     |         |     allowed
  69 | ERROR   | [x] Spaces must be used to indent lines; tabs are not
     |         |     allowed
  70 | ERROR   | [x] Spaces must be used to indent lines; tabs are not
     |         |     allowed
  71 | ERROR   | [x] Spaces must be used to indent lines; tabs are not
     |         |     allowed
 100 | ERROR   | [ ] If the line declaring an array spans longer than 80
     |         |     characters, each element should be broken into its
     |         |     own line
 103 | ERROR   | [x] Whitespace found at end of line
 110 | ERROR   | [x] Whitespace found at end of line
 142 | ERROR   | [x] Doc comment short description must be on the first
     |         |     line
 158 | ERROR   | [x] Missing function doc comment
 187 | ERROR   | [x] Doc comment short description must be on the first
     |         |     line
 192 | WARNING | [ ] Line exceeds 80 characters; contains 84 characters
 193 | WARNING | [ ] Line exceeds 80 characters; contains 84 characters
 212 | ERROR   | [x] Inline comments must end in full-stops, exclamation
     |         |     marks, colons, question marks, or closing
     |         |     parentheses
 221 | WARNING | [ ] Line exceeds 80 characters; contains 82 characters
 232 | ERROR   | [x] No space found before comment text; expected "//
     |         |     Check which content types hypothesis should display
     |         |     on." but found "//Check which content types
     |         |     hypothesis should display on."
 253 | ERROR   | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 23 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Time: 645ms; Memory: 6Mb