Revision of https://git.drupal.org/project/ik_constant_contact from Mon, 08/05/2019 - 20:31

Revisions allow you to track differences between multiple versions of your content, and revert back to older versions.

Review of the 8.x-1.x branch (commit ab01104):
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: ...l/pareviewsh/pareview_temp/src/Plugin/Block/ConstantContactBlock.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     97 | WARNING | \Drupal calls should be avoided in classes, use
        |         | dependency injection instead
    --------------------------------------------------------------------------
    
    
    FILE: ...r/drupal/pareviewsh/pareview_temp/src/Form/ConstantContactConfig.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
    --------------------------------------------------------------------------
     75 | WARNING | \Drupal calls should be avoided in classes, use
        |         | dependency injection instead
     76 | WARNING | \Drupal calls should be avoided in classes, use
        |         | dependency injection instead
     82 | WARNING | \Drupal calls should be avoided in classes, use
        |         | dependency injection instead
     89 | WARNING | \Drupal calls should be avoided in classes, use
        |         | dependency injection instead
    --------------------------------------------------------------------------
    
    Time: 1.11 secs; Memory: 6Mb
    
  • No automated test cases were found, did you consider writing PHPUnit tests? This is not a requirement but encouraged for professional software development.
This automated report was generated with PAReview.sh, your friendly project application review script.

FILE: ...000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/README.md
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 12 WARNINGS AFFECTING 12 LINES
--------------------------------------------------------------------------
  3 | WARNING | Line exceeds 80 characters; contains 188 characters
  7 | WARNING | Line exceeds 80 characters; contains 426 characters
  9 | WARNING | Line exceeds 80 characters; contains 115 characters
 11 | WARNING | Line exceeds 80 characters; contains 154 characters
 20 | WARNING | Line exceeds 80 characters; contains 199 characters
 24 | WARNING | Line exceeds 80 characters; contains 195 characters
 29 | WARNING | Line exceeds 80 characters; contains 116 characters
 31 | WARNING | Line exceeds 80 characters; contains 81 characters
 41 | WARNING | Line exceeds 80 characters; contains 144 characters
 42 | WARNING | Line exceeds 80 characters; contains 125 characters
 43 | WARNING | Line exceeds 80 characters; contains 174 characters
 47 | WARNING | Line exceeds 80 characters; contains 93 characters
--------------------------------------------------------------------------


FILE: ...h/pareview_temp/src/Plugin/rest/resource/ConstantContactResource.php
--------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
--------------------------------------------------------------------------
 25 | WARNING | Line exceeds 80 characters; contains 82 characters
 36 | ERROR   | Type hint "array" missing for $data
--------------------------------------------------------------------------


FILE: ...rupal/pareviewsh/pareview_temp/src/Form/ConstantContactBlockForm.php
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
--------------------------------------------------------------------------
  12 | WARNING | Line exceeds 80 characters; contains 90 characters
  94 | WARNING | Possible useless method overriding detected
 133 | WARNING | Only string literals should be passed to t() where
     |         | possible
--------------------------------------------------------------------------


FILE: ...r/drupal/pareviewsh/pareview_temp/src/Form/ConstantContactConfig.php
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
--------------------------------------------------------------------------
  69 | WARNING | Translatable strings must not begin or end with white
     |         | spaces, use placeholders with t() for variables
 121 | WARNING | Possible useless method overriding detected
--------------------------------------------------------------------------


FILE: ...or/drupal/pareviewsh/pareview_temp/src/Form/ConstantContactLists.php
--------------------------------------------------------------------------
FOUND 2 ERRORS AND 2 WARNINGS AFFECTING 3 LINES
--------------------------------------------------------------------------
 56 | WARNING | Translatable strings must not begin or end with white
    |         | spaces, use placeholders with t() for variables
 56 | ERROR   | Concatenating translatable strings is not allowed, use
    |         | placeholders instead and only one string literal
 70 | WARNING | Possible useless method overriding detected
 82 | ERROR   | is_integer() is a function name alias, use is_int()
    |         | instead
--------------------------------------------------------------------------


FILE: ...1/web/vendor/drupal/pareviewsh/pareview_temp/src/ConstantContact.php
--------------------------------------------------------------------------
FOUND 51 ERRORS AFFECTING 31 LINES
--------------------------------------------------------------------------
  55 | ERROR | Parameter tags must be defined first in a doc comment
  55 | ERROR | Missing parameter comment
  56 | ERROR | Missing parameter comment
  58 | ERROR | If there is no return value for a function, there must not
     |       | be a @return tag.
  58 | ERROR | Description for the @return value is missing
  60 | ERROR | Type hint "array" missing for $data
  60 | ERROR | Type hint "[string]" missing for $listID
 104 | ERROR | Parameter tags must be defined first in a doc comment
 104 | ERROR | Missing parameter comment
 106 | ERROR | If there is no return value for a function, there must not
     |       | be a @return tag.
 106 | ERROR | Description for the @return value is missing
 108 | ERROR | Type hint "array" missing for $data
 142 | ERROR | If there is no return value for a function, there must not
     |       | be a @return tag.
 142 | ERROR | Description for the @return value is missing
 197 | ERROR | Parameter tags must be defined first in a doc comment
 197 | ERROR | Missing parameter comment
 198 | ERROR | Missing parameter comment
 200 | ERROR | If there is no return value for a function, there must not
     |       | be a @return tag.
 200 | ERROR | Description for the @return value is missing
 202 | ERROR | Type hint "[string]" missing for $endpoint
 202 | ERROR | Type hint "[string]" missing for $email
 236 | ERROR | Missing parameter comment
 237 | ERROR | Missing parameter comment
 239 | ERROR | Description for the @return value must be on the next line
 241 | ERROR | Type hint "[object]" missing for $response
 241 | ERROR | Type hint "[string]" missing for $method
 266 | ERROR | Doc comment short description must be on a single line,
     |       | further text should be a separate paragraph
 268 | ERROR | Missing parameter comment
 269 | ERROR | Missing parameter comment
 271 | ERROR | If there is no return value for a function, there must not
     |       | be a @return tag.
 271 | ERROR | Description for the @return value is missing
 273 | ERROR | Type hint "array" missing for $data
 273 | ERROR | Type hint "[string]" missing for $listID
 343 | ERROR | Parameter tags must be defined first in a doc comment
 343 | ERROR | Missing parameter comment
 344 | ERROR | Missing parameter comment
 345 | ERROR | Missing parameter comment
 347 | ERROR | If there is no return value for a function, there must not
     |       | be a @return tag.
 347 | ERROR | Description for the @return value is missing
 352 | ERROR | Type hint "array" missing for $contact
 352 | ERROR | Type hint "array" missing for $data
 352 | ERROR | Type hint "[string]" missing for $listID
 447 | ERROR | Parameter tags must be defined first in a doc comment
 447 | ERROR | Missing parameter comment
 448 | ERROR | Missing parameter comment
 449 | ERROR | Missing parameter comment
 451 | ERROR | If there is no return value for a function, there must not
     |       | be a @return tag.
 451 | ERROR | Description for the @return value is missing
 453 | ERROR | Type hint "array" missing for $data
 453 | ERROR | Type hint "[object]" missing for $contact
 453 | ERROR | Type hint "[string]" missing for $listID
--------------------------------------------------------------------------

Time: 2.02 secs; Memory: 6Mb