Revision of https://git.drupal.org/project/ik_constant_contact from Mon, 08/05/2019 - 21:32

Revisions allow you to track differences between multiple versions of your content, and revert back to older versions.

Review of the 8.x-1.x branch (commit 963f45d):
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: ...l/pareviewsh/pareview_temp/src/Plugin/Block/ConstantContactBlock.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     97 | WARNING | \Drupal calls should be avoided in classes, use
        |         | dependency injection instead
    --------------------------------------------------------------------------
    
    
    FILE: ...r/drupal/pareviewsh/pareview_temp/src/Form/ConstantContactConfig.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
    --------------------------------------------------------------------------
     75 | WARNING | \Drupal calls should be avoided in classes, use
        |         | dependency injection instead
     76 | WARNING | \Drupal calls should be avoided in classes, use
        |         | dependency injection instead
     82 | WARNING | \Drupal calls should be avoided in classes, use
        |         | dependency injection instead
     89 | WARNING | \Drupal calls should be avoided in classes, use
        |         | dependency injection instead
    --------------------------------------------------------------------------
    
    Time: 1.42 secs; Memory: 6Mb
    
  • No automated test cases were found, did you consider writing PHPUnit tests? This is not a requirement but encouraged for professional software development.
This automated report was generated with PAReview.sh, your friendly project application review script.

FILE: ...000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/README.md
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 12 WARNINGS AFFECTING 12 LINES
--------------------------------------------------------------------------
  3 | WARNING | Line exceeds 80 characters; contains 188 characters
  7 | WARNING | Line exceeds 80 characters; contains 426 characters
  9 | WARNING | Line exceeds 80 characters; contains 115 characters
 11 | WARNING | Line exceeds 80 characters; contains 154 characters
 20 | WARNING | Line exceeds 80 characters; contains 199 characters
 24 | WARNING | Line exceeds 80 characters; contains 195 characters
 29 | WARNING | Line exceeds 80 characters; contains 116 characters
 31 | WARNING | Line exceeds 80 characters; contains 81 characters
 41 | WARNING | Line exceeds 80 characters; contains 144 characters
 42 | WARNING | Line exceeds 80 characters; contains 125 characters
 43 | WARNING | Line exceeds 80 characters; contains 174 characters
 47 | WARNING | Line exceeds 80 characters; contains 93 characters
--------------------------------------------------------------------------


FILE: ...h/pareview_temp/src/Plugin/rest/resource/ConstantContactResource.php
--------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
--------------------------------------------------------------------------
 25 | WARNING | Line exceeds 80 characters; contains 82 characters
 36 | ERROR   | Type hint "array" missing for $data
--------------------------------------------------------------------------


FILE: ...rupal/pareviewsh/pareview_temp/src/Form/ConstantContactBlockForm.php
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
 12 | WARNING | Line exceeds 80 characters; contains 90 characters
--------------------------------------------------------------------------


FILE: ...r/drupal/pareviewsh/pareview_temp/src/Form/ConstantContactConfig.php
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
 69 | WARNING | Translatable strings must not begin or end with white
    |         | spaces, use placeholders with t() for variables
--------------------------------------------------------------------------


FILE: ...1/web/vendor/drupal/pareviewsh/pareview_temp/src/ConstantContact.php
--------------------------------------------------------------------------
FOUND 58 ERRORS AND 5 WARNINGS AFFECTING 48 LINES
--------------------------------------------------------------------------
  26 | ERROR   | [x] Whitespace found at end of line
  28 | ERROR   | [x] Return comment indentation must be 3 spaces, found 2
     |         |     spaces
  58 | ERROR   | [ ] Parameter tags must be defined first in a doc
     |         |     comment
  58 | ERROR   | [ ] Missing parameter comment
  59 | ERROR   | [ ] Missing parameter comment
  61 | ERROR   | [ ] If there is no return value for a function, there
     |         |     must not be a @return tag.
  61 | ERROR   | [ ] Description for the @return value is missing
  63 | ERROR   | [ ] Type hint "array" missing for $data
  63 | ERROR   | [ ] Type hint "[string]" missing for $listID
 107 | ERROR   | [ ] Parameter tags must be defined first in a doc
     |         |     comment
 108 | ERROR   | [x] Parameter comment indentation must be 3 spaces,
     |         |     found 4 spaces
 111 | ERROR   | [x] Return comment indentation must be 3 spaces, found 4
     |         |     spaces
 111 | WARNING | [ ] Line exceeds 80 characters; contains 105 characters
 113 | ERROR   | [ ] Type hint "array" missing for $data
 148 | ERROR   | [x] Return comment indentation must be 3 spaces, found 4
     |         |     spaces
 200 | WARNING | [ ] Line exceeds 80 characters; contains 112 characters
 200 | ERROR   | [ ] Doc comment short description must be on a single
     |         |     line, further text should be a separate paragraph
 204 | ERROR   | [ ] Parameter tags must be defined first in a doc
     |         |     comment
 205 | ERROR   | [x] Parameter comment indentation must be 3 spaces,
     |         |     found 4 spaces
 207 | ERROR   | [x] Parameter comment indentation must be 3 spaces,
     |         |     found 4 spaces
 210 | ERROR   | [x] Return comment indentation must be 3 spaces, found 4
     |         |     spaces
 247 | ERROR   | [x] Parameter comment indentation must be 3 spaces,
     |         |     found 4 spaces
 248 | ERROR   | [x] Whitespace found at end of line
 248 | ERROR   | [x] Parameter comment must be on the next line
 249 | ERROR   | [x] Parameter comment indentation must be 3 spaces,
     |         |     found 4 spaces
 252 | ERROR   | [x] Return comment indentation must be 3 spaces, found 4
     |         |     spaces
 252 | WARNING | [ ] Line exceeds 80 characters; contains 120 characters
 253 | ERROR   | [x] Whitespace found at end of line
 280 | ERROR   | [ ] Doc comment short description must be on a single
     |         |     line, further text should be a separate paragraph
 283 | ERROR   | [x] Parameter comment indentation must be 3 spaces,
     |         |     found 4 spaces
 283 | WARNING | [ ] Line exceeds 80 characters; contains 126 characters
 285 | ERROR   | [x] Parameter comment indentation must be 3 spaces,
     |         |     found 4 spaces
 288 | ERROR   | [x] Return comment indentation must be 3 spaces, found 4
     |         |     spaces
 288 | WARNING | [ ] Line exceeds 80 characters; contains 92 characters
 289 | ERROR   | [x] Expected 1 space after asterisk; 4 found
 289 | ERROR   | [x] Separate the @return and @see sections by a blank
     |         |     line.
 290 | ERROR   | [x] Expected 1 space after asterisk; 4 found
 291 | ERROR   | [x] Expected 1 space after asterisk; 4 found
 292 | ERROR   | [x] Whitespace found at end of line
 293 | ERROR   | [x] Additional blank lines found at end of doc comment
 294 | ERROR   | [ ] Type hint "array" missing for $data
 364 | ERROR   | [ ] Parameter tags must be defined first in a doc
     |         |     comment
 365 | ERROR   | [x] Parameter comment indentation must be 3 spaces,
     |         |     found 4 spaces
 367 | ERROR   | [x] Parameter comment indentation must be 3 spaces,
     |         |     found 4 spaces
 367 | ERROR   | [x] Parameter comment must end with a full stop
 369 | ERROR   | [x] Parameter comment indentation must be 3 spaces,
     |         |     found 4 spaces
 374 | ERROR   | [ ] Type hint "array" missing for $contact
 374 | ERROR   | [ ] Type hint "array" missing for $data
 442 | ERROR   | [x] Whitespace found at end of line
 444 | ERROR   | [x] Parameter comment indentation must be 3 spaces,
     |         |     found 4 spaces
 444 | ERROR   | [x] Parameter comment must end with a full stop
 446 | ERROR   | [ ] Type hint "array" missing for $data
 453 | ERROR   | [x] There must be exactly one blank line before the tags
     |         |     in a doc comment
 454 | ERROR   | [x] Whitespace found at end of line
 455 | ERROR   | [ ] Parameter tags must be defined first in a doc
     |         |     comment
 456 | ERROR   | [x] Parameter comment indentation must be 3 spaces,
     |         |     found 4 spaces
 456 | ERROR   | [x] Whitespace found at end of line
 456 | ERROR   | [x] Parameter comment must end with a full stop
 476 | ERROR   | [ ] Parameter tags must be defined first in a doc
     |         |     comment
 477 | ERROR   | [x] Parameter comment indentation must be 3 spaces,
     |         |     found 5 spaces
 479 | ERROR   | [x] Parameter comment indentation must be 3 spaces,
     |         |     found 4 spaces
 481 | ERROR   | [x] Parameter comment indentation must be 3 spaces,
     |         |     found 4 spaces
 483 | ERROR   | [ ] Type hint "array" missing for $data
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 38 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Time: 1.79 secs; Memory: 6Mb