Revision of https://git.drupal.org/project/ik_constant_contact from Mon, 08/05/2019 - 21:41

Revisions allow you to track differences between multiple versions of your content, and revert back to older versions.

Review of the 8.x-1.x branch (commit 2539ab1):
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: ...l/pareviewsh/pareview_temp/src/Plugin/Block/ConstantContactBlock.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     97 | WARNING | \Drupal calls should be avoided in classes, use
        |         | dependency injection instead
    --------------------------------------------------------------------------
    
    
    FILE: ...r/drupal/pareviewsh/pareview_temp/src/Form/ConstantContactConfig.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
    --------------------------------------------------------------------------
     75 | WARNING | \Drupal calls should be avoided in classes, use
        |         | dependency injection instead
     76 | WARNING | \Drupal calls should be avoided in classes, use
        |         | dependency injection instead
     82 | WARNING | \Drupal calls should be avoided in classes, use
        |         | dependency injection instead
     89 | WARNING | \Drupal calls should be avoided in classes, use
        |         | dependency injection instead
    --------------------------------------------------------------------------
    
    Time: 1.61 secs; Memory: 6Mb
    
  • No automated test cases were found, did you consider writing PHPUnit tests? This is not a requirement but encouraged for professional software development.
This automated report was generated with PAReview.sh, your friendly project application review script.

FILE: ...000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/README.md
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 16 WARNINGS AFFECTING 16 LINES
--------------------------------------------------------------------------
  3 | WARNING | Line exceeds 80 characters; contains 101 characters
  4 | WARNING | Line exceeds 80 characters; contains 86 characters
  8 | WARNING | Line exceeds 80 characters; contains 93 characters
  9 | WARNING | Line exceeds 80 characters; contains 104 characters
 10 | WARNING | Line exceeds 80 characters; contains 93 characters
 11 | WARNING | Line exceeds 80 characters; contains 84 characters
 14 | WARNING | Line exceeds 80 characters; contains 115 characters
 17 | WARNING | Line exceeds 80 characters; contains 90 characters
 26 | WARNING | Line exceeds 80 characters; contains 87 characters
 27 | WARNING | Line exceeds 80 characters; contains 111 characters
 32 | WARNING | Line exceeds 80 characters; contains 126 characters
 37 | WARNING | Line exceeds 80 characters; contains 116 characters
 39 | WARNING | Line exceeds 80 characters; contains 81 characters
 53 | WARNING | Line exceeds 80 characters; contains 84 characters
 54 | WARNING | Line exceeds 80 characters; contains 89 characters
 58 | WARNING | Line exceeds 80 characters; contains 93 characters
--------------------------------------------------------------------------


FILE: ...h/pareview_temp/src/Plugin/rest/resource/ConstantContactResource.php
--------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------
 26 | ERROR | Doc comment short description must be on a single line,
    |       | further text should be a separate paragraph
 37 | ERROR | Type hint "array" missing for $data
--------------------------------------------------------------------------


FILE: ...1/web/vendor/drupal/pareviewsh/pareview_temp/src/ConstantContact.php
--------------------------------------------------------------------------
FOUND 9 ERRORS AND 5 WARNINGS AFFECTING 12 LINES
--------------------------------------------------------------------------
  65 | ERROR   | Type hint "array" missing for $data
 111 | WARNING | Line exceeds 80 characters; contains 104 characters
 115 | ERROR   | Type hint "array" missing for $data
 202 | WARNING | Line exceeds 80 characters; contains 112 characters
 202 | ERROR   | Doc comment short description must be on a single line,
     |         | further text should be a separate paragraph
 254 | WARNING | Line exceeds 80 characters; contains 119 characters
 282 | ERROR   | Doc comment short description must be on a single line,
     |         | further text should be a separate paragraph
 285 | WARNING | Line exceeds 80 characters; contains 125 characters
 290 | WARNING | Line exceeds 80 characters; contains 91 characters
 296 | ERROR   | Type hint "array" missing for $data
 376 | ERROR   | Type hint "array" missing for $contact
 376 | ERROR   | Type hint "array" missing for $data
 448 | ERROR   | Type hint "array" missing for $data
 486 | ERROR   | Type hint "array" missing for $data
--------------------------------------------------------------------------

Time: 1.79 secs; Memory: 6Mb