Revision of https://git.drupal.org/project/ik_constant_contact from Mon, 08/05/2019 - 21:58

Revisions allow you to track differences between multiple versions of your content, and revert back to older versions.

Review of the 8.x-1.x branch (commit 9eb3942):
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: ...l/pareviewsh/pareview_temp/src/Plugin/Block/ConstantContactBlock.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     97 | WARNING | \Drupal calls should be avoided in classes, use
        |         | dependency injection instead
    --------------------------------------------------------------------------
    
    
    FILE: ...r/drupal/pareviewsh/pareview_temp/src/Form/ConstantContactConfig.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
    --------------------------------------------------------------------------
     75 | WARNING | \Drupal calls should be avoided in classes, use
        |         | dependency injection instead
     76 | WARNING | \Drupal calls should be avoided in classes, use
        |         | dependency injection instead
     82 | WARNING | \Drupal calls should be avoided in classes, use
        |         | dependency injection instead
     89 | WARNING | \Drupal calls should be avoided in classes, use
        |         | dependency injection instead
    --------------------------------------------------------------------------
    
    Time: 1.19 secs; Memory: 6Mb
    
  • No automated test cases were found, did you consider writing PHPUnit tests? This is not a requirement but encouraged for professional software development.
This automated report was generated with PAReview.sh, your friendly project application review script.

FILE: ...l/pareviewsh/pareview_temp/src/Plugin/Block/ConstantContactBlock.php
--------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
 70 | WARNING | [ ] Line exceeds 80 characters; contains 93 characters
 70 | ERROR   | [x] Inline comments must end in full-stops, exclamation
    |         |     marks, colons, question marks, or closing parentheses
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...1/web/vendor/drupal/pareviewsh/pareview_temp/src/ConstantContact.php
--------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
--------------------------------------------------------------------------
 297 | WARNING | Line exceeds 80 characters; contains 91 characters
 468 | ERROR   | Unknown type hint "object" found for $data
--------------------------------------------------------------------------

Time: 1.69 secs; Memory: 6Mb