Revision of https://git.drupal.org/project/ik_constant_contact from Fri, 11/08/2019 - 02:50

Revisions allow you to track differences between multiple versions of your content, and revert back to older versions.

Review of the 8.x-1.x branch (commit 82f542e):
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards).
    
    FILE: ...l/pareviewsh/pareview_temp/src/Plugin/Block/ConstantContactBlock.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     5 | WARNING | [x] Unused use statement
    --------------------------------------------------------------------------
    PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    --------------------------------------------------------------------------
    
    Time: 2.89 secs; Memory: 6Mb
    
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: ...ndor/drupal/pareviewsh/pareview_temp/src/Service/ConstantContact.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 32 WARNINGS AFFECTING 32 LINES
    --------------------------------------------------------------------------
      67 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
      68 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
      74 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
      75 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
      95 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
     128 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
     147 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
     169 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
     184 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
     191 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
     215 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     219 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
     220 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     248 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
     293 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
     308 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
     341 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
     346 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
     356 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
     366 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
     376 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
     421 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
     445 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
     460 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
     478 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
     481 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
     493 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
     506 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
     513 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
     531 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
     566 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
     570 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
    --------------------------------------------------------------------------
    
    
    FILE: ...rupal/pareviewsh/pareview_temp/src/Form/ConstantContactBlockForm.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     124 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
    --------------------------------------------------------------------------
    
    
    FILE: ...r/drupal/pareviewsh/pareview_temp/src/Form/ConstantContactConfig.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     83 | WARNING | \Drupal calls should be avoided in classes, use
        |         | dependency injection instead
    --------------------------------------------------------------------------
    
    
    FILE: ...or/drupal/pareviewsh/pareview_temp/src/Form/ConstantContactLists.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     70 | WARNING | \Drupal calls should be avoided in classes, use
        |         | dependency injection instead
    --------------------------------------------------------------------------
    
    Time: 2.07 secs; Memory: 6Mb
    
  • No automated test cases were found, did you consider writing PHPUnit tests? This is not a requirement but encouraged for professional software development.
This automated report was generated with PAReview.sh, your friendly project application review script.