https://git.drupal.org/project/ime.git 8.x-1.x

Primary tabs

Review of the 8.x-1.x branch (commit 940769a):
  • Your README.txt does not follow best practices (headings need to be uppercase). See https://www.drupal.org/node/2181737 .
    • The INTRODUCTION section is missing.
    • The REQUIREMENTS section is missing.
    • The INSTALLATION section is missing.
    • The CONFIGURATION section is missing.
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • ESLint has found some issues with your code (please check the JavaScript coding standards).
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/ime_script.js: line 6, col 2, Error - Use the function form of 'use strict'. (strict)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/ime_script.js: line 12, col 1, Error - Trailing spaces not allowed. (no-trailing-spaces)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/ime_script.js: line 15, col 35, Error - Missing space before function parentheses. (space-before-function-paren)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/ime_script.js: line 18, col 13, Error - Expected '!==' and instead saw '!='. (eqeqeq)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/ime_script.js: line 22, col 26, Error - Missing space before function parentheses. (space-before-function-paren)
    
    5 problems
    
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: ...web/vendor/drupal/pareviewsh/pareview_temp/src/Form/ImeAdminForm.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 12 WARNINGS AFFECTING 12 LINES
    --------------------------------------------------------------------------
     61 | WARNING | t() calls should be avoided in classes, use dependency
        |         | injection and $this->t() instead
     65 | WARNING | \Drupal calls should be avoided in classes, use
        |         | dependency injection instead
     72 | WARNING | t() calls should be avoided in classes, use dependency
        |         | injection and $this->t() instead
     73 | WARNING | \Drupal calls should be avoided in classes, use
        |         | dependency injection instead
     74 | WARNING | t() calls should be avoided in classes, use dependency
        |         | injection and $this->t() instead
     79 | WARNING | t() calls should be avoided in classes, use dependency
        |         | injection and $this->t() instead
     80 | WARNING | \Drupal calls should be avoided in classes, use
        |         | dependency injection instead
     81 | WARNING | t() calls should be avoided in classes, use dependency
        |         | injection and $this->t() instead
     86 | WARNING | t() calls should be avoided in classes, use dependency
        |         | injection and $this->t() instead
     87 | WARNING | t() calls should be avoided in classes, use dependency
        |         | injection and $this->t() instead
     88 | WARNING | \Drupal calls should be avoided in classes, use
        |         | dependency injection instead
     92 | WARNING | t() calls should be avoided in classes, use dependency
        |         | injection and $this->t() instead
    --------------------------------------------------------------------------
    
    
    FILE: ...000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/ime.info.yml
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     7 | WARNING | All dependencies must be prefixed with the project name,
       |         | for example "drupal:"
    --------------------------------------------------------------------------
    
    Time: 405ms; Memory: 4Mb
    
  • No automated test cases were found, did you consider writing PHPUnit tests? This is not a requirement but encouraged for professional software development.
This automated report was generated with PAReview.sh, your friendly project application review script.

FILE: ...00000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/README.txt
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
 26 | WARNING | Line exceeds 80 characters; contains 124 characters
--------------------------------------------------------------------------


FILE: ...00000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/ime.module
--------------------------------------------------------------------------
FOUND 11 ERRORS AFFECTING 11 LINES
--------------------------------------------------------------------------
 30 | ERROR | [x] Short array syntax must be used to define arrays
 33 | ERROR | [x] Expected 1 blank line after function; 2 found
 40 | ERROR | [x] Short array syntax must be used to define arrays
 45 | ERROR | [x] Short array syntax must be used to define arrays
 46 | ERROR | [x] Short array syntax must be used to define arrays
 52 | ERROR | [x] Short array syntax must be used to define arrays
 56 | ERROR | [x] Short array syntax must be used to define arrays
 57 | ERROR | [x] Short array syntax must be used to define arrays
 58 | ERROR | [x] Short array syntax must be used to define arrays
 73 | ERROR | [x] Return type must not contain variable name "$patterns"
 77 | ERROR | [x] Short array syntax must be used to define arrays
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 11 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...web/vendor/drupal/pareviewsh/pareview_temp/src/Form/ImeAdminForm.php
--------------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES
--------------------------------------------------------------------------
  3 | ERROR   | [x] Namespaced classes, interfaces and traits should not
    |         |     begin with a file doc comment
 10 | WARNING | [x] Unused use statement
 90 | ERROR   | [x] Short array syntax must be used to define arrays
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/ime.info.yml
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 1 LINE
--------------------------------------------------------------------------
 1 | WARNING | Remove "project" from the info file, it will be added by
   |         | drupal.org packaging automatically
 1 | WARNING | Remove "version" from the info file, it will be added by
   |         | drupal.org packaging automatically
--------------------------------------------------------------------------


FILE: ...00/site1101/web/vendor/drupal/pareviewsh/pareview_temp/ime.drush.inc
--------------------------------------------------------------------------
FOUND 6 ERRORS AFFECTING 5 LINES
--------------------------------------------------------------------------
  1 | ERROR | [x] The PHP open tag must be followed by exactly one blank
    |       |     line
 11 | ERROR | [x] Short array syntax must be used to define arrays
 14 | ERROR | [x] Short array syntax must be used to define arrays
 30 | ERROR | [x] Short array syntax must be used to define arrays
 33 | ERROR | [x] Short array syntax must be used to define arrays
 33 | ERROR | [x] Short array syntax must be used to define arrays
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Time: 610ms; Memory: 4Mb