Revision of https://git.drupal.org/project/juicerio.git 8.x-1.x from Tue, 08/13/2019 - 15:39

Revisions allow you to track differences between multiple versions of your content, and revert back to older versions.

Review of the 8.x-1.x branch (commit 98c5a48):
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: ...l/pareviewsh/pareview_temp/src/Plugin/Block/JuicerEmbedFeedBlock.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 14 WARNINGS AFFECTING 14 LINES
    --------------------------------------------------------------------------
      55 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
      57 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
      64 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
      66 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
      73 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
      76 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
      83 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
      84 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
      87 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
      93 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
      96 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     102 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     104 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     129 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
    --------------------------------------------------------------------------
    
    
    FILE: .../vendor/drupal/pareviewsh/pareview_temp/src/Form/JuicerAdminForm.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 6 WARNINGS AFFECTING 4 LINES
    --------------------------------------------------------------------------
     31 | WARNING | t() calls should be avoided in classes, use dependency
        |         | injection and $this->t() instead
     37 | WARNING | t() calls should be avoided in classes, use dependency
        |         | injection and $this->t() instead
     38 | WARNING | t() calls should be avoided in classes, use dependency
        |         | injection and $this->t() instead
     38 | WARNING | t() calls should be avoided in classes, use dependency
        |         | injection and $this->t() instead
     38 | WARNING | t() calls should be avoided in classes, use dependency
        |         | injection and $this->t() instead
     40 | WARNING | t() calls should be avoided in classes, use dependency
        |         | injection and $this->t() instead
    --------------------------------------------------------------------------
    
    Time: 436ms; Memory: 4Mb
    
This automated report was generated with PAReview.sh, your friendly project application review script.

FILE: .../site1101/web/vendor/drupal/pareviewsh/pareview_temp/juicerio.module
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 1 | ERROR | [x] The PHP open tag must be followed by exactly one blank
   |       |     line
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...1101/web/vendor/drupal/pareviewsh/pareview_temp/juicerio.routing.yml
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 6 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...drupal/pareviewsh/pareview_temp/config/install/juicerio.settings.yml
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 2 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...or/drupal/pareviewsh/pareview_temp/config/schema/juicerio.schema.yml
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 12 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...endor/drupal/pareviewsh/pareview_temp/src/Tests/JuicerSimpleTest.php
--------------------------------------------------------------------------
FOUND 4 ERRORS AND 1 WARNING AFFECTING 4 LINES
--------------------------------------------------------------------------
 37 | ERROR   | [x] Short array syntax must be used to define arrays
 68 | WARNING | [ ] Line exceeds 80 characters; contains 85 characters
 70 | ERROR   | [x] Short array syntax must be used to define arrays
 77 | ERROR   | [x] Expected 1 newline at end of file; 0 found
 77 | ERROR   | [x] The closing brace for the class must have an empty
    |         |     line before it
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...l/pareviewsh/pareview_temp/src/Plugin/Block/JuicerEmbedFeedBlock.php
--------------------------------------------------------------------------
FOUND 17 ERRORS AFFECTING 15 LINES
--------------------------------------------------------------------------
  19 | ERROR | [x] Expected 1 space before opening brace; found 2
  21 | ERROR | [x] Missing function doc comment
  33 | ERROR | [ ] If the line declaring an array spans longer than 80
     |       |     characters, each element should be broken into its own
     |       |     line
  33 | ERROR | [x] Short array syntax must be used to define arrays
  34 | ERROR | [ ] If the line declaring an array spans longer than 80
     |       |     characters, each element should be broken into its own
     |       |     line
  34 | ERROR | [x] Short array syntax must be used to define arrays
  35 | ERROR | [x] Short array syntax must be used to define arrays
  36 | ERROR | [x] Short array syntax must be used to define arrays
  52 | ERROR | [x] Inline comments must end in full-stops, exclamation
     |       |     marks, colons, question marks, or closing parentheses
  61 | ERROR | [x] Inline comments must end in full-stops, exclamation
     |       |     marks, colons, question marks, or closing parentheses
  70 | ERROR | [x] Inline comments must end in full-stops, exclamation
     |       |     marks, colons, question marks, or closing parentheses
  80 | ERROR | [x] Inline comments must end in full-stops, exclamation
     |       |     marks, colons, question marks, or closing parentheses
  90 | ERROR | [x] Inline comments must end in full-stops, exclamation
     |       |     marks, colons, question marks, or closing parentheses
  99 | ERROR | [x] Inline comments must end in full-stops, exclamation
     |       |     marks, colons, question marks, or closing parentheses
 127 | ERROR | [x] Missing function doc comment
 141 | ERROR | [x] Expected 1 blank line after function; 0 found
 142 | ERROR | [x] The closing brace for the class must have an empty
     |       |     line before it
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 15 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...review_temp/src/Plugin/Derivative/JuicerEmbedFeedBlockDerivative.php
--------------------------------------------------------------------------
FOUND 6 ERRORS AFFECTING 4 LINES
--------------------------------------------------------------------------
  7 | ERROR | [x] Missing class doc comment
  7 | ERROR | [x] Expected 1 space before opening brace; found 2
  9 | ERROR | [x] Missing function doc comment
 15 | ERROR | [x] Short array syntax must be used to define arrays
 20 | ERROR | [x] Expected 1 newline at end of file; 0 found
 20 | ERROR | [x] The closing brace for the class must have an empty line
    |       |     before it
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: .../vendor/drupal/pareviewsh/pareview_temp/src/Form/JuicerAdminForm.php
--------------------------------------------------------------------------
FOUND 6 ERRORS AFFECTING 6 LINES
--------------------------------------------------------------------------
  8 | ERROR | [x] Missing class doc comment
 12 | ERROR | [x] Expected 1 blank line before function; 0 found
 29 | ERROR | [x] Short array syntax must be used to define arrays
 35 | ERROR | [x] Short array syntax must be used to define arrays
 38 | ERROR | [x] Short array syntax must be used to define arrays
 59 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: .../web/vendor/drupal/pareviewsh/pareview_temp/juicerio.permissions.yml
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 3 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...1/web/vendor/drupal/pareviewsh/pareview_temp/juicerio.links.menu.yml
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 6 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...site1101/web/vendor/drupal/pareviewsh/pareview_temp/juicerio.install
--------------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES
--------------------------------------------------------------------------
 1 | ERROR   | [x] Missing file doc comment
 4 | WARNING | [ ] Format should be "* Implements hook_foo().", "*
   |         |     Implements hook_foo_BAR_ID_bar() for xyz_bar().",, "*
   |         |     Implements hook_foo_BAR_ID_bar() for
   |         |     xyz-bar.html.twig.", "* Implements
   |         |     hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.", or "*
   |         |     Implements hook_foo_BAR_ID_bar() for block templates."
 5 | ERROR   | [ ] Doc comment short description must be on a single
   |         |     line, further text should be a separate paragraph
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Time: 798ms; Memory: 4Mb