https://git.drupal.org/project/lazy_image_style/

Primary tabs

Review of the 8.x-1.x branch (commit 48f10e6):
  • README.md or README.txt is missing, see the guidelines for in-project documentation.
  • The lazy_image_style.module does not implement hook_help(). See https://www.drupal.org/docs/develop/documenting-your-project/module-docu... .
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • ESLint has found some issues with your code (please check the JavaScript coding standards).
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/assets/js/lazy-image-style.js: line 19, col 14, Error - Do not nest ternary expressions. (no-nested-ternary)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/assets/js/lazy-image-style.js: line 32, col 5, Error - Expected line before comment. (lines-around-comment)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/assets/js/lazy-image-style.js: line 32, col 5, Warning - JSDoc syntax error. (valid-jsdoc)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/assets/js/lazy-image-style.js: line 40, col 5, Error - Expected line before comment. (lines-around-comment)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/assets/js/lazy-image-style.js: line 40, col 5, Warning - Missing JSDoc for parameter 'elems'. (valid-jsdoc)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/assets/js/lazy-image-style.js: line 44, col 50, Error - A space is required after ','. (comma-spacing)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/assets/js/lazy-image-style.js: line 45, col 39, Error - A space is required after ','. (comma-spacing)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/assets/js/lazy-image-style.js: line 50, col 98, Error - Strings must use singlequote. (quotes)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/assets/js/lazy-image-style.js: line 60, col 42, Error - Strings must use singlequote. (quotes)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/assets/js/lazy-image-style.js: line 61, col 40, Error - Strings must use singlequote. (quotes)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/assets/js/lazy-image-style.js: line 62, col 40, Error - Strings must use singlequote. (quotes)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/assets/js/lazy-image-style.js: line 65, col 9, Error - Missing semicolon. (semi)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/assets/js/lazy-image-style.js: line 72, col 6, Error - Unexpected trailing comma. (comma-dangle)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/assets/js/lazy-image-style.js: line 82, col 33, Error - Strings must use singlequote. (quotes)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/assets/js/lazy-image-style.js: line 83, col 31, Error - Strings must use singlequote. (quotes)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/assets/js/lazy-image-style.js: line 84, col 31, Error - Strings must use singlequote. (quotes)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/assets/js/lazy-image-style.js: line 85, col 6, Error - Unexpected trailing comma. (comma-dangle)
    
    17 problems
    
  • No automated test cases were found, did you consider writing PHPUnit tests? This is not a requirement but encouraged for professional software development.
This automated report was generated with PAReview.sh, your friendly project application review script.

FILE: ...ndor/drupal/pareviewsh/pareview_temp/assets/css/lazy-image-style.css
--------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------
 5 | ERROR | [x] Expected 1 newline at end of file; 2 found
 6 | ERROR | [x] Additional whitespace found at end of file
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...web/vendor/drupal/pareviewsh/pareview_temp/lazy_image_style.info.yml
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
 1 | WARNING | Remove "version" from the info file, it will be added by
   |         | drupal.org packaging automatically
--------------------------------------------------------------------------


FILE: ...web/vendor/drupal/pareviewsh/pareview_temp/src/Form/SettingsForm.php
--------------------------------------------------------------------------
FOUND 7 ERRORS AND 2 WARNINGS AFFECTING 8 LINES
--------------------------------------------------------------------------
  10 | WARNING | [x] Unused use statement
  48 | ERROR   | [x] There must be exactly one blank line before the tags
     |         |     in a doc comment
  48 | ERROR   | [ ] Missing parameter comment
  49 | ERROR   | [ ] Missing parameter comment
  50 | ERROR   | [ ] Missing parameter comment
 112 | WARNING | [ ] Possible useless method overriding detected
 138 | ERROR   | [x] Missing function doc comment
 142 | ERROR   | [ ] Inline doc block comments are not allowed; use "/*
     |         |     Comment */" or "// Comment" instead
 144 | ERROR   | [x] Data types in @var tags need to be fully namespaced
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...1/web/vendor/drupal/pareviewsh/pareview_temp/lazy_image_style.module
--------------------------------------------------------------------------
FOUND 3 ERRORS AND 1 WARNING AFFECTING 4 LINES
--------------------------------------------------------------------------
 28 | ERROR   | [x] Namespaced classes/interfaces/traits should be
    |         |     referenced with use statements
 32 | ERROR   | [x] Whitespace found at end of line
 39 | WARNING | [x] A comma should follow the last multiline array item.
    |         |     Found: ]
 42 | ERROR   | [x] Inline comments must end in full-stops, exclamation
    |         |     marks, colons, question marks, or closing parentheses
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: .../web/vendor/drupal/pareviewsh/pareview_temp/lazy_image_style.install
--------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
--------------------------------------------------------------------------
 15 | ERROR   | [x] Namespaced classes/interfaces/traits should be
    |         |     referenced with use statements
 25 | WARNING | [ ] Avoid backslash escaping in translatable strings when
    |         |     possible, use '' quotes instead
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Time: 793ms; Memory: 4Mb