Revision of https://git.drupal.org/project/lazy_image_style from Sun, 04/14/2019 - 10:38

Revisions allow you to track differences between multiple versions of your content, and revert back to older versions.

Review of the 8.x-1.x branch (commit bed5394):
  • Your README.md does not follow best practices (headings need to be uppercase). See https://www.drupal.org/node/2181737 .
    • The INTRODUCTION section is missing.
    • The REQUIREMENTS section is missing.
    • The INSTALLATION section is missing.
    • The CONFIGURATION section is missing.
  • The lazy_image_style.module does not implement hook_help(). See https://www.drupal.org/docs/develop/documenting-your-project/module-docu... .
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • ESLint has found some issues with your code (please check the JavaScript coding standards).
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/assets/js/lazy-image-style.js: line 21, col 28, Error - Missing space before opening brace. (space-before-blocks)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/assets/js/lazy-image-style.js: line 37, col 5, Warning - JSDoc syntax error. (valid-jsdoc)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/assets/js/lazy-image-style.js: line 46, col 5, Warning - Missing JSDoc for parameter 'elems'. (valid-jsdoc)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/assets/js/lazy-image-style.js: line 50, col 50, Error - A space is required after ','. (comma-spacing)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/assets/js/lazy-image-style.js: line 51, col 39, Error - A space is required after ','. (comma-spacing)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/assets/js/lazy-image-style.js: line 56, col 98, Error - Strings must use singlequote. (quotes)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/assets/js/lazy-image-style.js: line 66, col 42, Error - Strings must use singlequote. (quotes)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/assets/js/lazy-image-style.js: line 67, col 40, Error - Strings must use singlequote. (quotes)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/assets/js/lazy-image-style.js: line 68, col 40, Error - Strings must use singlequote. (quotes)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/assets/js/lazy-image-style.js: line 71, col 9, Error - Missing semicolon. (semi)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/assets/js/lazy-image-style.js: line 78, col 6, Error - Unexpected trailing comma. (comma-dangle)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/assets/js/lazy-image-style.js: line 88, col 33, Error - Strings must use singlequote. (quotes)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/assets/js/lazy-image-style.js: line 89, col 31, Error - Strings must use singlequote. (quotes)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/assets/js/lazy-image-style.js: line 90, col 31, Error - Strings must use singlequote. (quotes)
    
    14 problems
    
  • No automated test cases were found, did you consider writing PHPUnit tests? This is not a requirement but encouraged for professional software development.
This automated report was generated with PAReview.sh, your friendly project application review script.

FILE: ...web/vendor/drupal/pareviewsh/pareview_temp/src/Form/SettingsForm.php
--------------------------------------------------------------------------
FOUND 6 ERRORS AND 1 WARNING AFFECTING 7 LINES
--------------------------------------------------------------------------
  48 | ERROR   | [ ] Missing parameter comment
  49 | ERROR   | [ ] Missing parameter comment
  50 | ERROR   | [ ] Missing parameter comment
 112 | WARNING | [ ] Possible useless method overriding detected
 141 | ERROR   | [ ] Description for the @return value is missing
 142 | ERROR   | [x] Separate the @return and @throws sections by a blank
     |         |     line.
 149 | ERROR   | [ ] Inline doc block comments are not allowed; use "/*
     |         |     Comment */" or "// Comment" instead
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...1/web/vendor/drupal/pareviewsh/pareview_temp/lazy_image_style.module
--------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
--------------------------------------------------------------------------
 34 | ERROR   | [x] Whitespace found at end of line
 41 | WARNING | [x] A comma should follow the last multiline array item.
    |         |     Found: ]
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: .../web/vendor/drupal/pareviewsh/pareview_temp/lazy_image_style.install
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
 26 | WARNING | Avoid backslash escaping in translatable strings when
    |         | possible, use '' quotes instead
--------------------------------------------------------------------------

Time: 653ms; Memory: 4Mb