Revision of https://git.drupal.org/project/libraries_delay_load from Sun, 05/17/2020 - 06:25

Revisions allow you to track differences between multiple versions of your content, and revert back to older versions.

Git errors: Review of the 1.0.x branch (commit 65b64ba):
  • The libraries_delay_load.module does not implement hook_help(). See https://www.drupal.org/docs/develop/documenting-your-project/module-docu... .
  • ESLint has found some issues with your code (please check the JavaScript coding standards). See attachment.
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: ...1/web/vendor/drupal/pareviewsh/pareview_temp/src/Asset/JsDelayer.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
    --------------------------------------------------------------------------
     123 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
     131 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
    --------------------------------------------------------------------------
    
    Time: 471ms; Memory: 4Mb
    
  • No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.
This automated report was generated with PAReview.sh, your friendly project application review script.
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/delayer.js: line 1, col 2, Error - Use the function form of 'use strict'. (strict)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/delayer.js: line 1, col 10, Error - Missing space before function parentheses. (space-before-function-paren)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/delayer.js: line 3, col 43, Error - Missing space before function parentheses. (space-before-function-paren)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/delayer.js: line 6, col 1, Error - Trailing spaces not allowed. (no-trailing-spaces)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/delayer.js: line 7, col 29, Error - Missing space before opening brace. (space-before-blocks)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/delayer.js: line 8, col 5, Error - Expected space(s) after "if". (keyword-spacing)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/delayer.js: line 8, col 37, Error - Strings must use singlequote. (quotes)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/delayer.js: line 8, col 78, Error - Strings must use singlequote. (quotes)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/delayer.js: line 8, col 111, Error - Strings must use singlequote. (quotes)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/delayer.js: line 8, col 123, Error - Missing space before opening brace. (space-before-blocks)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/delayer.js: line 12, col 5, Error - Expected space(s) after "else". (keyword-spacing)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/delayer.js: line 13, col 19, Error - Strings must use singlequote. (quotes)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/delayer.js: line 17, col 1, Error - Trailing spaces not allowed. (no-trailing-spaces)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/delayer.js: line 25, col 25, Error - Expected '===' and instead saw '=='. (eqeqeq)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/delayer.js: line 26, col 21, Error - Strings must use singlequote. (quotes)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/delayer.js: line 26, col 54, Error - Strings must use singlequote. (quotes)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/delayer.js: line 31, col 21, Error - Strings must use singlequote. (quotes)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/delayer.js: line 31, col 55, Error - Strings must use singlequote. (quotes)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/delayer.js: line 33, col 8, Error - Trailing spaces not allowed. (no-trailing-spaces)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/delayer.js: line 39, col 1, Error - Trailing spaces not allowed. (no-trailing-spaces)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/delayer.js: line 45, col 10, Error - There should be no spaces inside this paren. (space-in-parens)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/delayer.js: line 45, col 24, Error - Expected '===' and instead saw '=='. (eqeqeq)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/delayer.js: line 45, col 34, Error - There should be no spaces inside this paren. (space-in-parens)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/delayer.js: line 48, col 18, Error - There should be no spaces inside this paren. (space-in-parens)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/delayer.js: line 48, col 20, Error - Strings must use singlequote. (quotes)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/delayer.js: line 49, col 42, Error - Missing space before function parentheses. (space-before-function-paren)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/delayer.js: line 50, col 20, Error - There should be no spaces inside this paren. (space-in-parens)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/delayer.js: line 50, col 22, Error - Strings must use singlequote. (quotes)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/delayer.js: line 53, col 1, Error - Trailing spaces not allowed. (no-trailing-spaces)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/delayer.js: line 62, col 1, Error - Trailing spaces not allowed. (no-trailing-spaces)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/delayer.js: line 65, col 5, Error - The body of a for-in should be wrapped in an if statement to filter unwanted properties from the prototype. (guard-for-in)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/delayer.js: line 68, col 10, Error - There should be no spaces inside this paren. (space-in-parens)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/delayer.js: line 68, col 24, Error - Expected '===' and instead saw '=='. (eqeqeq)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/delayer.js: line 68, col 34, Error - There should be no spaces inside this paren. (space-in-parens)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/delayer.js: line 71, col 18, Error - There should be no spaces inside this paren. (space-in-parens)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/delayer.js: line 71, col 20, Error - Strings must use singlequote. (quotes)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/delayer.js: line 83, col 1, Error - Trailing spaces not allowed. (no-trailing-spaces)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/delayer.js: line 85, col 35, Error - Strings must use singlequote. (quotes)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/delayer.js: line 85, col 101, Error - Strings must use singlequote. (quotes)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/delayer.js: line 86, col 7, Error - Unexpected console statement. (no-console)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/delayer.js: line 89, col 1, Error - Trailing spaces not allowed. (no-trailing-spaces)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/delayer.js: line 90, col 6, Error - Newline required at end of file but not found. (eol-last)

42 problems