Revision of https://git.drupal.org/project/libraries_delay_load from Sun, 05/17/2020 - 06:42

Revisions allow you to track differences between multiple versions of your content, and revert back to older versions.

Git errors: Review of the 1.0.x branch (commit a72fd9d):
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards).
    
    FILE: ...1/web/vendor/drupal/pareviewsh/pareview_temp/src/Asset/JsDelayer.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     123 | WARNING | Line exceeds 80 characters; contains 88 characters
    --------------------------------------------------------------------------
    
    Time: 919ms; Memory: 4Mb
    
  • ESLint has found some issues with your code (please check the JavaScript coding standards).
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/delayer.js: line 3, col 1, Error - Trailing spaces not allowed. (no-trailing-spaces)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/delayer.js: line 35, col 8, Error - Trailing spaces not allowed. (no-trailing-spaces)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/delayer.js: line 47, col 10, Error - There should be no spaces inside this paren. (space-in-parens)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/delayer.js: line 47, col 35, Error - There should be no spaces inside this paren. (space-in-parens)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/delayer.js: line 55, col 1, Error - Trailing spaces not allowed. (no-trailing-spaces)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/delayer.js: line 67, col 5, Error - The body of a for-in should be wrapped in an if statement to filter unwanted properties from the prototype. (guard-for-in)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/delayer.js: line 70, col 10, Error - There should be no spaces inside this paren. (space-in-parens)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/delayer.js: line 70, col 35, Error - There should be no spaces inside this paren. (space-in-parens)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/delayer.js: line 85, col 1, Error - Trailing spaces not allowed. (no-trailing-spaces)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/delayer.js: line 88, col 7, Error - Unexpected console statement. (no-console)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/delayer.js: line 92, col 6, Error - Newline required at end of file but not found. (eol-last)
    
    11 problems
    
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: ...1/web/vendor/drupal/pareviewsh/pareview_temp/src/Asset/JsDelayer.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
    --------------------------------------------------------------------------
     124 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
     132 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
    --------------------------------------------------------------------------
    
    Time: 503ms; Memory: 4Mb
    
  • No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.
This automated report was generated with PAReview.sh, your friendly project application review script.