Revision of https://git.drupal.org/project/libraries_delay_load from Fri, 05/22/2020 - 23:27

Revisions allow you to track differences between multiple versions of your content, and revert back to older versions.

Git errors: Review of the 2.0.x branch (commit c95f786):
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards).
    
    FILE: ...1/web/vendor/drupal/pareviewsh/pareview_temp/src/Asset/JsDelayer.php
    --------------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    --------------------------------------------------------------------------
     99 | ERROR | [x] Inline comments must end in full-stops, exclamation
        |       |     marks, colons, question marks, or closing parentheses
    --------------------------------------------------------------------------
    PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    --------------------------------------------------------------------------
    
    Time: 1.47 secs; Memory: 6Mb
    
  • ESLint has found some issues with your code (please check the JavaScript coding standards).
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/delayer.js: line 87, col 7, Error - Unexpected console statement. (no-console)
    
    1 problem
    
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: ...1/web/vendor/drupal/pareviewsh/pareview_temp/src/Asset/JsDelayer.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
    --------------------------------------------------------------------------
     121 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
     279 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
    --------------------------------------------------------------------------
    
    
    FILE: ...dor/drupal/pareviewsh/pareview_temp/src/Form/JsDelayStrategyForm.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     72 | WARNING | t() calls should be avoided in classes, use dependency
        |         | injection and $this->t() instead
    --------------------------------------------------------------------------
    
    Time: 879ms; Memory: 4Mb
    
  • No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.
This automated report was generated with PAReview.sh, your friendly project application review script.