Revision of https://git.drupal.org/project/libraries_delay_load from Tue, 05/26/2020 - 20:49

Revisions allow you to track differences between multiple versions of your content, and revert back to older versions.

Git errors: Review of the 2.0.x branch (commit ae12c20):
  • Bad line endings were found, always use unix style terminators. See https://www.drupal.org/coding-standards#indenting
    ./tests/modules/libraries_delay_load_javascript_test/js/js1.js:                                             ASCII text, with no line terminators
    ./tests/modules/libraries_delay_load_javascript_test/js/js4.js:                                             ASCII text, with no line terminators
    ./tests/modules/libraries_delay_load_javascript_test/js/js10.js:                                            ASCII text, with no line terminators
    ./tests/modules/libraries_delay_load_javascript_test/js/js8.js:                                             ASCII text, with no line terminators
    ./tests/modules/libraries_delay_load_javascript_test/js/js7.js:                                             ASCII text, with no line terminators
    ./tests/modules/libraries_delay_load_javascript_test/js/js6.js:                                             ASCII text, with no line terminators
    ./tests/modules/libraries_delay_load_javascript_test/js/js2.js:                                             ASCII text, with no line terminators
    ./tests/modules/libraries_delay_load_javascript_test/js/js9.js:                                             ASCII text, with no line terminators
    ./tests/modules/libraries_delay_load_javascript_test/js/js5.js:                                             ASCII text, with no line terminators
    ./tests/modules/libraries_delay_load_javascript_test/js/js3.js:                                             ASCII text, with no line terminators
    
    
  • ESLint has found some issues with your code (please check the JavaScript coding standards). See attachment.
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: ...1/web/vendor/drupal/pareviewsh/pareview_temp/src/Asset/JsDelayer.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     303 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
    --------------------------------------------------------------------------
    
    Time: 1.49 secs; Memory: 4Mb
    
This automated report was generated with PAReview.sh, your friendly project application review script.
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/delayer.js: line 87, col 7, Error - Unexpected console statement. (no-console)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/tests/modules/libraries_delay_load_javascript_test/js/js1.js: line 1, col 1, Error - Unexpected console statement. (no-console)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/tests/modules/libraries_delay_load_javascript_test/js/js1.js: line 1, col 19, Error - Newline required at end of file but not found. (eol-last)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/tests/modules/libraries_delay_load_javascript_test/js/js10.js: line 1, col 1, Error - Unexpected console statement. (no-console)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/tests/modules/libraries_delay_load_javascript_test/js/js10.js: line 1, col 19, Error - Newline required at end of file but not found. (eol-last)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/tests/modules/libraries_delay_load_javascript_test/js/js2.js: line 1, col 1, Error - Unexpected console statement. (no-console)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/tests/modules/libraries_delay_load_javascript_test/js/js2.js: line 1, col 20, Error - Newline required at end of file but not found. (eol-last)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/tests/modules/libraries_delay_load_javascript_test/js/js3.js: line 1, col 1, Error - Unexpected console statement. (no-console)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/tests/modules/libraries_delay_load_javascript_test/js/js3.js: line 1, col 19, Error - Newline required at end of file but not found. (eol-last)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/tests/modules/libraries_delay_load_javascript_test/js/js4.js: line 1, col 1, Error - Unexpected console statement. (no-console)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/tests/modules/libraries_delay_load_javascript_test/js/js4.js: line 1, col 19, Error - Newline required at end of file but not found. (eol-last)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/tests/modules/libraries_delay_load_javascript_test/js/js5.js: line 1, col 1, Error - Unexpected console statement. (no-console)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/tests/modules/libraries_delay_load_javascript_test/js/js5.js: line 1, col 20, Error - Newline required at end of file but not found. (eol-last)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/tests/modules/libraries_delay_load_javascript_test/js/js6.js: line 1, col 1, Error - Unexpected console statement. (no-console)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/tests/modules/libraries_delay_load_javascript_test/js/js6.js: line 1, col 19, Error - Newline required at end of file but not found. (eol-last)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/tests/modules/libraries_delay_load_javascript_test/js/js7.js: line 1, col 1, Error - Unexpected console statement. (no-console)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/tests/modules/libraries_delay_load_javascript_test/js/js7.js: line 1, col 19, Error - Newline required at end of file but not found. (eol-last)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/tests/modules/libraries_delay_load_javascript_test/js/js8.js: line 1, col 1, Error - Unexpected console statement. (no-console)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/tests/modules/libraries_delay_load_javascript_test/js/js8.js: line 1, col 20, Error - Newline required at end of file but not found. (eol-last)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/tests/modules/libraries_delay_load_javascript_test/js/js9.js: line 1, col 1, Error - Unexpected console statement. (no-console)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/tests/modules/libraries_delay_load_javascript_test/js/js9.js: line 1, col 20, Error - Newline required at end of file but not found. (eol-last)

21 problems