https://git.drupal.org/project/local_translation.git

Primary tabs

Review of the 8.x-1.x branch (commit cfa1d33):
  • The local_translation_content.module does not implement hook_help(). See https://www.drupal.org/docs/develop/documenting-your-project/module-docu... .
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: ...pareviewsh/pareview_temp/src/Services/LocalTranslationUserSkills.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
    --------------------------------------------------------------------------
      69 | WARNING | User::load calls should be avoided in classes, use
         |         | dependency injection instead
      88 | WARNING | User::load calls should be avoided in classes, use
         |         | dependency injection instead
     113 | WARNING | User::load calls should be avoided in classes, use
         |         | dependency injection instead
     201 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
    --------------------------------------------------------------------------
    
    Time: 5.21 secs; Memory: 10Mb
    
This automated report was generated with PAReview.sh, your friendly project application review script.

FILE: ...000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/README.md
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 11 WARNINGS AFFECTING 11 LINES
--------------------------------------------------------------------------
  6 | WARNING | Line exceeds 80 characters; contains 491 characters
 12 | WARNING | Line exceeds 80 characters; contains 89 characters
 13 | WARNING | Line exceeds 80 characters; contains 85 characters
 14 | WARNING | Line exceeds 80 characters; contains 91 characters
 15 | WARNING | Line exceeds 80 characters; contains 232 characters
 16 | WARNING | Line exceeds 80 characters; contains 137 characters
 20 | WARNING | Line exceeds 80 characters; contains 103 characters
 21 | WARNING | Line exceeds 80 characters; contains 103 characters
 39 | WARNING | Line exceeds 80 characters; contains 213 characters
 42 | WARNING | Line exceeds 80 characters; contains 227 characters
 45 | WARNING | Line exceeds 80 characters; contains 158 characters
--------------------------------------------------------------------------


FILE: ...content/src/Plugin/views/filter/LocalTranslationViewsFiltersBase.php
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 81 | ERROR | [x] Equals sign not aligned with surrounding assignments;
    |       |     expected 1 space but found 2 spaces
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...slation_content/src/Controller/LocalTranslationContentController.php
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 520 | ERROR | [x] Equals sign not aligned with surrounding assignments;
     |       |     expected 1 space but found 2 spaces
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...l/pareviewsh/pareview_temp/src/Form/LocalTranslationSettingsForm.php
--------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------
 170 | ERROR | [x] Equals sign not aligned with surrounding assignments;
     |       |     expected 1 space but found 2 spaces
 171 | ERROR | [x] Equals sign not aligned with surrounding assignments;
     |       |     expected 1 space but found 2 spaces
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Time: 7.79 secs; Memory: 12Mb