https://git.drupal.org/project/mail_login

Primary tabs

Review of the 8.x-1.x branch (commit a7c3cb6):
  • The mail_login.module does not implement hook_help(). See https://www.drupal.org/docs/develop/documenting-your-project/module-docu... .
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards).
    
    FILE: ...ite1101/web/vendor/drupal/pareviewsh/pareview_temp/mail_login.module
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
    --------------------------------------------------------------------------
     27 | WARNING | Only string literals should be passed to t() where
        |         | possible
     28 | WARNING | Only string literals should be passed to t() where
        |         | possible
    --------------------------------------------------------------------------
    
    Time: 491ms; Memory: 4Mb
    
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: ...pal/pareviewsh/pareview_temp/src/Form/MailLoginAdminSettingsForm.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     31 | WARNING | \Drupal calls should be avoided in classes, use
        |         | dependency injection instead
    --------------------------------------------------------------------------
    
    Time: 236ms; Memory: 4Mb
    
  • No automated test cases were found, did you consider writing PHPUnit tests? This is not a requirement but encouraged for professional software development.
This automated report was generated with PAReview.sh, your friendly project application review script.