Review of the 7.x-1.x branch (commit ad6bb0f):

- Your README.txt does not follow best practices (headings need to be uppercase). See https://www.drupal.org/node/2181737 .
- The INTRODUCTION section is missing.
- The REQUIREMENTS section is missing.
- The CONFIGURATION section is missing.

- The menu_cache_clear.module does not implement
`hook_help()`

. See https://www.drupal.org/docs/develop/documenting-your-project/module-docu... . - Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
- DrupalPractice has found some issues with your code, but could be false positives.
FILE: ...1/web/vendor/drupal/pareviewsh/pareview_temp/menu_cache_clear.module -------------------------------------------------------------------------- FOUND 0 ERRORS AND 6 WARNINGS AFFECTING 6 LINES -------------------------------------------------------------------------- 41 | WARNING | Unused global variable $user. 65 | WARNING | Unused variable $masks. 66 | WARNING | Unused variable $url. 67 | WARNING | Unused variable $check. 86 | WARNING | Unused variable $masks. 189 | WARNING | All variables defined by your module must be prefixed | | with your module's name to avoid name collisions with | | others. Expected start with "menu_cache_clear" but found | | "validation_msg" -------------------------------------------------------------------------- Time: 130ms; Memory: 4Mb

- No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.

FILE: ...00000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/README.txt -------------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES -------------------------------------------------------------------------- 11 | WARNING | Line exceeds 80 characters; contains 85 characters 23 | WARNING | Line exceeds 80 characters; contains 81 characters -------------------------------------------------------------------------- FILE: ...1/web/vendor/drupal/pareviewsh/pareview_temp/menu_cache_clear.module -------------------------------------------------------------------------- FOUND 143 ERRORS AND 2 WARNINGS AFFECTING 136 LINES -------------------------------------------------------------------------- 12 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found | | 4 14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found | | 4 15 | ERROR | [x] Array indentation error, expected 6 spaces but found | | 8 16 | ERROR | [x] Array indentation error, expected 6 spaces but found | | 8 17 | ERROR | [x] Array indentation error, expected 6 spaces but found | | 8 18 | ERROR | [x] Array indentation error, expected 6 spaces but found | | 8 19 | ERROR | [x] Array indentation error, expected 6 spaces but found | | 8 20 | ERROR | [x] Array indentation error, expected 6 spaces but found | | 8 21 | ERROR | [x] Array indentation error, expected 6 spaces but found | | 8 23 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found | | 4 24 | ERROR | [x] Array indentation error, expected 6 spaces but found | | 8 25 | ERROR | [x] Array indentation error, expected 6 spaces but found | | 8 26 | ERROR | [x] Array indentation error, expected 6 spaces but found | | 8 27 | ERROR | [x] Array indentation error, expected 6 spaces but found | | 8 28 | ERROR | [x] Array indentation error, expected 6 spaces but found | | 8 29 | ERROR | [x] Array indentation error, expected 6 spaces but found | | 8 30 | ERROR | [x] Array indentation error, expected 6 spaces but found | | 8 32 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found | | 4 41 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found | | 4 42 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found | | 4 43 | ERROR | [x] Array indentation error, expected 6 spaces but found | | 8 44 | ERROR | [x] Array indentation error, expected 6 spaces but found | | 8 45 | ERROR | [x] Array indentation error, expected 6 spaces but found | | 8 46 | ERROR | [x] Array indentation error, expected 6 spaces but found | | 8 48 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found | | 4 49 | ERROR | [x] Array indentation error, expected 6 spaces but found | | 8 50 | ERROR | [x] Array indentation error, expected 6 spaces but found | | 8 52 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found | | 4 53 | ERROR | [x] Array indentation error, expected 6 spaces but found | | 8 54 | ERROR | [x] Array indentation error, expected 6 spaces but found | | 8 56 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found | | 4 65 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found | | 4 66 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found | | 4 67 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found | | 4 68 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found | | 4 68 | ERROR | [x] Expected 1 space after IF keyword; 0 found 68 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 69 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found | | 8 70 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found | | 8 70 | ERROR | [x] Expected 1 space after IF keyword; 0 found 70 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 71 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found | | 12 71 | WARNING | [ ] Only string literals should be passed to t() where | | possible 72 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found | | 8 72 | ERROR | [x] Expected newline after closing brace 72 | ERROR | [x] Expected 1 space after ELSE keyword; 0 found 73 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found | | 12 74 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found | | 8 76 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found | | 4 86 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found | | 4 87 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found | | 4 88 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found | | 4 89 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found | | 4 90 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found | | 4 91 | ERROR | [x] Object operator not indented correctly; expected 6 | | spaces but found 8 94 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found | | 4 95 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found | | 8 96 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found | | 12 97 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found | | 12 98 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found | | 8 99 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found | | 8 100 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found | | 12 101 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found | | 16 102 | ERROR | [x] Object operator not indented correctly; expected 18 | | spaces but found 20 103 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found | | 16 104 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found | | 16 105 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found | | 12 106 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found | | 12 107 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found | | 16 108 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found | | 12 109 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found | | 8 110 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found | | 4 119 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found | | 4 120 | ERROR | [x] Object operator not indented correctly; expected 6 | | spaces but found 8 121 | ERROR | [x] Array indentation error, expected 10 spaces but | | found 12 122 | ERROR | [x] Array indentation error, expected 10 spaces but | | found 12 123 | ERROR | [x] Array indentation error, expected 10 spaces but | | found 12 124 | ERROR | [x] Array indentation error, expected 10 spaces but | | found 12 125 | ERROR | [x] Array indentation error, expected 10 spaces but | | found 12 126 | ERROR | [x] Array indentation error, expected 10 spaces but | | found 12 127 | ERROR | [x] Array indentation error, expected 10 spaces but | | found 12 128 | ERROR | [x] Array indentation error, expected 10 spaces but | | found 12 129 | ERROR | [x] Array indentation error, expected 10 spaces but | | found 12 130 | ERROR | [x] Array indentation error, expected 10 spaces but | | found 12 131 | ERROR | [x] Array indentation error, expected 10 spaces but | | found 12 132 | ERROR | [x] Array indentation error, expected 10 spaces but | | found 12 133 | ERROR | [x] Array indentation error, expected 10 spaces but | | found 12 134 | ERROR | [x] Array indentation error, expected 10 spaces but | | found 12 135 | ERROR | [x] Array indentation error, expected 10 spaces but | | found 12 136 | ERROR | [x] Array indentation error, expected 10 spaces but | | found 12 137 | ERROR | [x] Array indentation error, expected 10 spaces but | | found 12 138 | ERROR | [x] Array indentation error, expected 10 spaces but | | found 12 139 | ERROR | [x] Array indentation error, expected 10 spaces but | | found 12 140 | ERROR | [x] Array indentation error, expected 10 spaces but | | found 12 141 | ERROR | [x] Array indentation error, expected 10 spaces but | | found 12 142 | ERROR | [x] Array indentation error, expected 10 spaces but | | found 12 143 | ERROR | [x] Array indentation error, expected 10 spaces but | | found 12 145 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found | | 4 146 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found | | 4 147 | ERROR | [x] Array indentation error, expected 6 spaces but found | | 8 148 | ERROR | [x] Array indentation error, expected 6 spaces but found | | 8 149 | ERROR | [x] Array indentation error, expected 6 spaces but found | | 8 150 | ERROR | [x] Array indentation error, expected 6 spaces but found | | 8 151 | ERROR | [x] Array indentation error, expected 6 spaces but found | | 8 152 | ERROR | [x] Array indentation error, expected 6 spaces but found | | 8 153 | ERROR | [x] Array indentation error, expected 6 spaces but found | | 8 154 | ERROR | [x] Array indentation error, expected 6 spaces but found | | 8 155 | ERROR | [x] Array indentation error, expected 6 spaces but found | | 8 156 | ERROR | [x] Array indentation error, expected 6 spaces but found | | 8 157 | ERROR | [x] Array indentation error, expected 6 spaces but found | | 8 158 | ERROR | [x] Array indentation error, expected 6 spaces but found | | 8 159 | ERROR | [x] Array indentation error, expected 6 spaces but found | | 8 160 | ERROR | [x] Array indentation error, expected 6 spaces but found | | 8 161 | ERROR | [x] Array indentation error, expected 6 spaces but found | | 8 162 | ERROR | [x] Array indentation error, expected 6 spaces but found | | 8 163 | ERROR | [x] Array indentation error, expected 6 spaces but found | | 8 164 | ERROR | [x] Array indentation error, expected 6 spaces but found | | 8 165 | ERROR | [x] Array indentation error, expected 6 spaces but found | | 8 166 | ERROR | [x] Array indentation error, expected 6 spaces but found | | 8 167 | ERROR | [x] Array indentation error, expected 6 spaces but found | | 8 168 | ERROR | [x] Array indentation error, expected 6 spaces but found | | 8 169 | ERROR | [x] Array indentation error, expected 6 spaces but found | | 8 171 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found | | 4 172 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found | | 4 180 | ERROR | [x] Expected 1 space before opening brace; found 0 181 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found | | 4 182 | ERROR | [x] Array indentation error, expected 6 spaces but found | | 8 183 | ERROR | [x] Array indentation error, expected 6 spaces but found | | 8 186 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found | | 4 187 | ERROR | [x] Array indentation error, expected 6 spaces but found | | 8 188 | ERROR | [x] Array indentation error, expected 6 spaces but found | | 8 189 | ERROR | [x] Array indentation error, expected 6 spaces but found | | 8 192 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found | | 4 194 | WARNING | [x] A comma should follow the last multiline array item. | | Found: 'Submit' 197 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found | | 4 205 | ERROR | [x] Expected 1 space before opening brace; found 0 207 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found | | 4 208 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found | | 4 208 | ERROR | [x] Expected 1 space after IF keyword; 0 found 208 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 209 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found | | 8 210 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found | | 4 211 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found | | 4 212 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found | | 4 213 | ERROR | [x] Expected 1 newline at end of file; 0 found -------------------------------------------------------------------------- PHPCBF CAN FIX THE 144 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------- Time: 292ms; Memory: 4Mb