https://git.drupal.org/project/menu_pager 8.x-1.x

Primary tabs

Review of the 8.x-1.x branch (commit a86a576):
  • The menu_pager.module does not implement hook_help(). See https://www.drupal.org/docs/develop/documenting-your-project/module-docu... .
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: ...endor/drupal/pareviewsh/pareview_temp/src/Plugin/Block/MenuBlock.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     267 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
    --------------------------------------------------------------------------
    
    Time: 404ms; Memory: 4Mb
    
  • No automated test cases were found, did you consider writing PHPUnit tests? This is not a requirement but encouraged for professional software development.
This automated report was generated with PAReview.sh, your friendly project application review script.

FILE: ...endor/drupal/pareviewsh/pareview_temp/src/Plugin/Block/MenuBlock.php
--------------------------------------------------------------------------
FOUND 3 ERRORS AND 2 WARNINGS AFFECTING 5 LINES
--------------------------------------------------------------------------
 134 | WARNING | [x] A comma should follow the last multiline array item.
     |         |     Found: ]
 147 | WARNING | [x] A comma should follow the last multiline array item.
     |         |     Found: ]
 263 | ERROR   | [x] Visibility must be declared on method
     |         |     "menuPagerIgnorePaths"
 280 | ERROR   | [x] Expected 1 blank line after function; 0 found
 281 | ERROR   | [x] The closing brace for the class must have an empty
     |         |     line before it
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...ite1101/web/vendor/drupal/pareviewsh/pareview_temp/menu_pager.module
--------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------
 6 | ERROR | [x] Doc comment short description must be on the first line
 7 | ERROR | [ ] Doc comment short description must be on a single line,
   |       |     further text should be a separate paragraph
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Time: 828ms; Memory: 6Mb