https://git.drupal.org/project/message.git 8.x-1.x

Primary tabs

Git errors: Review of the 8.x-1.x branch (commit 1aafb6a):
  • Your README.md does not follow best practices (headings need to be uppercase). See https://www.drupal.org/node/2181737 .
    • The INTRODUCTION section is missing.
    • The REQUIREMENTS section is missing.
    • The INSTALLATION section is missing.
    • The CONFIGURATION section is missing.
  • The message_example.module does not implement hook_help(). See https://www.drupal.org/docs/develop/documenting-your-project/module-docu... .
  • The message.module does not implement hook_help(). See https://www.drupal.org/docs/develop/documenting-your-project/module-docu... .
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: ...wsh/pareview_temp/modules/message_example/message_example.tokens.inc
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
    --------------------------------------------------------------------------
     65 | WARNING | Unused variable $token_service.
     67 | WARNING | Unused variable $url_options.
     70 | WARNING | Unused variable $langcode.
     75 | WARNING | Unused variable $sanitize.
    --------------------------------------------------------------------------
    
    
    FILE: ...iewsh/pareview_temp/modules/message_example/message_example.info.yml
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
    --------------------------------------------------------------------------
      7 | WARNING | All dependencies must be prefixed with the project name,
        |         | for example "drupal:"
      8 | WARNING | All dependencies must be prefixed with the project name,
        |         | for example "drupal:"
      9 | WARNING | All dependencies must be prefixed with the project name,
        |         | for example "drupal:"
     10 | WARNING | All dependencies must be prefixed with the project name,
        |         | for example "drupal:"
    --------------------------------------------------------------------------
    
    
    FILE: ...site1101/web/vendor/drupal/pareviewsh/pareview_temp/message.info.yml
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     8 | WARNING | All dependencies must be prefixed with the project name,
       |         | for example "drupal:"
    --------------------------------------------------------------------------
    
    
    FILE: ...eb/vendor/drupal/pareviewsh/pareview_temp/src/MessageViewBuilder.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     23 | WARNING | Variable $partials is undefined.
    --------------------------------------------------------------------------
    
    
    FILE: ...dor/drupal/pareviewsh/pareview_temp/src/Form/MessageSettingsForm.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 6 WARNINGS AFFECTING 6 LINES
    --------------------------------------------------------------------------
      94 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     100 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     101 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     109 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     114 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     147 | WARNING | Unused variable $entity_id.
    --------------------------------------------------------------------------
    
    
    FILE: ...dor/drupal/pareviewsh/pareview_temp/src/Form/MessageTemplateForm.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
    --------------------------------------------------------------------------
     135 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     136 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
    --------------------------------------------------------------------------
    
    
    FILE: ...areviewsh/pareview_temp/tests/src/Functional/MessageEntityDelete.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
    --------------------------------------------------------------------------
     171 | WARNING | Unused variable $delete_queue.
     173 | WARNING | Unused variable $check_delete_queue.
    --------------------------------------------------------------------------
    
    
    FILE: ...dor/drupal/pareviewsh/pareview_temp/tests/src/Kernel/MessageTest.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     58 | WARNING | @expectedException tags should not be used, use
        |         | $§this->setExpectedException() or
        |         | $this->expectException() instead
    --------------------------------------------------------------------------
    
    
    FILE: ...wsh/pareview_temp/tests/src/Kernel/Plugin/MessagePurge/QuotaTest.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     69 | WARNING | Unused variable $i.
    --------------------------------------------------------------------------
    
    Time: 5.02 secs; Memory: 8Mb
    
This automated report was generated with PAReview.sh, your friendly project application review script.

FILE: ...000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/README.md
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
--------------------------------------------------------------------------
  1 | WARNING | Line exceeds 80 characters; contains 114 characters
 21 | WARNING | Line exceeds 80 characters; contains 85 characters
 65 | WARNING | Line exceeds 80 characters; contains 82 characters
 90 | WARNING | Line exceeds 80 characters; contains 84 characters
--------------------------------------------------------------------------


FILE: ...endor/drupal/pareviewsh/pareview_temp/src/Entity/MessageTemplate.php
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
--------------------------------------------------------------------------
   5 | WARNING | [x] Unused use statement
 310 | WARNING | [ ] Possible useless method overriding detected
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...01/web/vendor/drupal/pareviewsh/pareview_temp/src/Entity/Message.php
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 5 WARNINGS AFFECTING 5 LINES
--------------------------------------------------------------------------
   6 | WARNING | [x] Unused use statement
   7 | WARNING | [x] Unused use statement
 336 | WARNING | [ ] Possible useless method overriding detected
 346 | WARNING | [ ] Possible useless method overriding detected
 356 | WARNING | [ ] Possible useless method overriding detected
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...dor/drupal/pareviewsh/pareview_temp/src/Plugin/MessagePurge/Days.php
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
 5 | WARNING | [x] Unused use statement
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...dor/drupal/pareviewsh/pareview_temp/src/Form/MessageTemplateForm.php
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
 143 | WARNING | Possible useless method overriding detected
--------------------------------------------------------------------------


FILE: ...ts/src/Kernel/Plugin/QueueWorker/MessageCheckAndDeleteWorkerTest.php
--------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
--------------------------------------------------------------------------
  7 | WARNING | [x] Unused use statement
 29 | ERROR   | [ ] If the line declaring an array spans longer than 80
    |         |     characters, each element should be broken into its
    |         |     own line
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...0/site1101/web/vendor/drupal/pareviewsh/pareview_temp/message.module
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
 10 | WARNING | [x] Unused use statement
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Time: 7.32 secs; Memory: 8Mb