Revision of https://git.drupal.org/project/move_articles from Tue, 01/14/2020 - 18:18

Revisions allow you to track differences between multiple versions of your content, and revert back to older versions.

Review of the 8.x-1.x branch (commit 6ddfca7):
  • Your README.txt does not follow best practices (headings need to be uppercase). See https://www.drupal.org/node/2181737 .
    • The REQUIREMENTS section is missing.
  • Bad line endings were found, always use unix style terminators. See https://www.drupal.org/coding-standards#indenting
    ./README.txt:                           ASCII text, with CRLF line terminators
    README.txt
    
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: ...drupal/pareviewsh/pareview_temp/src/Form/MoveArticlesSettingForm.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
    --------------------------------------------------------------------------
     211 | WARNING | Term::load calls should be avoided in classes, use
         |         | dependency injection instead
     214 | WARNING | Term::load calls should be avoided in classes, use
         |         | dependency injection instead
    --------------------------------------------------------------------------
    
    Time: 359ms; Memory: 4Mb
    
  • No automated test cases were found, did you consider writing PHPUnit tests? This is not a requirement but encouraged for professional software development.
This automated report was generated with PAReview.sh, your friendly project application review script.

FILE: ...drupal/pareviewsh/pareview_temp/src/Form/MoveArticlesSettingForm.php
--------------------------------------------------------------------------
FOUND 10 ERRORS AND 1 WARNING AFFECTING 9 LINES
--------------------------------------------------------------------------
  20 | ERROR   | [ ] Missing short description in doc comment
  21 | ERROR   | [x] Data types in @var tags need to be fully namespaced
  21 | ERROR   | [x] Do not append variable name "$account" to the type
     |         |     declaration in a member variable comment
  23 | ERROR   | [x] Whitespace found at end of line
  25 | ERROR   | [x] Whitespace found at end of line
  26 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found
     |         |     1
  26 | ERROR   | [ ] Missing short description in doc comment
  28 | ERROR   | [x] Whitespace found at end of line
  38 | ERROR   | [x] Whitespace found at end of line
  77 | ERROR   | [x] Inline comments must end in full-stops, exclamation
     |         |     marks, colons, question marks, or closing
     |         |     parentheses
 218 | WARNING | [ ] Only string literals should be passed to t() where
     |         |     possible
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 8 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Time: 687ms; Memory: 6Mb