Revision of https://git.drupal.org/project/node_email.git from Tue, 06/11/2019 - 02:47

Revisions allow you to track differences between multiple versions of your content, and revert back to older versions.

Git errors: Review of the node_email branch (commit 6b79372):
  • Your README.txt does not follow best practices (headings need to be uppercase). See https://www.drupal.org/node/2181737 .
    • The INTRODUCTION section is missing.
    • The REQUIREMENTS section is missing.
    • The INSTALLATION section is missing.
    • The CONFIGURATION section is missing.
  • Remove "version" from the ./node_email.info file, it will be added by drupal.org packaging automatically.
  • Remove "project" from the ./node_email.info file, it will be added by drupal.org packaging automatically.
  • Remove "datestamp" from the ./node_email.info file, it will be added by drupal.org packaging automatically.
  • The node_email.module does not implement hook_help(). See https://www.drupal.org/docs/develop/documenting-your-project/module-docu... .
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: ...ite1101/web/vendor/drupal/pareviewsh/pareview_temp/node_email.module
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     23 | WARNING | Do not use the raw $form_state['input'], use
        |         | $form_state['values'] instead where possible
    --------------------------------------------------------------------------
    
    Time: 158ms; Memory: 4Mb
    
  • No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.
This automated report was generated with PAReview.sh, your friendly project application review script.

FILE: ...ite1101/web/vendor/drupal/pareviewsh/pareview_temp/node_email.module
--------------------------------------------------------------------------
FOUND 81 ERRORS AND 3 WARNINGS AFFECTING 52 LINES
--------------------------------------------------------------------------
 12 | ERROR   | [x] Spaces must be used to indent lines; tabs are not
    |         |     allowed
 12 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 1
 20 | ERROR   | [x] Spaces must be used to indent lines; tabs are not
    |         |     allowed
 20 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 1
 20 | ERROR   | [x] Expected 1 space after IF keyword; 0 found
 21 | ERROR   | [x] Spaces must be used to indent lines; tabs are not
    |         |     allowed
 21 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 2
 23 | ERROR   | [x] Spaces must be used to indent lines; tabs are not
    |         |     allowed
 23 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 2
 24 | ERROR   | [x] Spaces must be used to indent lines; tabs are not
    |         |     allowed
 24 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 3
 25 | ERROR   | [x] Spaces must be used to indent lines; tabs are not
    |         |     allowed
 25 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 5
 26 | ERROR   | [x] Spaces must be used to indent lines; tabs are not
    |         |     allowed
 26 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 5
 27 | ERROR   | [x] Spaces must be used to indent lines; tabs are not
    |         |     allowed
 27 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 5
 28 | ERROR   | [x] Spaces must be used to indent lines; tabs are not
    |         |     allowed
 28 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 5
 29 | ERROR   | [x] Spaces must be used to indent lines; tabs are not
    |         |     allowed
 29 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 5
 30 | ERROR   | [x] Spaces must be used to indent lines; tabs are not
    |         |     allowed
 30 | ERROR   | [x] Array indentation error, expected 7 spaces but found
    |         |     9
 31 | ERROR   | [x] Spaces must be used to indent lines; tabs are not
    |         |     allowed
 31 | ERROR   | [x] Array indentation error, expected 7 spaces but found
    |         |     9
 32 | ERROR   | [x] Spaces must be used to indent lines; tabs are not
    |         |     allowed
 34 | ERROR   | [x] Spaces must be used to indent lines; tabs are not
    |         |     allowed
 35 | ERROR   | [x] Spaces must be used to indent lines; tabs are not
    |         |     allowed
 36 | ERROR   | [x] Spaces must be used to indent lines; tabs are not
    |         |     allowed
 36 | ERROR   | [x] Expected 1 space after IF keyword; 0 found
 37 | ERROR   | [x] Spaces must be used to indent lines; tabs are not
    |         |     allowed
 37 | ERROR   | [x] Line indented incorrectly; expected 7 spaces, found 9
 38 | ERROR   | [x] Spaces must be used to indent lines; tabs are not
    |         |     allowed
 38 | ERROR   | [x] Line indented incorrectly; expected 7 spaces, found 9
 39 | ERROR   | [x] Spaces must be used to indent lines; tabs are not
    |         |     allowed
 39 | ERROR   | [x] Line indented incorrectly; expected 7 spaces, found 9
 40 | ERROR   | [x] Spaces must be used to indent lines; tabs are not
    |         |     allowed
 40 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 5
 40 | ERROR   | [x] Expected newline after closing brace
 41 | ERROR   | [x] Spaces must be used to indent lines; tabs are not
    |         |     allowed
 41 | ERROR   | [x] Line indented incorrectly; expected 8 spaces, found 9
 42 | ERROR   | [x] Spaces must be used to indent lines; tabs are not
    |         |     allowed
 42 | ERROR   | [x] Line indented incorrectly; expected 8 spaces, found 9
 43 | ERROR   | [x] Spaces must be used to indent lines; tabs are not
    |         |     allowed
 43 | ERROR   | [x] Line indented incorrectly; expected 8 spaces, found 9
 44 | ERROR   | [x] Spaces must be used to indent lines; tabs are not
    |         |     allowed
 44 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 5
 45 | ERROR   | [x] Spaces must be used to indent lines; tabs are not
    |         |     allowed
 45 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 1
 49 | WARNING | [ ] Format should be "* Implements hook_foo().", "*
    |         |     Implements hook_foo_BAR_ID_bar() for xyz_bar().",, "*
    |         |     Implements hook_foo_BAR_ID_bar() for
    |         |     xyz-bar.html.twig.", "* Implements
    |         |     hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.", or "*
    |         |     Implements hook_foo_BAR_ID_bar() for block
    |         |     templates."
 50 | ERROR   | [x] There must be exactly one blank line before the tags
    |         |     in a doc comment
 50 | ERROR   | [ ] Missing parameter comment
 53 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 54 | ERROR   | [x] Array indentation error, expected 6 spaces but found
    |         |     8
 55 | ERROR   | [x] Array indentation error, expected 6 spaces but found
    |         |     8
 56 | ERROR   | [x] Array indentation error, expected 6 spaces but found
    |         |     8
 57 | ERROR   | [x] Array indentation error, expected 6 spaces but found
    |         |     8
 59 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 60 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 61 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 65 | WARNING | [ ] Format should be "* Implements hook_foo().", "*
    |         |     Implements hook_foo_BAR_ID_bar() for xyz_bar().",, "*
    |         |     Implements hook_foo_BAR_ID_bar() for
    |         |     xyz-bar.html.twig.", "* Implements
    |         |     hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.", or "*
    |         |     Implements hook_foo_BAR_ID_bar() for block
    |         |     templates."
 66 | ERROR   | [x] There must be exactly one blank line before the tags
    |         |     in a doc comment
 66 | ERROR   | [ ] Missing parameter comment
 67 | ERROR   | [ ] Missing parameter comment
 68 | ERROR   | [ ] Missing parameter comment
 70 | ERROR   | [ ] Type hint "unknown_type" missing for $params
 72 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 72 | ERROR   | [x] No space found before comment text; expected "//
    |         |     Language Selection" but found "//Language Selection"
 72 | ERROR   | [x] Inline comments must end in full-stops, exclamation
    |         |     marks, colons, question marks, or closing parentheses
 73 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 74 | ERROR   | [x] Array indentation error, expected 6 spaces but found
    |         |     8
 76 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 76 | ERROR   | [x] Expected 1 space after SWITCH keyword; 0 found
 77 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 77 | ERROR   | [x] There must be no space before the colon in a CASE
    |         |     statement
 78 | ERROR   | [x] Spaces must be used to indent lines; tabs are not
    |         |     allowed
 78 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 9
 78 | WARNING | [ ] Translatable strings must not begin or end with white
    |         |     spaces, use placeholders with t() for variables
 79 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found
    |         |     12
 80 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found
    |         |     12
 81 | ERROR   | [x] Line indented incorrectly; expected 8 spaces, found
    |         |     16
 82 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found
    |         |     12
 83 | ERROR   | [x] Case breaking statement indented incorrectly;
    |         |     expected 10 spaces, found 12
 84 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 76 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: .../site1101/web/vendor/drupal/pareviewsh/pareview_temp/node_email.info
--------------------------------------------------------------------------
FOUND 1 ERROR AND 2 WARNINGS AFFECTING 1 LINE
--------------------------------------------------------------------------
 1 | WARNING | Remove "project" from the info file, it will be added by
   |         | drupal.org packaging automatically
 1 | WARNING | Remove "version" from the info file, it will be added by
   |         | drupal.org packaging automatically
 1 | ERROR   | Duplicate entry for "version" in info file
--------------------------------------------------------------------------

Time: 395ms; Memory: 4Mb