https://git.drupal.org/project/nodeaccess.git 8.x-1.x

Primary tabs

Git errors: Review of the 8.x-1.x branch (commit fb8ce53):
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: ...1/web/vendor/drupal/pareviewsh/pareview_temp/src/Form/GrantsForm.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 6 WARNINGS AFFECTING 6 LINES
    --------------------------------------------------------------------------
      26 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
     144 | WARNING | Unused variable $preserve.
     290 | WARNING | Node::load calls should be avoided in classes, use
         |         | dependency injection instead
     310 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
     323 | WARNING | Unused variable $id.
     325 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
    --------------------------------------------------------------------------
    
    
    FILE: ...1/web/vendor/drupal/pareviewsh/pareview_temp/src/Form/ConfigForm.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
    --------------------------------------------------------------------------
      48 | WARNING | NodeType::loadMultiple calls should be avoided in
         |         | classes, use dependency injection instead
     206 | WARNING | NodeType::loadMultiple calls should be avoided in
         |         | classes, use dependency injection instead
    --------------------------------------------------------------------------
    
    Time: 513ms; Memory: 4Mb
    
  • No automated test cases were found, did you consider writing PHPUnit tests? This is not a requirement but encouraged for professional software development.
This automated report was generated with PAReview.sh, your friendly project application review script.