https://git.drupal.org/project/panels_breadcrumbs.git 7.x-2.x

Primary tabs

Git errors: Review of the 7.x-2.x branch (commit 44c83e3):
  • Your README.txt does not follow best practices (headings need to be uppercase). See https://www.drupal.org/node/2181737 .
    • The INTRODUCTION section is missing.
    • The REQUIREMENTS section is missing.
    • The INSTALLATION section is missing.
    • The CONFIGURATION section is missing.
  • The panels_breadcrumbs.module does not implement hook_help(). See https://www.drupal.org/docs/develop/documenting-your-project/module-docu... .
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: ...web/vendor/drupal/pareviewsh/pareview_temp/panels_breadcrumbs.module
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 3 LINES
    --------------------------------------------------------------------------
     252 | WARNING | There must be no blank line following an inline comment
     365 | WARNING | There must be no blank line following an inline comment
     388 | WARNING | Unused variable $revision_id.
     388 | WARNING | Unused variable $bundle.
    --------------------------------------------------------------------------
    
    Time: 521ms; Memory: 6Mb
    
  • No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.
This automated report was generated with PAReview.sh, your friendly project application review script.

FILE: ...web/vendor/drupal/pareviewsh/pareview_temp/panels_breadcrumbs.module
--------------------------------------------------------------------------
FOUND 24 ERRORS AND 5 WARNINGS AFFECTING 24 LINES
--------------------------------------------------------------------------
  76 | ERROR   | [ ] Missing parameter comment
  76 | ERROR   | [ ] Missing parameter type
  77 | ERROR   | [ ] Missing parameter comment
  77 | ERROR   | [ ] Missing parameter type
  78 | ERROR   | [x] Separate the @param and @return sections by a blank
     |         |     line.
  78 | ERROR   | [ ] Return type missing for @return tag in function
     |         |     comment
  79 | ERROR   | [x] Return comment indentation must be 3 spaces, found 2
     |         |     spaces
 149 | ERROR   | [ ] Missing parameter type
 157 | WARNING | [ ] Line exceeds 80 characters; contains 86 characters
 159 | ERROR   | [ ] Missing parameter type
 161 | ERROR   | [ ] Missing parameter type
 162 | WARNING | [ ] Line exceeds 80 characters; contains 85 characters
 163 | ERROR   | [x] Separate the @param and @return sections by a blank
     |         |     line.
 175 | ERROR   | [ ] Function return type is not void, but function is
     |         |     returning void here
 183 | ERROR   | [x] Inline comments must end in full-stops, exclamation
     |         |     marks, colons, question marks, or closing
     |         |     parentheses
 187 | ERROR   | [x] Inline comments must end in full-stops, exclamation
     |         |     marks, colons, question marks, or closing
     |         |     parentheses
 202 | ERROR   | [x] Inline comments must end in full-stops, exclamation
     |         |     marks, colons, question marks, or closing
     |         |     parentheses
 207 | ERROR   | [x] Inline comments must end in full-stops, exclamation
     |         |     marks, colons, question marks, or closing
     |         |     parentheses
 211 | WARNING | [ ] Only string literals should be passed to t() where
     |         |     possible
 223 | ERROR   | [x] Inline comments must end in full-stops, exclamation
     |         |     marks, colons, question marks, or closing
     |         |     parentheses
 227 | ERROR   | [x] Inline comments must end in full-stops, exclamation
     |         |     marks, colons, question marks, or closing
     |         |     parentheses
 239 | ERROR   | [x] Inline comments must end in full-stops, exclamation
     |         |     marks, colons, question marks, or closing
     |         |     parentheses
 252 | WARNING | [x] There must be no blank line following an inline
     |         |     comment
 252 | ERROR   | [x] Inline comments must end in full-stops, exclamation
     |         |     marks, colons, question marks, or closing
     |         |     parentheses
 258 | ERROR   | [x] Inline comments must end in full-stops, exclamation
     |         |     marks, colons, question marks, or closing
     |         |     parentheses
 365 | WARNING | [x] There must be no blank line following an inline
     |         |     comment
 365 | ERROR   | [x] Inline comments must end in full-stops, exclamation
     |         |     marks, colons, question marks, or closing
     |         |     parentheses
 393 | ERROR   | [ ] If the line declaring an array spans longer than 80
     |         |     characters, each element should be broken into its
     |         |     own line
 555 | ERROR   | [x] Inline comments must end in full-stops, exclamation
     |         |     marks, colons, question marks, or closing
     |         |     parentheses
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 16 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...1/web/vendor/drupal/pareviewsh/pareview_temp/panels_breadcrumbs.info
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 7 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...00/site1101/web/vendor/drupal/pareviewsh/pareview_temp/CHANGELOG.txt
--------------------------------------------------------------------------
FOUND 1 ERROR AND 4 WARNINGS AFFECTING 4 LINES
--------------------------------------------------------------------------
  3 | WARNING | [ ] Line exceeds 80 characters; contains 120 characters
 11 | WARNING | [ ] Line exceeds 80 characters; contains 115 characters
 21 | WARNING | [ ] Line exceeds 80 characters; contains 89 characters
 25 | WARNING | [ ] Line exceeds 80 characters; contains 91 characters
 25 | ERROR   | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Time: 865ms; Memory: 8Mb